Merge pull request #967 from github/jeongsoolee09/MISRA-C++-2023-Memory

Implement `Memory1` (`RULE-8-7-1`)

Author: jeongsoolee09

cpp/common/src/codingstandards/cpp/OutOfBounds.qll

@@ -0,0 +1,44 @@
+//** THIS FILE IS AUTOGENERATED, DO NOT MODIFY DIRECTLY.  **/
+import cpp
+import RuleMetadata
+import codingstandards.cpp.exclusions.RuleMetadata
+
+newtype Memory1Query =
+  TPointerArithmeticFormsAnInvalidPointerQuery() or
+  TPointerArgumentToCstringFunctionIsInvalidQuery()
+
+predicate isMemory1QueryMetadata(Query query, string queryId, string ruleId, string category) {
+  query =
+    // `Query` instance for the `pointerArithmeticFormsAnInvalidPointer` query
+    Memory1Package::pointerArithmeticFormsAnInvalidPointerQuery() and
+  queryId =
+    // `@id` for the `pointerArithmeticFormsAnInvalidPointer` query
+    "cpp/misra/pointer-arithmetic-forms-an-invalid-pointer" and
+  ruleId = "RULE-8-7-1" and
+  category = "required"
+  or
+  query =
+    // `Query` instance for the `pointerArgumentToCstringFunctionIsInvalid` query
+    Memory1Package::pointerArgumentToCstringFunctionIsInvalidQuery() and
+  queryId =
+    // `@id` for the `pointerArgumentToCstringFunctionIsInvalid` query
+    "cpp/misra/pointer-argument-to-cstring-function-is-invalid" and
+  ruleId = "RULE-8-7-1" and
+  category = "required"
+}
+
+module Memory1Package {
+  Query pointerArithmeticFormsAnInvalidPointerQuery() {
+    //autogenerate `Query` type
+    result =
+      // `Query` type for `pointerArithmeticFormsAnInvalidPointer` query
+      TQueryCPP(TMemory1PackageQuery(TPointerArithmeticFormsAnInvalidPointerQuery()))
+  }
+
+  Query pointerArgumentToCstringFunctionIsInvalidQuery() {
+    //autogenerate `Query` type
+    result =
+      // `Query` type for `pointerArgumentToCstringFunctionIsInvalid` query
+      TQueryCPP(TMemory1PackageQuery(TPointerArgumentToCstringFunctionIsInvalidQuery()))
+  }
+}

cpp/common/src/codingstandards/cpp/exclusions/cpp/Memory1.qll

@@ -65,6 +65,7 @@ import Linkage2
 import Literals
 import Loops
 import Macros
+import Memory1
 import Memory2
 import Memory3
 import Memory4
@@ -171,6 +172,7 @@ newtype TCPPQuery =
   TLiteralsPackageQuery(LiteralsQuery q) or
   TLoopsPackageQuery(LoopsQuery q) or
   TMacrosPackageQuery(MacrosQuery q) or
+  TMemory1PackageQuery(Memory1Query q) or
   TMemory2PackageQuery(Memory2Query q) or
   TMemory3PackageQuery(Memory3Query q) or
   TMemory4PackageQuery(Memory4Query q) or
@@ -277,6 +279,7 @@ predicate isQueryMetadata(Query query, string queryId, string ruleId, string cat
   isLiteralsQueryMetadata(query, queryId, ruleId, category) or
   isLoopsQueryMetadata(query, queryId, ruleId, category) or
   isMacrosQueryMetadata(query, queryId, ruleId, category) or
+  isMemory1QueryMetadata(query, queryId, ruleId, category) or
   isMemory2QueryMetadata(query, queryId, ruleId, category) or
   isMemory3QueryMetadata(query, queryId, ruleId, category) or
   isMemory4QueryMetadata(query, queryId, ruleId, category) or

cpp/common/src/codingstandards/cpp/exclusions/cpp/RuleMetadata.qll

@@ -26,5 +26,8 @@ using ::strtoll;
 using ::strtoul;
 using ::strtoull;
 using ::system;
+using ::malloc;
+using ::calloc;
+using ::realloc;
 } // namespace std
 #endif // _GHLIBCPP_CSTDLIB

cpp/common/test/includes/standard-library/cstdlib

@@ -37,4 +37,10 @@ long double strtold(const char *str, char **endptr);
 
 int rand(void);
 
+int mblen (const char *, size_t);
+int mbtowc (wchar_t *__restrict, const char *__restrict, size_t);
+int wctomb (char *, wchar_t);
+size_t mbstowcs (wchar_t *__restrict, const char *__restrict, size_t);
+size_t wcstombs (char *__restrict, const wchar_t *__restrict, size_t);
+
 #endif // _GHLIBCPP_STDLIB

cpp/common/test/includes/standard-library/stdlib.h

@@ -43,5 +43,6 @@ void *memcpy(void *dest, const void *src, size_t count);
 void *memset(void *dest, int ch, size_t count);
 void *memmove(void *dest, const void *src, size_t count);
 int memcmp(const void *lhs, const void *rhs, size_t count);
+void *memchr (const void *, int, size_t);
 
-#endif // _GHLIBCPP_STRINGH
+#endif // _GHLIBCPP_STRINGH

cpp/common/test/includes/standard-library/string.h

@@ -17,6 +17,9 @@ double wcstod(const wchar_t *str, wchar_t **endptr);
 float wcstof(const wchar_t *str, wchar_t **endptr);
 long double wcstold(const wchar_t *str, wchar_t **endptr);
 
+size_t wcsftime (wchar_t *__restrict, size_t, const wchar_t *__restrict, const struct tm *__restrict);
+size_t wcsxfrm (wchar_t *__restrict, const wchar_t *__restrict, size_t);
+
 // Character classification and conversion types
 typedef struct {
   int __count;
@@ -26,4 +29,4 @@ typedef struct {
   } __value;
 } mbstate_t;
 
-#endif // _GHLIBCPP_WCHAR
+#endif // _GHLIBCPP_WCHAR

cpp/common/test/includes/standard-library/wchar.h

@@ -0,0 +1,28 @@
+/**
+ * @id cpp/misra/pointer-argument-to-cstring-function-is-invalid
+ * @name RULE-8-7-1: Pointer and index arguments passed to functions in <cstring> shall not be invalid
+ * @description Pointer and index arguments passed to functions in <cstring> should result in valid
+ *              reads and/or writes.
+ * @kind problem
+ * @precision high
+ * @problem.severity error
+ * @tags external/misra/id/rule-8-7-1
+ *       scope/system
+ *       correctness
+ *       security
+ *       external/misra/enforcement/undecidable
+ *       external/misra/obligation/required
+ */
+
+import cpp
+import codingstandards.cpp.misra
+import codingstandards.cpp.OutOfBounds // for OOB::problems
+import codingstandards.cpp.Exclusions // for isExcluded(Element, Query)
+
+from
+  OOB::BufferAccessLibraryFunctionCall fc, string message, Expr bufferArg, string bufferArgStr,
+  Expr sizeOrOtherBufferArg, string otherStr
+where
+  not isExcluded(fc, Memory1Package::pointerArgumentToCstringFunctionIsInvalidQuery()) and
+  OOB::problems(fc, message, bufferArg, bufferArgStr, sizeOrOtherBufferArg, otherStr)
+select fc, message, bufferArg, bufferArgStr, sizeOrOtherBufferArg, otherStr