Gio.ListStore.Append now results in "System.NotSupportedException"

[PlatinumLucario]

As I was testing my code in the new GirCore format, ListStore.Append no longer works like it used to. (Also, GitHub won't let me add attachments such as screenshots to discussions anymore, and I'm not sure why)

It now comes up with this when it gets to line 417 in PlaylistSelector:

Exception has occurred: CLR/System.NotSupportedException
Exception thrown: 'System.NotSupportedException' in GObject-2.0.dll: 'Unable to extract the value for type ''. The type (id: 0) is unknown.'
   at GObject.Value.CheckComplexTypes(UIntPtr gtype)
   at GObject.Value.Extract()
   at GObject.Value.Extract[T]()
   at GObject.Property`2.Get(K obj)
   at Gio.ListStore.get_NItems()
   at Kermalis.VGMusicStudio.GTK4.PlaylistSelector.AddPlaylistEntries(List`1 playlists) in /run/media/platinumlucario/Storage/source/repos/VGMusicStudio/VG Music Studio - GTK4/PlaylistSelector.cs:line 417

Is there anything I need to change to make it work?

using System;
using System.Collections.Generic;
using GObject;
using Gtk;
using Kermalis.VGMusicStudio.Core;
using Kermalis.VGMusicStudio.Core.Properties;

namespace Kermalis.VGMusicStudio.GTK4;

[Subclass<Box>]
internal partial class PlaylistSelector
{
    public DropDown? PlaylistDropDown { get; set; }
    public DropDown? PlaylistSongDropDown { get; set; }
    public GestureClick? PlaylistClick { get; set; }
    public GestureClick? PlaylistSongClick { get; set; }
    public ToggleButton? ButtonPlayPlist;
    public Button? ButtonPlistStyle;
    public Button? ButtonPrevPlistSong, ButtonNextPlistSong;
    public uint SelectedPlaylistIndex, SelectedSongIndex = 0;
    public static int PrevSelectedPlaylistIndex, PrevSelectedSongIndex = -1;
    private SignalListItemFactory? PlaylistFactory;
    private SignalListItemFactory? SongFactory;
    private static Gio.ListStore PlaylistModel = Gio.ListStore.New(GetGType());
    private static Gio.ListStore PlaylistSongModel = Gio.ListStore.New(GetGType());
    private List<Config.Playlist>? Playlists { get; set; }
    internal List<Config.Song>? Songs { get; set; }
    private Box? PlaylistBox, PlaylistSongBoxDropDown;
    internal Box? PlaylistSongBox;
    private int Index { get; set; }
    private string? Title { get; set; }
    private string? ImageName { get; set; }
    private PlaylistSelector? SelectedPlaylist { get; set; }
    private PlaylistSelector? SelectedSong { get; set; }
    private static Contents[]? ContentsPlaylist { get; set; }
    private static Contents[]? ContentsSong { get; set; }
    internal bool PlaylistIsSelected = false;
    internal bool SongIsSelected = false;

    protected PlaylistSelector AddEntry(string title, string image, int index)
    {
        Title = title;
        ImageName = image;
        Index = index;
        return this;
    }
    partial void Initialize()
    {
        SetOrientation(Orientation.Vertical);
        Spacing = 1;
        Halign = Align.Center;

        IconTheme.GetForDisplay(Gdk.Display.GetDefault()!).AddResourcePath("/org/Kermalis/VGMusicStudio/GTK4/icons/scalable/actions");

        ButtonPlayPlist = ToggleButton.NewWithProperties([]);
        ButtonPlayPlist.Sensitive = false; ButtonPlayPlist.TooltipText = "Play Playlist"; ButtonPlayPlist.IconName = "vgms-play-playlist-symbolic";
        ButtonPlistStyle = Button.NewWithProperties([]);
        ButtonPlistStyle.Sensitive = false; ButtonPlistStyle.TooltipText = "Play Style";

        ButtonPrevPlistSong = Button.NewWithProperties([]);
        ButtonPrevPlistSong.Sensitive = false; ButtonPrevPlistSong.TooltipText = Strings.PlayerPreviousSong; ButtonPrevPlistSong.IconName = "media-skip-backward-symbolic";
        ButtonNextPlistSong = Button.NewWithProperties([]);
        ButtonNextPlistSong.Sensitive = false; ButtonNextPlistSong.TooltipText = Strings.PlayerNextSong; ButtonNextPlistSong.IconName = "media-skip-forward-symbolic";

        static ConstructArgument[] DropDownArgs()
        {
            ConstructArgument[] args =
            [
                new ConstructArgument("width_request", new Value(300)),
                new ConstructArgument("sensitive", new Value(0)),
            ];
            return args;
        }
        PlaylistDropDown = DropDown.NewWithProperties(DropDownArgs());
        PlaylistDropDown.SetModel(PlaylistModel);
        PlaylistSongDropDown = DropDown.NewWithProperties(DropDownArgs());
        PlaylistSongDropDown.SetModel(PlaylistSongModel);

        PlaylistFactory = SignalListItemFactory.New();
        PlaylistFactory.OnSetup += PlaylistFactory_SetupPlaylists;
        PlaylistFactory.OnBind += PlaylistFactory_BindPlaylists;

        PlaylistDropDown!.SetFactory(PlaylistFactory);

        SongFactory = SignalListItemFactory.New();
        SongFactory.OnSetup += SongFactory_SetupSongs;
        SongFactory.OnBind += SongFactory_BindSongs;

        PlaylistSongDropDown!.SetFactory(SongFactory);

        PlaylistBox = New(Orientation.Horizontal, 4);
        PlaylistBox.Halign = Align.Center;
        PlaylistSongBox = New(Orientation.Horizontal, 4);
        PlaylistSongBox.Halign = Align.Center;

        PlaylistBox.Append(ButtonPlayPlist);
        PlaylistBox.Append(PlaylistDropDown);
        PlaylistBox.Append(ButtonPlistStyle);
        PlaylistSongBoxDropDown = New(Orientation.Horizontal, 1);
        PlaylistSongBoxDropDown.Halign = Align.Center;
        PlaylistSongBoxDropDown.Append(PlaylistSongDropDown);
        PlaylistSongBox.MarginStart = 40;
        PlaylistSongBox.MarginEnd = 40;
        PlaylistSongBox.Append(ButtonPrevPlistSong);
        PlaylistSongBox.Append(PlaylistSongBoxDropDown);
        PlaylistSongBox.Append(ButtonNextPlistSong);

        Append(PlaylistBox);
        Append(PlaylistSongBox);
    }

    protected struct Contents()
    {
        internal Label Title = Label.New("");
        internal Image Image = Image.New();
        internal Image Checkmark = Image.NewFromIconName("object-select-symbolic");
    }

    private void PlaylistFactory_SetupPlaylists(SignalListItemFactory sender, SignalListItemFactory.SetupSignalArgs args)
    {
        if (args.Object is not ListItem item)
        {
            return;
        }
        if (Index >= ContentsPlaylist!.Length - 1)
        {
            Index = 0;
            ContentsPlaylist[^1] = new();
            ContentsPlaylist[^1].Title.SetXalign(0);
            ContentsPlaylist[^1].Title.SetMaxWidthChars(20);
            ContentsPlaylist[^1].Title.SetEllipsize(Pango.EllipsizeMode.End);

            Box box = New(Orientation.Horizontal, 10);

            box.Append(ContentsPlaylist[^1].Image);
            box.Append(ContentsPlaylist[^1].Title);
            box.Append(ContentsPlaylist[^1].Checkmark);

            item.SetChild(box);
        }
        else
        {
            ContentsPlaylist[Index] = new();
            ContentsPlaylist[Index].Title.SetXalign(0);
            ContentsPlaylist[Index].Title.SetMaxWidthChars(50);
            ContentsPlaylist[Index].Title.SetEllipsize(Pango.EllipsizeMode.End);

            Box box = New(Orientation.Horizontal, 10);

            box.Append(ContentsPlaylist[Index].Image);
            box.Append(ContentsPlaylist[Index].Title);
            box.Append(ContentsPlaylist[Index].Checkmark);

            item.SetChild(box);
            Index++;
        }
    }

    private void SongFactory_SetupSongs(SignalListItemFactory sender, SignalListItemFactory.SetupSignalArgs args)
    {
        if (args.Object is not ListItem item)
        {
            return;
        }
        if (Index >= ContentsSong!.Length - 1)
        {
            Index = 0;
            ContentsSong[^1] = new();
            ContentsSong[^1].Title.SetXalign(0);
            ContentsSong[^1].Title.SetMaxWidthChars(20);
            ContentsSong[^1].Title.SetEllipsize(Pango.EllipsizeMode.End);

            Box box = New(Orientation.Horizontal, 10);

            box.Append(ContentsSong[^1].Image);
            box.Append(ContentsSong[^1].Title);
            box.Append(ContentsSong[^1].Checkmark);

            item.SetChild(box);
        }
        else
        {
            ContentsSong[Index] = new();
            ContentsSong[Index].Title.SetXalign(0);
            ContentsSong[Index].Title.SetMaxWidthChars(50);
            ContentsSong[Index].Title.SetEllipsize(Pango.EllipsizeMode.End);

            Box box = New(Orientation.Horizontal, 10);

            box.Append(ContentsSong[Index].Image);
            box.Append(ContentsSong[Index].Title);
            box.Append(ContentsSong[Index].Checkmark);

            item.SetChild(box);
            Index++;
        }
    }

    private void PlaylistFactory_BindPlaylists(SignalListItemFactory sender, SignalListItemFactory.BindSignalArgs args)
    {
        if (args.Object is not ListItem item)
        {
            return;
        }
        if (item.Item is not PlaylistSelector holder)
        {
            return;
        }
        if (item.Child is not Box box)
        {
            return;
        }
        BindItems(ContentsPlaylist![(int)item.Position], holder, box);
    }

    private void SongFactory_BindSongs(SignalListItemFactory sender, SignalListItemFactory.BindSignalArgs args)
    {
        if (args.Object is not ListItem item)
        {
            return;
        }
        if (item.Item is not PlaylistSelector holder)
        {
            return;
        }
        if (item.Child is not Box box)
        {
            return;
        }
        BindItems(ContentsSong![(int)item.Position], holder, box);
    }

    private void BindItems(Contents contents, PlaylistSelector holder, Box box)
    {
        contents.Title = (Label)box.GetFirstChild()!.GetNextSibling()!;
        contents.Title.SetLabel(holder.Title!);
        contents.Image = (Image)box.GetFirstChild()!;
        contents.Image.SetFromIconName(holder.ImageName);
        contents.Checkmark = (Image)box.GetLastChild()!;
        Popover popup = (Popover)box.GetAncestor(Popover.GetGType())!;
        if (popup is not null)
        {
            if (popup.IsAncestor(PlaylistDropDown!))
            {
                DropDown dropdown = (DropDown)popup.GetAncestor(DropDown.GetGType())!;
                PlaylistSelector selectedItem = (PlaylistSelector)dropdown.SelectedItem!;
                if (selectedItem.Title == contents.Title.Label_)
                {
                    SelectedPlaylist = selectedItem;
                    contents.Checkmark.SetVisible(true);
                    dropdown.OnNotify += Playlist_Notify;
                }
                else
                {
                    contents.Checkmark.SetVisible(false);
                }
            }
            else if (popup.IsAncestor(PlaylistSongDropDown!))
            {
                DropDown dropdown = (DropDown)popup.GetAncestor(DropDown.GetGType())!;
                PlaylistSelector selectedItem = (PlaylistSelector)dropdown.SelectedItem!;
                if (selectedItem.Title == contents.Title.Label_)
                {
                    SelectedSong = selectedItem;
                    contents.Checkmark.SetVisible(true);
                    dropdown.OnNotify += Song_Notify;
                }
                else
                {
                    contents.Checkmark.SetVisible(false);
                }
            }
        }
        else
        {
            contents.Checkmark.SetVisible(false);
        }
    }

    private void Playlist_Notify(GObject.Object sender, NotifySignalArgs args)
    {
        var name = args.Pspec.GetName();
        if (args.Pspec.GetName() == "selected")
        {
            var dropdown = (DropDown)sender;

            PlaylistIsSelected = true;

            if (ContentsPlaylist is not null)
            {
                if (dropdown.Selected >= ContentsPlaylist.Length)
                {
                    return;
                }
            }

            if (ContentsPlaylist![PrevSelectedPlaylistIndex].Checkmark is null)
            {
                ContentsPlaylist![PrevSelectedPlaylistIndex] = new();
            }
            if (ContentsPlaylist[dropdown.Selected].Checkmark is null)
            {
                ContentsPlaylist[dropdown.Selected] = new();
            }

            ContentsPlaylist![PrevSelectedPlaylistIndex].Checkmark.SetVisible(false);
            ContentsPlaylist[dropdown.Selected].Checkmark.SetVisible(true);

            PrevSelectedPlaylistIndex = (int)dropdown.Selected;
        }
    }

    private void Song_Notify(GObject.Object sender, NotifySignalArgs args)
    {
        var name = args.Pspec.GetName();
        if (args.Pspec.GetName() == "selected")
        {
            var dropdown = (DropDown)sender;

            SongIsSelected = true;

            if (ContentsSong is not null)
            {
                if (dropdown.Selected >= ContentsSong.Length)
                {
                    return;
                }
            }

            if (ContentsSong![PrevSelectedSongIndex].Checkmark is null)
            {
                ContentsSong![PrevSelectedSongIndex] = new();
            }
            if (ContentsSong[dropdown.Selected].Checkmark is null)
            {
                ContentsSong[dropdown.Selected] = new();
            }

            ContentsSong![PrevSelectedSongIndex].Checkmark.SetVisible(false);
            ContentsSong[dropdown.Selected].Checkmark.SetVisible(true);

            PrevSelectedSongIndex = (int)dropdown.Selected;
        }
    }

    internal void PlaylistStringSelect()
    {
        AddSongEntries();
    }

    internal Config.Playlist GetPlaylist()
    {
        Config.Playlist playlist = null!;
        foreach (Config.Playlist plist in Playlists!)
        {
            PlaylistSelector selectedItem = (PlaylistSelector)PlaylistDropDown!.GetSelectedItem()!;
            var selectedItemName = selectedItem.Title;
            if (plist.Name == selectedItemName)
            {
                playlist = plist;
            }
        }
        return playlist;
    }

    internal string GetTitle()
    {
        return Title!;
    }

    internal uint GetPlaylistSongIndex(int index)
    {
        var numItems = PlaylistSongModel!.GetNItems();
        var newIndex = PlaylistDropDown!.Selected;
        for (int i = 0; i < numItems; i++)
        {
            if (Songs![i].Index.Equals(index))
                newIndex = (uint)i;
        }
        return newIndex;
    }

    internal int GetSongIndex(uint index)
    {
        var strObj = (PlaylistSelector)PlaylistSongDropDown!.SelectedItem!;
        var selectedItemName = strObj.Title;
        var newIndex = (int)index;
        foreach (var song in Songs!)
        {
            if (song.Name.Equals(selectedItemName))
            {
                newIndex = song.Index;
            }
        }
        return newIndex;
    }

    internal static int GetNumSongs()
    {
        return (int)PlaylistSongModel!.NItems;
    }

    internal void AddPlaylistEntries(List<Config.Playlist> playlists)
    {
        Playlists = playlists;
        if (PlaylistModel!.GetNItems() is not 0)
        {
            PlaylistModel.RemoveAll();
        }
        ContentsPlaylist = new Contents[Playlists.Count + 1];
        int i = 0;
        foreach (Config.Playlist plist in Playlists)
        {
            var data = AddEntry(plist.Name, "vgms-playlist-symbolic", i++);
            PlaylistModel.Append(data);
        }
        PrevSelectedPlaylistIndex = (int)(PlaylistDropDown!.Selected = SelectedPlaylistIndex = PlaylistDropDown.Selected = PlaylistModel.NItems - 1); // So that "All Songs" main playlist is selected
        Index = 0;
    }
    internal void AddSongEntries()
    {
        if (PlaylistSongModel!.GetNItems() is not 0)
        {
            PlaylistSongModel.RemoveAll();
        }
        Songs = Playlists![(int)PlaylistDropDown!.Selected].Songs;
        ContentsSong = new Contents[Songs.Count + 1];
        for (int i = 0; i < Songs.Count; i++)
        {
            var data = AddEntry(Songs[i].Name, "vgms-song-symbolic", i);
            PlaylistSongModel.Append(data);
        }
        PrevSelectedSongIndex = (int)(SelectedSongIndex = PlaylistSongDropDown!.Selected);
        Index = 0;
    }
}

Also, I've noticed that the debugger now takes longer to begin the building process in GirCore 0.8.0, is this normal? Didn't used to have this delay in the earlier version.

[badcel]

Could you provide a minimal sample?

[badcel]

I can imagine that it takes a little longer to start debugging because there are source generators embedded into GObject and GTK since 0.8.0.

So if there must be code generated before debugging for subclasses, this is an additional step which did not need to happen before.

[PlatinumLucario]

I'm having some difficulty reproducing it into a minimal sample, but from what I can see after some testing with the main project, it seems to get triggered on PlaylistModel.NItems. I'll do some more testing with the main project and see what else I can find with this oddity.

[PlatinumLucario]

Also, furthermore, I've got a lot of messages coming up in the debug, which is likely linked to the issues:

(process:3642009): Gtk-WARNING **: 15:18:17.168: Trying to remove accessible 'GtkPopoverMenuBar', but it cannot be found in the reference list 0x55f17c16dfc0

(process:3642009): Gtk-WARNING **: 15:18:17.169: Trying to remove accessible 'GtkPopoverMenuBar', but it cannot be found in the reference list 0x55f17c16dfc0

(process:3642009): Gtk-WARNING **: 15:18:17.171: Trying to remove accessible 'GtkPopoverMenuBar', but it cannot be found in the reference list 0x55f17c16dfc0

(process:3642009): Gtk-WARNING **: 15:18:17.171: Trying to remove accessible 'GtkPopoverMenuBar', but it cannot be found in the reference list 0x55f17c16dfc0

(process:3642009): GLib-GIO-CRITICAL **: 15:18:17.186: g_list_store_new: assertion 'g_type_is_a (item_type, G_TYPE_OBJECT)' failed

(process:3642009): GLib-GObject-CRITICAL **: 15:18:17.186: g_object_add_toggle_ref: assertion 'G_IS_OBJECT (object)' failed

(process:3642009): GLib-GObject-CRITICAL **: 15:18:17.186: g_object_unref: assertion 'G_IS_OBJECT (object)' failed

(process:3642009): GLib-GIO-CRITICAL **: 15:18:17.186: g_list_store_new: assertion 'g_type_is_a (item_type, G_TYPE_OBJECT)' failed

(process:3642009): GLib-GObject-CRITICAL **: 15:18:17.186: g_object_add_toggle_ref: assertion 'G_IS_OBJECT (object)' failed

(process:3642009): GLib-GObject-CRITICAL **: 15:18:17.186: g_object_unref: assertion 'G_IS_OBJECT (object)' failed

[badcel]

If you slowly trim down your main project the issue will probably vanish at some point. Then you have the root cause for your problem.

It might be related how you architected your system. If the problematic architecture is gone in a minimal sample it does not happen anymore.

Currently it sounds like the issue lies somewhere in your code and not in GirCore for me.