fix(autofix): Read automation settings from detailed project#115239
Merged
Conversation
The coding agent CTAs were checking Seer automation fields from the project prop, which can be a project summary and miss detailed settings. That made missing values look enabled in a few places. Load the detailed project before deciding CTA state, and keep updates going through useUpdateProject with the original project. This follows the same pattern as the preprod settings fix. Co-Authored-By: Codex GPT-5 <noreply@openai.com>
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.47% |
ProjectSeer renders the coding agent CTAs, which now load detailed project data before checking automation settings. Add the detailed project mock to the settings tests, including the custom org setups that clear default mocks. Co-Authored-By: Codex GPT-5 <noreply@openai.com>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9ea84e7. Configure here.
The notice should not decide the automation step from summary project data while the detailed project request is loading. Keep the detailed project guard for onboarding state, but still use the detailed values for the handoff setup click. Co-Authored-By: Codex GPT-5 <noreply@openai.com>
ryan953
reviewed
May 11, 2026
| const isAutomationEnabled = | ||
| project.seerScannerAutomation !== false && | ||
| project.autofixAutomationTuning !== 'off'; | ||
| projectDetails.seerScannerAutomation === true && |
Member
There was a problem hiding this comment.
is this flip intentional? i wonder if undefined is meant to be the same as "enabled"?
ryan953
approved these changes
May 11, 2026
Detailed project data gives scanner automation a backend default of true. Keep the handoff UI aligned with that and only treat an explicit false as disabled. Also keep the Seer notice steps hidden while detailed project settings load, so missing fields don't briefly drive setup state. Co-Authored-By: Codex GPT-5 <noreply@openai.com>
The Seer notice setup handler can run before detailed project data is narrowed, even though the UI is hidden while it loads. Return early until the detailed project exists so typecheck agrees with the runtime guard. Co-Authored-By: Codex GPT-5 <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autofix coding agent CTAs were checking detailed project settings from project summary objects, so missing Seer automation fields could look enabled.
Use the detailed project for those reads and keep updates going through useUpdateProject with the original project. Matches the pattern from #115139.
part of #115024