perf: Replace java.net.URI with custom string parsing in Dsn#5448
Merged
Conversation
runningcode
requested review from
0xadam-brown,
adinauer,
markushi and
romtsn
as code owners
📲 Install BuildsAndroid
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 91bb874 | 314.47 ms | 440.00 ms | 125.53 ms |
| 2195398 | 309.39 ms | 354.53 ms | 45.14 ms |
| 9770665 | 315.64 ms | 378.00 ms | 62.36 ms |
| abfcc92 | 337.38 ms | 427.39 ms | 90.00 ms |
| b77456b | 393.26 ms | 441.10 ms | 47.84 ms |
| 8687935 | 332.52 ms | 362.23 ms | 29.71 ms |
| 14ff5ee | 419.75 ms | 495.73 ms | 75.98 ms |
| 48277cd | 320.38 ms | 379.90 ms | 59.52 ms |
| 694d587 | 305.45 ms | 378.38 ms | 72.94 ms |
| 4c04bb8 | 350.71 ms | 413.63 ms | 62.92 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 91bb874 | 1.58 MiB | 2.13 MiB | 559.07 KiB |
| 2195398 | 0 B | 0 B | 0 B |
| 9770665 | 0 B | 0 B | 0 B |
| abfcc92 | 1.58 MiB | 2.13 MiB | 557.31 KiB |
| b77456b | 1.58 MiB | 2.12 MiB | 548.11 KiB |
| 8687935 | 1.58 MiB | 2.19 MiB | 619.17 KiB |
| 14ff5ee | 1.58 MiB | 2.10 MiB | 535.08 KiB |
| 48277cd | 0 B | 0 B | 0 B |
| 694d587 | 1.58 MiB | 2.19 MiB | 620.06 KiB |
| 4c04bb8 | 0 B | 0 B | 0 B |
Previous results on branch: no/custom-dsn-parser
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 96d1d4a | 354.34 ms | 443.40 ms | 89.06 ms |
| 2f05649 | 287.89 ms | 353.78 ms | 65.89 ms |
| 85d9e31 | 323.66 ms | 391.76 ms | 68.10 ms |
| 51a27f4 | 318.65 ms | 361.66 ms | 43.01 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 96d1d4a | 0 B | 0 B | 0 B |
| 2f05649 | 0 B | 0 B | 0 B |
| 85d9e31 | 0 B | 0 B | 0 B |
| 51a27f4 | 0 B | 0 B | 0 B |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cacc249. Configure here.
0xadam-brown
approved these changes
May 20, 2026
0xadam-brown
left a comment
0xadam-brown
left a comment
Member
There was a problem hiding this comment.
A few optionals; otherwise lgtm
runningcode
changed the title
runningcode
force-pushed
the
no/custom-dsn-parser
branch
from
cacc249 to
4851e6d
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
runningcode
changed the title
0xadam-brown
approved these changes
Jun 4, 2026
0xadam-brown
left a comment
0xadam-brown
left a comment
Member
There was a problem hiding this comment.
Thanks for the updates – lgtm 👍
romtsn
reviewed
Jun 8, 2026
romtsn
approved these changes
Jun 8, 2026
romtsn
left a comment
romtsn
left a comment
Member
There was a problem hiding this comment.
one nit, but LGTM otherwise! great gains
The Dsn constructor used `new URI(dsnString).normalize()` to parse the DSN string, which is known to be slow on Android. Since `retrieveParsedDsn()` is called on the main thread during `Sentry.init()` via `preInitConfigurations()`, this directly impacts app startup time. Replace the URI-based parsing with manual indexOf/substring operations. The only remaining URI construction is from pre-parsed components (`new URI(scheme, null, host, port, path, null, null)`), which is significantly cheaper since the JDK doesn't need to re-parse a string. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Cover edge cases specific to the manual indexOf/substring parser: null input, missing scheme separator, no slash after host, multiple path segments, port with path, multiple double slashes, query string with port, empty secret key, and a realistic Sentry DSN with org id. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Harden the custom DSN parser and convert its tests to Google Truth. - Strip URI fragments (#...) alongside query strings so they no longer leak into the project id and corrupt the constructed Sentry URI. - Detect bracketed IPv6 literal hosts when locating the port separator, restoring behavior that java.net.URI handled. - Narrow the parse error handling from catch (Throwable) to the expected exceptions, which stops swallowing Error and removes the doubled exception message. - Extract the parsing steps into focused private helpers. - Convert DsnTest to Google Truth assertions. - Move the changelog entry to the Unreleased section, since 8.43.0 and 8.43.1 have already been released. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Follow Truth's recommended pattern for exception testing: catch with assertFailsWith, then assert on the caught throwable with assertThat(ex).hasMessageThat(). Also assert the message in the previously bare throw-only cases so they can no longer pass on an unrelated exception. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Parse the port in a dedicated helper that reports the offending value
("Invalid DSN: Invalid port 'abc'.") instead of leaking the raw
NumberFormatException text. Narrow the catch to URISyntaxException now
that the port is the only parseInt, and add a test.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
runningcode
force-pushed
the
no/custom-dsn-parser
branch
from
88dc031 to
7d400c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
java.net.URIparsing in theDsnconstructor with lightweight manualstring parsing, and hardens and tests the parser. This is a critical startup path performance improvement.
Here are perfetto traces of the
retrieveParsedDsn()method as measured on a Pixel 3. I've repeated the measurement several times and I always get an order of magnitude difference.This is on master:
This is on this branch:
What changed
new URI(dsnString).normalize()with manualindexOf/substringparsing, avoiding thejava.net.URIstring parser.retrieveParsedDsn()runs on the main thread duringSentry.init(), so thiskeeps a known-slow API off the init path. The only remaining
URIuse isconstructing the endpoint from already-parsed components
(
new URI(scheme, null, host, port, path, null, null)), which does notre-parse a string.
#…) alongside query strings so they nolonger leak into the project id, and support bracketed IPv6 literal hosts
(e.g.
https://key@[::1]:9000/1) — both behaviors the oldURIparser handled.JAVA-532
Relates to: https://linear.app/getsentry/issue/JAVA-532
Also relates to: https://linear.app/getsentry/issue/JAVA-516/move-dsn-parsing-off-the-main-thread-during-init
🤖 Generated with Claude Code