Dynamic dockerfile#50
Open
kthomas wants to merge 7 commits into
Open
Conversation
added 7 commits
July 7, 2018 11:36
Some preliminary research seems to indicate upnp to be at fault
Member
|
@kthomas thanks for the work! It may take a bit to review it, but perhaps breaking up this PR into smaller changes (as separate PRs) could speed up the process. |
Contributor
|
Looks great @kthomas ! I need to do a bit of work with our provisioning scripts to incorporate this and then we will merge it. |
jwasinger
previously approved these changes
Aug 7, 2018
Contributor
|
Hey @kthomas , sorry for the lapse in response. We've decided to change direction and use Geth as our main client for the testnet. I will leave this open for now in case anyone else has any input. |
Author
|
Thanks for the heads-up Jared.
I have support for geth and parity using that same pattern; would you like
me to update the PR with that support?
Cheers...
…On Sun, Aug 26, 2018 at 3:24 PM Jared Wasinger ***@***.***> wrote:
Hey @kthomas <https://github.com/kthomas> , sorry for the lapse in
response. We've decided to change direction and use Geth as our main client
for the testnet. I will leave this open for now in case anyone else has any
input.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#50 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAJ17c-BA5xRB72wOf2q2s65gWF7NP5Jks5uUvXXgaJpZM4VfcvW>
.
|
Member
|
@chfast @jwasinger can you review this? |
Member
|
@chfast @jwasinger what is the status of this? |
Contributor
|
This could be useful if we end up running an aleth node on the testnet. It needs to be updated to reflect changes in evmc. |
Author
|
@jwasinger updates & rebase forthcoming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR parameterizes the invocation of
cpp-eth.shand adds support for building dynamically-versioned docker containers such that the resulting container includes the targeted versions of the Hera VM and cpp-ethereum, among other things.In the future, other node implementations and VMs can be supported using the same method now in
setup.sh.