fix(windows): quote editor launch paths

Ensure Windows editor launches quote workspace paths containing spaces.

PR: #622

Author: kentcdodds

packages/workshop-utils/src/launch-editor.server.test.ts

@@ -1,5 +1,8 @@
 import { expect, test } from 'vitest'
-import { parseEditorCommand } from './launch-editor.server.ts'
+import {
+	getWindowsEditorCommandArgs,
+	parseEditorCommand,
+} from './launch-editor.server.ts'
 
 test('preserves unquoted Windows editor paths', () => {
 	const editor = String.raw`C:\Users\James\AppData\Local\Programs\cursor\Cursor.exe`
@@ -22,3 +25,29 @@ test('keeps shell parsing for non-Windows editor commands', () => {
 		'--reuse-window',
 	])
 })
+
+test('quotes Windows editor command arguments with spaces (aha)', () => {
+	const editor = 'code'
+	const workshopPath = String.raw`C:\Users\Campbell L Mitchell\Campbell - Ensign College\epicshop-tutorial`
+
+	expect(getWindowsEditorCommandArgs(editor, [workshopPath])).toEqual([
+		'/D',
+		'/S',
+		'/C',
+		String.raw`"code" "C:\Users\Campbell L Mitchell\Campbell - Ensign College\epicshop-tutorial"`,
+	])
+})
+
+test('quotes Windows editor paths with spaces and preserves editor args', () => {
+	const editor = String.raw`C:\Program Files\Microsoft VS Code\bin\code.cmd`
+	const workshopPath = String.raw`C:\Users\Campbell L Mitchell\epicshop-tutorial`
+
+	expect(
+		getWindowsEditorCommandArgs(editor, ['--reuse-window', workshopPath]),
+	).toEqual([
+		'/D',
+		'/S',
+		'/C',
+		String.raw`"C:\Program Files\Microsoft VS Code\bin\code.cmd" "--reuse-window" "C:\Users\Campbell L Mitchell\epicshop-tutorial"`,
+	])
+})

packages/workshop-utils/src/launch-editor.server.ts

@@ -259,6 +259,22 @@ export function parseEditorCommand(
 	return shellQuote.parse(trimmedEditor).map((arg) => String(arg))
 }
 
+function quoteWindowsCmdArg(arg: string): string {
+	return `"${arg.replaceAll('"', '\\"')}"`
+}
+
+export function getWindowsEditorCommandArgs(
+	editor: string,
+	args: Array<string>,
+): Array<string> {
+	return [
+		'/D',
+		'/S',
+		'/C',
+		[quoteWindowsCmdArg(editor), ...args.map(quoteWindowsCmdArg)].join(' '),
+	]
+}
+
 function getWindowsProcessPaths(): string[] {
 	const systemRoot = process.env.SystemRoot ?? process.env.WINDIR
 	const wmicPath = systemRoot
@@ -604,7 +620,7 @@ export async function launchEditor(
 			// launch .exe files.
 			_childProcess = child_process.spawn(
 				'cmd.exe',
-				['/C', editor].concat(args).filter(Boolean),
+				getWindowsEditorCommandArgs(editor, args),
 				{ stdio: ['inherit', 'inherit', 'pipe'] },
 			)
 		} else {