Merge pull request #617 from epicweb-dev/cursor/node-26-workshops-61ab

Looped with AI review and addressed all valid feedback before merge.

Author: kody-bot

other/update-workshops/index.js

@@ -2,6 +2,7 @@ import fs from 'fs/promises'
 import path from 'path'
 import { fileURLToPath } from 'url'
 import { execa } from 'execa'
+import semver from 'semver'
 
 const __filename = fileURLToPath(import.meta.url)
 const __dirname = path.dirname(__filename)
@@ -14,6 +15,7 @@ const GITHUB_TOKEN =
 	process.env.WORKSHOP_UPDATE_TOKEN ?? process.env.GITHUB_TOKEN
 const USING_WORKSHOP_UPDATE_TOKEN = Boolean(process.env.WORKSHOP_UPDATE_TOKEN)
 const CONCURRENCY = 5
+const TARGET_NODE_VERSION = '26.0.0'
 const ADDITIONAL_WORKSHOP_REPOS = ['ai-powered-apps', 'workshop-template']
 
 if (!GITHUB_TOKEN) {
@@ -138,6 +140,42 @@ async function getLatestVersion() {
 	}
 }
 
+async function getPublishedWorkshopAppNodeRange(version) {
+	try {
+		const { stdout } = await execa('npm', [
+			'show',
+			`@epic-web/workshop-app@${version}`,
+			'engines.node',
+		])
+		return stdout.trim()
+	} catch (error) {
+		console.error(
+			`❌ Failed to get @epic-web/workshop-app@${version} node engine:`,
+			error.message,
+		)
+		throw error
+	}
+}
+
+async function verifyWorkshopAppSupportsTargetNode(version) {
+	const nodeRange = await getPublishedWorkshopAppNodeRange(version)
+	if (!nodeRange) {
+		throw new Error(
+			`@epic-web/workshop-app@${version} does not publish an engines.node range`,
+		)
+	}
+
+	if (!semver.satisfies(TARGET_NODE_VERSION, nodeRange)) {
+		throw new Error(
+			`@epic-web/workshop-app@${version} supports Node ${nodeRange}, not Node ${TARGET_NODE_VERSION}. Aborting before updating workshops.`,
+		)
+	}
+
+	console.log(
+		`✅ @epic-web/workshop-app@${version} supports Node ${TARGET_NODE_VERSION} (${nodeRange})`,
+	)
+}
+
 /**
  * Verify that the epicshop package is available on npm registry
  * This helps avoid 404 errors in workshop CI when npm registry replication is delayed
@@ -562,6 +600,7 @@ async function main() {
 		console.log('📦 Getting latest version from npm...')
 		const version = await getLatestVersion()
 		console.log(`🔍 Updating to version ${version}`)
+		await verifyWorkshopAppSupportsTargetNode(version)
 
 		// Verify that both epicshop and workshop-app are available on npm
 		// before pushing updates to workshops to avoid 404 errors in workshop CI

other/update-workshops/package-lock.json

@@ -7,6 +7,7 @@
   },
   "dependencies": {
     "execa": "^9.6.1",
-    "globby": "^16.2.0"
+    "globby": "^16.2.0",
+    "semver": "^7.8.5"
   }
 }

other/update-workshops/package.json

@@ -15,30 +15,23 @@ const __dirname = path.dirname(fileURLToPath(import.meta.url))
 const repoRoot = path.resolve(__dirname, '..', '..', '..', '..')
 
 const testIf = process.platform === 'win32' ? test.skip : test
-const nodeMajorVersion = Number(process.versions.node.split('.')[0])
-const typeScriptRunnerArgs =
-	nodeMajorVersion >= 26 ? [] : ['--experimental-transform-types']
 
 testIf(
 	'start releases the child server port on shutdown',
 	async () => {
 		await using fixture = await createRunnerFixture()
 		let child: ChildProcess | null = null
 		try {
-			child = spawn(
-				process.execPath,
-				[...typeScriptRunnerArgs, fixture.runnerPath],
-				{
-					cwd: repoRoot,
-					env: {
-						...process.env,
-						EPICSHOP_APP_LOCATION: fixture.appDir,
-						EPICSHOP_CONTEXT_CWD: fixture.appDir,
-						NODE_ENV: 'development',
-					},
-					stdio: ['ignore', 'pipe', 'pipe'],
+			child = spawn(process.execPath, [fixture.runnerPath], {
+				cwd: repoRoot,
+				env: {
+					...process.env,
+					EPICSHOP_APP_LOCATION: fixture.appDir,
+					EPICSHOP_CONTEXT_CWD: fixture.appDir,
+					NODE_ENV: 'development',
 				},
-			)
+				stdio: ['ignore', 'pipe', 'pipe'],
+			})
 
 			if (!child) {
 				throw new Error('Failed to start runner process.')