Skip to content

[Trip layout] Weird location names displayed in the timeline #10037

@adridevlyon

Description

@adridevlyon

Description

The location names displayed in the timeline when using the trip layout are weird and not homogeneous for different locations, and sometimes even incomplete for places where it likely shouldn't.

Some screenshots

  • missing country
Image
  • not homogeneous location granularity
Image

Some hints to fix

While looking at the geocoding code and the stadiamaps doc (route /geocoding/v1/reverse), here are some ideas that could be tried to fix this

  • is the 2 decimal rounding for the coordinates the correct level of precision?
  • the stadiamaps api returns a list of features with a granularity (field geometry.type)
    • instead of simply taking the first result, the features to use to get the location attributes could benefit from checking this and use the appropriate levels
    • using the same geometry.type (as much as possible, or at least the same order) to select the location name could improve the homogeneity over the whole timeline

Version

No response

What product are you using?

Ente Photos

What platform are you using?

Web - Firefox

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions