Skip to content

Commit 6efdd08

Browse files
committed
fix: enforce CI failure on coverage report errors in workflow
1 parent 5992167 commit 6efdd08

3 files changed

Lines changed: 15 additions & 5 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,7 @@ jobs:
4040
use_oidc: true
4141
files: packages/core/coverage/lcov.info
4242
disable_search: true
43-
fail_ci_if_error: false
44-
45-
- name: Build app
46-
run: npm run build:app
43+
fail_ci_if_error: true
4744

4845
- name: Install Playwright Chromium
4946
run: npm run playwright:install-chromium-ci

.github/workflows/release.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,16 @@ jobs:
8888
publish_branch: gh-pages
8989
keep_files: true
9090

91+
- name: Docs deployment summary
92+
run: |
93+
echo "## Docs Deployment Summary" >> $GITHUB_STEP_SUMMARY
94+
echo "" >> $GITHUB_STEP_SUMMARY
95+
echo "- **Release**: ${{ needs.release.outputs.version }}" >> $GITHUB_STEP_SUMMARY
96+
echo "- **Branch**: gh-pages" >> $GITHUB_STEP_SUMMARY
97+
echo "- **Path**: /docs/" >> $GITHUB_STEP_SUMMARY
98+
echo "- **URL**: https://docks.eclipse.dev/docs/" >> $GITHUB_STEP_SUMMARY
99+
echo "- **Commit**: ${{ github.sha }}" >> $GITHUB_STEP_SUMMARY
100+
91101
publish-npm:
92102
needs: release
93103
if: needs.release.outputs.version != ''

scripts/setup-npm-trusted-publishing.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,17 @@ for arg in "$@"; do
2222
esac
2323
done
2424

25-
WORKFLOW_FILE="${WORKFLOW_FILE:-ci.yml}"
25+
WORKFLOW_FILE="${WORKFLOW_FILE:-release.yml}"
2626
REPO="${NPM_TRUST_REPO:-eclipse-docks/core}"
2727

2828
echo "Configuring npm trusted publishing (GitHub OIDC)"
2929
echo " Workflow: $WORKFLOW_FILE"
3030
echo " Repository: $REPO"
3131
[ -n "$ONLY_PACKAGE" ] && echo " Package: $ONLY_PACKAGE (only)"
3232
echo ""
33+
echo "Note: trusted publishers must match the workflow that runs npm publish"
34+
echo " (currently .github/workflows/release.yml → job publish-npm)."
35+
echo ""
3336

3437
if [ "$DRY_RUN" = true ]; then
3538
echo "DRY RUN — no changes will be made."

0 commit comments

Comments
 (0)