Prompted for Username and Password on every Git Clone while using Docker

[Sorsnce]

While running this in Docker

docker run -ti --rm -e GITHUB_WATCHER_TOKEN=your_access_token duolabs/secret-bridge poll

I get prompted every time GitHub does a "pull"

INFO:root:Cloning repository ORG/REPO into /tmp/tmpglfe5wn9repo
Username for 'https://github.com': 

It appears that processor.py is not passing the GitHub token from the config.toml
See on line 35 in processor.py

subprocess.run(["git", "clone", repo_url, repo_dir.name], stdout=subprocess.PIPE, stderr=subprocess.PIPE)

Looks like you just need to pass the variable to subprocess.run to fix this issue.

[jordan-wright]

Hey there! Thanks for sending this in. @nickmooney and I will take a look and see if we can get a fix in place.

[nickmooney]

Whoops, ignore the above.

Anyway -- thanks for filing the issue, @Sorsnce! The GitHub token is used to configure the GitHub client that's used to hit the APIs to get repos/users/commits. The intention was not to use it to access private repositories, but it seems like it could serve this purpose.

I'll think about this and see if we can include the functionality in the future.

[realytcracker]

i have submitted a PR that addresses this issue, but it may not be idiomatic.