Mark [Unordered] as [Obsolete] (#9815)

* Initial plan

* Mark UnorderedAttribute as obsolete and remove internal usages

Co-authored-by: ReubenBond <203839+ReubenBond@users.noreply.github.com>

* Apply suggestion from @ReubenBond

* Finish the job

* Update src/Orleans.Core.Abstractions/Concurrency/GrainAttributeConcurrency.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: ReubenBond <203839+ReubenBond@users.noreply.github.com>
Co-authored-by: Reuben Bond <reuben.bond@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: 3 people

src/Orleans.Core.Abstractions/Concurrency/GrainAttributeConcurrency.cs

@@ -43,7 +43,11 @@ public void Populate(IServiceProvider services, Type grainClass, GrainType grain
     /// The Unordered attribute is used to mark grain interface in which the delivery order of
     /// messages is not significant.
     /// </summary>
+    /// <remarks>
+    /// This attribute has no effect and it may be removed in a future release.
+    /// </remarks>
     [AttributeUsage(AttributeTargets.Interface)]
+    [Obsolete("Message ordering is not guaranteed regardless of whether this attribute is used. This attribute has no effect.")]
     public sealed class UnorderedAttribute : Attribute
     {
     }

src/Orleans.Core/SystemTargetInterfaces/IMembershipTable.cs

@@ -104,7 +104,6 @@ public interface IMembershipTable
     /// <summary>
     /// Membership table interface for system target based implementation.
     /// </summary>
-    [Unordered]
     public interface IMembershipTableSystemTarget : IMembershipTable, ISystemTarget
     {
     }

src/Orleans.Reminders/SystemTargetInterfaces/IReminderTable.cs

@@ -87,7 +87,6 @@ Task StartAsync(CancellationToken cancellationToken = default)
     /// <summary>
     /// Reminder table interface for grain based implementation.
     /// </summary>
-    [Unordered]
     internal interface IReminderTableGrain : IGrainWithIntegerKey
     {
         Task<ReminderTableData> ReadRows(GrainId grainId);

test/Grains/TestGrainInterfaces/CodegenTestInterfaces.cs

@@ -42,13 +42,6 @@ public interface ISomeGrain : IGrainWithIntegerKey
         Task Do(Outsider o);
     }
 
-    [Unordered]
-    public interface ISomeGrainWithInvocationOptions : IGrainWithIntegerKey
-    {
-        [AlwaysInterleave]
-        Task AlwaysInterleave();
-    }
-
     public interface ISerializationGenerationGrain : IGrainWithIntegerKey
     {
         Task<object> RoundTripObject(object input);

test/Grains/TestGrainInterfaces/IReentrancyGrain.cs

@@ -50,16 +50,6 @@ public interface IMayInterleaveInstancedPredicateGrain : IGrainWithIntegerKey
         Task SetSelf(IMayInterleaveInstancedPredicateGrain self);
     }
 
-    [Unordered]
-    public interface IUnorderedNonReentrantGrain : IGrainWithIntegerKey
-    {
-        Task<string> One();
-
-        Task<string> Two();
-
-        Task SetSelf(IUnorderedNonReentrantGrain self);
-    }
-
     public interface IReentrantSelfManagedGrain : IGrainWithIntegerKey
     {
         Task<int> GetCounter();

test/Grains/TestGrains/ReentrantGrain.cs

@@ -239,26 +239,6 @@ public Task SetSelf(IMayInterleaveInstancedPredicateGrain self)
         }
     }
 
-    public class UnorderedNonRentrantGrain : Grain, IUnorderedNonReentrantGrain
-    {
-        private IUnorderedNonReentrantGrain Self { get; set; }
-
-        public Task<string> One()
-        {
-            return Task.FromResult("one");
-        }
-
-        public async Task<string> Two()
-        {
-            return await Self.One() + " two";
-        }
-
-        public Task SetSelf(IUnorderedNonReentrantGrain self)
-        {
-            Self = self;
-            return Task.CompletedTask;
-        }
-    }
     [Reentrant]
     public class ReentrantSelfManagedGrain1 : Grain, IReentrantSelfManagedGrain
     {

test/TesterInternal/MessageScheduling/DisabledCallChainReentrancyTestRunner.cs

@@ -90,31 +90,5 @@ public void NonReentrantGrain_WithMayInterleaveInstancedPredicate_WhenPredicateR
             }
             this.logger.LogInformation("Reentrancy NonReentrantGrain_WithMayInterleaveInstancedPredicate_WhenPredicateReturnsFalse Test finished OK.");
         }
-
-        public void UnorderedNonReentrantGrain(bool performDeadlockDetection)
-        {
-            IUnorderedNonReentrantGrain unonreentrant = this.grainFactory.GetGrain<IUnorderedNonReentrantGrain>(OrleansTestingBase.GetRandomGrainId());
-            unonreentrant.SetSelf(unonreentrant).Wait();
-            bool timeout = false;
-            bool deadlock = false;
-            try
-            {
-                timeout = !unonreentrant.Two().Wait(2000);
-            }
-            catch (Exception exc)
-            {
-                Assert.Fail($"Unexpected exception {exc.Message}: {exc.StackTrace}");
-            }
-            if (performDeadlockDetection)
-            {
-                Assert.True(deadlock, "Non-reentrant grain should deadlock");
-            }
-            else
-            {
-                Assert.True(timeout, "Non-reentrant grain should timeout");
-            }
-
-            this.logger.LogInformation("Reentrancy UnorderedNonReentrantGrain Test finished OK.");
-        }
     }
-}
+}

test/TesterInternal/MessageScheduling/DisabledCallChainReentrancyTests.cs

@@ -41,11 +41,5 @@ public void NonReentrantGrain_WithMayInterleaveInstancedPredicate_WhenPredicateR
         {
             this.runner.NonReentrantGrain_WithMayInterleaveInstancedPredicate_WhenPredicateReturnsFalse(false);
         }
-
-        [Fact, TestCategory("Functional"), TestCategory("Tasks"), TestCategory("Reentrancy")]
-        public void UnorderedNonReentrantGrain()
-        {
-            this.runner.UnorderedNonReentrantGrain(false);
-        }
     }
-}
+}