build: handle buildkit defaulting to oci mediatypes#3888
Open
crazy-max wants to merge 1 commit into
Open
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
fix-oci-mediatypes
branch
from
f794eff to
456bcb7
Compare
tonistiigi
reviewed
Jun 9, 2026
| skipNoCompatBuildKit(t, sb, ">= 0.11.0-0", "annotations") | ||
| dir := createTestProject(t) | ||
| out, err := buildCmd(sb, withArgs("--annotation", "index:foo=bar", "--provenance", "false", "--output", "type=docker", dir)) | ||
| out, err := buildCmd(sb, withArgs("--annotation", "index:foo=bar", "--provenance", "false", "--output", "type=docker,oci-mediatypes=false", dir)) |
Member
There was a problem hiding this comment.
oci-mediatypes=false
Is this needed after we merged moby/buildkit#6844 ? I think it should not be.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up moby/buildkit#6824
Updates Buildx integration behavior for BuildKit versions that default image exports to OCI media types since moby/buildkit#6824
BuildKit compatibility version 30 changes image exports so the default manifest and index media types are OCI media types instead of Docker schema media types. The imagetools integration tests now derive the expected default media type from the BuildKit version, so older BuildKit versions keep expecting Docker media types while newer versions expect OCI media types.
The
TestBuildIndexAnnotationsLoadDockercase now setsoci-mediatypes=falseexplicitly. This keeps the test focused on the Docker media type conflict without treatingtype=dockeritself as a request for Docker schema media types. The defaulttype=dockerbehavior is handled by the BuildKit-side fix in moby/buildkit#6844.