Skip to content

ci: upload test results to codecov #3887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crazy-max merged 1 commit into from
Jun 9, 2026
+25 −4
Merged

ci: upload test results to codecov #3887

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 25 additions & 4 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,14 +148,24 @@ jobs:
TEST_REPORT_SUFFIX: "-${{ env.TESTREPORTS_NAME }}"
TESTPKGS: "${{ matrix.pkg }}"
-
name: Send to Codecov
name: Upload coverage to Codecov
if: always()
uses: codecov/codecov-action@e79a6962e0d4c0c17b229090214935d2e33f8354 # v6.0.1
with:
directory: ./bin/testreports
flags: integration
token: ${{ secrets.CODECOV_TOKEN }}
disable_file_fixes: true
disable_file_fixes: true # needed for Go language https://docs.codecov.com/docs/fixing-reports
-
name: Upload test results to Codecov
if: always()
uses: codecov/codecov-action@e79a6962e0d4c0c17b229090214935d2e33f8354 # v6.0.1
with:
report_type: test_results
directory: ./bin/testreports
flags: integration
token: ${{ secrets.CODECOV_TOKEN }}

@thaJeztah thaJeztah Jun 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still need a token? I recall they had token-less options for public repositories, but not sure if that applies here; https://docs.codecov.com/docs/codecov-tokens#when-do-i-need-a-token

@thaJeztah thaJeztah Jun 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And (same page); https://docs.codecov.com/docs/codecov-tokens#uploading-without-a-token

Image

@crazy-max crazy-max Jun 5, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we should keep it. Tokenless uploads only apply when Docker has disabled public token auth in Codecov, or when Codecov treats the upload as an unprotected/fork branch. This workflow also runs on pushes to master/v*, where Codecov requires a token by default. For fork PRs the secret resolves empty, and the v6 action still handles the tokenless fork path, so keeping the input doesn't block tokenless PR uploads.

disable_file_fixes: true # needed for Go language https://docs.codecov.com/docs/fixing-reports
-
name: Generate annotations
if: always()
Expand Down Expand Up @@ -225,15 +235,26 @@ jobs:
"-covermode" "atomic" ${{ env.TESTFLAGS }}
shell: bash
-
name: Send to Codecov
name: Upload coverage to Codecov
if: always()
uses: codecov/codecov-action@e79a6962e0d4c0c17b229090214935d2e33f8354 # v6.0.1
with:
directory: ${{ env.TESTREPORTS_DIR }}
env_vars: RUNNER_OS
flags: unit
token: ${{ secrets.CODECOV_TOKEN }}
disable_file_fixes: true # needed for Go language https://docs.codecov.com/docs/fixing-reports
-
name: Upload test results to Codecov
if: always()
uses: codecov/codecov-action@e79a6962e0d4c0c17b229090214935d2e33f8354 # v6.0.1
with:
report_type: test_results
directory: ${{ env.TESTREPORTS_DIR }}
env_vars: RUNNER_OS
flags: unit
token: ${{ secrets.CODECOV_TOKEN }}
disable_file_fixes: true
disable_file_fixes: true # needed for Go language https://docs.codecov.com/docs/fixing-reports
-
name: Generate annotations
if: always()
Expand Down
Loading