ci: upload test results to codecov#3887
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
|
ci issue unrelated, see #3888 |
| report_type: test_results | ||
| directory: ./bin/testreports | ||
| flags: integration | ||
| token: ${{ secrets.CODECOV_TOKEN }} |
There was a problem hiding this comment.
Does this still need a token? I recall they had token-less options for public repositories, but not sure if that applies here; https://docs.codecov.com/docs/codecov-tokens#when-do-i-need-a-token
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, I think we should keep it. Tokenless uploads only apply when Docker has disabled public token auth in Codecov, or when Codecov treats the upload as an unprotected/fork branch. This workflow also runs on pushes to master/v*, where Codecov requires a token by default. For fork PRs the secret resolves empty, and the v6 action still handles the tokenless fork path, so keeping the input doesn't block tokenless PR uploads.

This updates the build workflow so Codecov receives test results in addition to coverage reports for both integration and unit test jobs.
Uploading test results alongside coverage gives Codecov the data it needs to show test reporting without changing how coverage is collected or annotated in the existing CI flow.