Skip to content

inputtests bug list for fixing #29

Description

@djgroen
  • When running flee_verify_input it is not directly clear from the terminal feedback where the main log file resides.
  • logs.txt currently resides in the fab_guard directory, which is very counter-intuitive. It would be better placed in config_files/<name>.
  • The name logs.txt is rather vague in general.
  • logs.txt appends to itself without warning on each verification run. It is not clear which error corresponds to which command. Perhaps an overwrite with warning would be better, if the earlier comment is also addressed?
  • logs.txt is not created when flee_verify_input is run from inside the fab_guard directory (but the command does work otherwise).
  • not every error is in logs.txt. (see Appendix A)
  • Errors give a readable list of affected rows, but it would be clearer if they were to indicate line numbers.

Appendix A: Error #0 does not end up in logs.txt

csstddg@LIN-LAPTOP-DG:~/FabSim3/plugins/FabFlee$ fabsim localhost flee_verify_input:mali2012
[loading plugin] FabMD ...
[loading plugin] FabFlee ...
[loading plugin] FabParticleDA ...
[loading plugin] FabDummy ...
[loading plugin] FabUQCampaign ...
[loading plugin] fabmogp ...
[loading plugin] FabCovid19 ...
[loading plugin] FabNEPTUNE ...
[Executing task] flee_verify_input
Validating input files for mali2012
    schema_context column                      check  check_number                                       failure_case index
0  DataFrameSchema   None            coords_are_real             0  ValueError("Invalid location coordinates in fi...  None
1  DataFrameSchema   None  coords_not_on_null_island             1  TypeError("Cannot perform 'ror_' with a dtyped...  None
csstddg@LIN-LAPTOP-DG:~/FabSim3/plugins/FabFlee$ cat fab_guard/logs.txt 
Error #1: location_coord_err returned Invalid location coordinates in file locations.csv: Coordinates point to Null Island or are not in range (-180.0,180,0). 
Invalid rows: Int64Index([ 0,  1,  2,  3,  4,  5,  6,  7,  8,  9, 10, 11, 12, 13, 14, 15, 16,
            17, 18, 19, 20, 21, 22],
           dtype='int64')

========================

Metadata

Metadata

Labels

bugSomething isn't workingenhancementNew feature or request

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions