minicoredumper fails to compile with musl in: corestripper.c: fatal error: printf.h: No such file or directory

[stefson]

hello, I just learned about your project as another user suggested me to use it for debugging a crash in gcc on a system that uses musl as the libc. But the compile is broken with this error:

x86_64-gentoo-linux-musl-ar cru libmcdelf.a libmcdelf_a-elf_dumplist.o 
x86_64-gentoo-linux-musl-ranlib libmcdelf.a
libtool: link: ( cd ".libs" && rm -f "libmcdident.la" && ln -s "../libmcdident.la" "libmcdident.la" )
make[3]: Leaving directory '/var/tmp/portage/sys-process/minicoredumper-2.0.2/work/minicoredumper-2.0.2/src/common'
Making all in coreinject
make[3]: Entering directory '/var/tmp/portage/sys-process/minicoredumper-2.0.2/work/minicoredumper-2.0.2/src/coreinject'
x86_64-gentoo-linux-musl-gcc -DHAVE_CONFIG_H -I. -I../..  -Wall  -include ../../config.h -I../../src/common    -O2 -pipe -c -o coreinject-main.o `test -f 'main.c' || echo './'`main.c
/bin/sh ../../libtool  --tag=CC   --mode=link x86_64-gentoo-linux-musl-gcc  -O2 -pipe  -Wl,-O1 -Wl,--as-needed -o coreinject coreinject-main.o ../common/libmcdelf.a -lelf  
libtool: link: x86_64-gentoo-linux-musl-gcc -O2 -pipe -Wl,-O1 -Wl,--as-needed -o coreinject coreinject-main.o  ../common/libmcdelf.a -lelf
make[3]: Leaving directory '/var/tmp/portage/sys-process/minicoredumper-2.0.2/work/minicoredumper-2.0.2/src/coreinject'
Making all in minicoredumper
make[3]: Entering directory '/var/tmp/portage/sys-process/minicoredumper-2.0.2/work/minicoredumper-2.0.2/src/minicoredumper'
x86_64-gentoo-linux-musl-gcc -DHAVE_CONFIG_H -I. -I../..  -Wall  -include ../../config.h -I../../lib -I../../src/api -I../../src/common -I../../src/libminicoredumper -DMCD_CONF_PATH=\"/etc/minicoredumper\"  -I/usr/include/json-c    -O2 -pipe -c -o minicoredumper-corestripper.o `test -f 'corestripper.c' || echo './'`corestripper.c
x86_64-gentoo-linux-musl-gcc -DHAVE_CONFIG_H -I. -I../..  -Wall  -include ../../config.h -I../../lib -I../../src/api -I../../src/common -I../../src/libminicoredumper -DMCD_CONF_PATH=\"/etc/minicoredumper\"  -I/usr/include/json-c    -O2 -pipe -c -o minicoredumper-prog_config.o `test -f 'prog_config.c' || echo './'`prog_config.c
corestripper.c:17:10: fatal error: printf.h: No such file or directory
   17 | #include <printf.h>
      |          ^~~~~~~~~~
compilation terminated.
make[3]: *** [Makefile:501: minicoredumper-corestripper.o] Error 1

the full and compressed build log is attached: build.log.gz

The toolchain is gcc-12.2.1-20221224 (snapshot), and binutils-2.39 with musl-1.2.3

[jogness]

The minicoredumper project uses asprintf(), which is a GNU extension.

It looks like musl supports asprintf():

http://git.musl-libc.org/cgit/musl/plain/src/stdio/vasprintf.c

Is it just a problem of missing includes? If you comment out the 2 printf.h includes in src/libminicoredumper/mcd.c and src/minicoredumper/corestripper.c does it compile for you?

[stefson]

hi, thank you so much for your fast answer.

Is this your intention?

diff --git a/src/libminicoredumper/mcd.c b/src/libminicoredumper/mcd.c
index 79f7b3c..8f0d8ca 100644
--- a/src/libminicoredumper/mcd.c
+++ b/src/libminicoredumper/mcd.c
@@ -9,7 +9,6 @@
 #include <string.h>
 #include <stdarg.h>
 #include <unistd.h>
-#include <printf.h>
 #include <pthread.h>
 #include <errno.h>
 #include <poll.h>
diff --git a/src/minicoredumper/corestripper.c b/src/minicoredumper/corestripper.c
index eca70d9..97c40ec 100644
--- a/src/minicoredumper/corestripper.c
+++ b/src/minicoredumper/corestripper.c
@@ -14,7 +14,6 @@
 #include <dirent.h>
 #include <syslog.h>
 #include <fcntl.h>
-#include <printf.h>
 #include <stddef.h>
 #include <limits.h>
 #include <inttypes.h>

if it was your intention, it sadly doesn't work:

make[3]: Entering directory '/var/tmp/portage/sys-process/minicoredumper-2.0.2/work/minicoredumper-2.0.2/src/coreinject'
x86_64-gentoo-linux-musl-gcc -DHAVE_CONFIG_H -I. -I../..  -Wall  -include ../../config.h -I../../src/common    -O2 -pipe -c -o coreinject-main.o `test -f 'main.c' || echo './'`main.c
/bin/sh ../../libtool  --tag=CC   --mode=link x86_64-gentoo-linux-musl-gcc  -O2 -pipe  -Wl,-O1 -Wl,--as-needed -o coreinject coreinject-main.o ../common/libmcdelf.a -lelf  
libtool: link: x86_64-gentoo-linux-musl-gcc -O2 -pipe -Wl,-O1 -Wl,--as-needed -o coreinject coreinject-main.o  ../common/libmcdelf.a -lelf
make[3]: Leaving directory '/var/tmp/portage/sys-process/minicoredumper-2.0.2/work/minicoredumper-2.0.2/src/coreinject'
Making all in minicoredumper
make[3]: Entering directory '/var/tmp/portage/sys-process/minicoredumper-2.0.2/work/minicoredumper-2.0.2/src/minicoredumper'
x86_64-gentoo-linux-musl-gcc -DHAVE_CONFIG_H -I. -I../..  -Wall  -include ../../config.h -I../../lib -I../../src/api -I../../src/common -I../../src/libminicoredumper -DMCD_CONF_PATH=\"/etc/minicoredumper\"  -I/usr/include/json-c    -O2 -pipe -c -o minicoredumper-corestripper.o `test -f 'corestripper.c' || echo './'`corestripper.c
x86_64-gentoo-linux-musl-gcc -DHAVE_CONFIG_H -I. -I../..  -Wall  -include ../../config.h -I../../lib -I../../src/api -I../../src/common -I../../src/libminicoredumper -DMCD_CONF_PATH=\"/etc/minicoredumper\"  -I/usr/include/json-c    -O2 -pipe -c -o minicoredumper-prog_config.o `test -f 'prog_config.c' || echo './'`prog_config.c
corestripper.c:22:10: fatal error: thread_db.h: No such file or directory
   22 | #include <thread_db.h>
      |          ^~~~~~~~~~~~~
compilation terminated.
make[3]: *** [Makefile:501: minicoredumper-corestripper.o] Error 1

[jogness]

It seems musl does not have support for libthread_db, which minicoredumper uses to gather pthread information.

You could remove the pthread list dumping. Maybe you do not need it.

1. remove the thread_db.h include
2. remove all the code from dump_pthread_list() down to and including get_pthread_list()
3. remove the call to get_pthread_list()

I will attach a patch that does this.

You will need to test to see if the generated core files are good enough for your needs. I assume the information about threads will be missing.

[jogness]

Hack the minicoredumper so that it does not use libthread_db.

hack_remove_thread_db.patch.txt

[stefson]

I hate to say it, but the patch on top of v2.0.2 doesn't work:

make[3]: Entering directory '/var/tmp/portage/sys-process/minicoredumper-2.0.2/work/minicoredumper-2.0.2/src/coreinject'
x86_64-gentoo-linux-musl-gcc -DHAVE_CONFIG_H -I. -I../..  -Wall  -include ../../config.h -I../../src/common    -O2 -pipe -c -o coreinject-main.o `test -f 'main.c' || echo './'`main.c
/bin/sh ../../libtool  --tag=CC   --mode=link x86_64-gentoo-linux-musl-gcc  -O2 -pipe  -Wl,-O1 -Wl,--as-needed -o coreinject coreinject-main.o ../common/libmcdelf.a -lelf  
libtool: link: x86_64-gentoo-linux-musl-gcc -O2 -pipe -Wl,-O1 -Wl,--as-needed -o coreinject coreinject-main.o  ../common/libmcdelf.a -lelf
make[3]: Leaving directory '/var/tmp/portage/sys-process/minicoredumper-2.0.2/work/minicoredumper-2.0.2/src/coreinject'
Making all in minicoredumper
make[3]: Entering directory '/var/tmp/portage/sys-process/minicoredumper-2.0.2/work/minicoredumper-2.0.2/src/minicoredumper'
x86_64-gentoo-linux-musl-gcc -DHAVE_CONFIG_H -I. -I../..  -Wall  -include ../../config.h -I../../lib -I../../src/api -I../../src/common -I../../src/libminicoredumper -DMCD_CONF_PATH=\"/etc/minicoredumper\"  -I/usr/include/json-c    -O2 -pipe -c -o minicoredumper-corestripper.o `test -f 'corestripper.c' || echo './'`corestripper.c
x86_64-gentoo-linux-musl-gcc -DHAVE_CONFIG_H -I. -I../..  -Wall  -include ../../config.h -I../../lib -I../../src/api -I../../src/common -I../../src/libminicoredumper -DMCD_CONF_PATH=\"/etc/minicoredumper\"  -I/usr/include/json-c    -O2 -pipe -c -o minicoredumper-prog_config.o `test -f 'prog_config.c' || echo './'`prog_config.c
corestripper.c:17:10: fatal error: printf.h: No such file or directory
   17 | #include <printf.h>
      |          ^~~~~~~~~~
compilation terminated.

[jogness]

Previously you removed the printf.h includes. I assumed they were still removed.

[stefson]

Ah thanks for hint, I merged the two patches into one single patch like this: proposed-fix-merged.patch.gz

it seems to be even more angrier now :(

Making all in minicoredumper
make[3]: Entering directory '/var/tmp/portage/sys-process/minicoredumper-2.0.2/work/minicoredumper-2.0.2/src/minicoredumper'
x86_64-gentoo-linux-musl-gcc -DHAVE_CONFIG_H -I. -I../..  -Wall  -include ../../config.h -I../../lib -I../../src/api -I../../src/common -I../../src/libminicoredumper -DMCD_CONF_PATH=\"/etc/minicoredumper\"  -I/usr/include/json-c    -O2 -pipe -c -o minicoredumper-corestripper.o `test -f 'corestripper.c' || echo './'`corestripper.c
x86_64-gentoo-linux-musl-gcc -DHAVE_CONFIG_H -I. -I../..  -Wall  -include ../../config.h -I../../lib -I../../src/api -I../../src/common -I../../src/libminicoredumper -DMCD_CONF_PATH=\"/etc/minicoredumper\"  -I/usr/include/json-c    -O2 -pipe -c -o minicoredumper-prog_config.o `test -f 'prog_config.c' || echo './'`prog_config.c
corestripper.c: In function 'print_fmt_token':
corestripper.c:205:28: error: 'PA_LAST' undeclared (first use in this function)
  205 |                 fmt_type = PA_LAST;
      |                            ^~~~~~~
corestripper.c:205:28: note: each undeclared identifier is reported only once for each function it appears in
corestripper.c:237:14: error: 'PA_INT' undeclared (first use in this function)
  237 |         case PA_INT:
      |              ^~~~~~
corestripper.c:239:14: error: 'PA_CHAR' undeclared (first use in this function)
  239 |         case PA_CHAR:
      |              ^~~~~~~
corestripper.c:241:14: error: 'PA_STRING' undeclared (first use in this function); did you mean 'SHF_STRINGS'?
  241 |         case PA_STRING:
      |              ^~~~~~~~~
      |              SHF_STRINGS
corestripper.c:243:14: error: 'PA_POINTER' undeclared (first use in this function)
  243 |         case PA_POINTER:
      |              ^~~~~~~~~~
corestripper.c:245:14: error: 'PA_FLOAT' undeclared (first use in this function)
  245 |         case PA_FLOAT:
      |              ^~~~~~~~
corestripper.c:247:14: error: 'PA_DOUBLE' undeclared (first use in this function)
  247 |         case PA_DOUBLE:
      |              ^~~~~~~~~
corestripper.c:249:24: error: 'PA_FLAG_SHORT' undeclared (first use in this function)
  249 |         case (PA_INT | PA_FLAG_SHORT):
      |                        ^~~~~~~~~~~~~
corestripper.c:251:24: error: 'PA_FLAG_LONG' undeclared (first use in this function)
  251 |         case (PA_INT | PA_FLAG_LONG):
      |                        ^~~~~~~~~~~~
corestripper.c:253:24: error: 'PA_FLAG_LONG_LONG' undeclared (first use in this function)
  253 |         case (PA_INT | PA_FLAG_LONG_LONG):
      |                        ^~~~~~~~~~~~~~~~~
corestripper.c:255:27: error: 'PA_FLAG_LONG_DOUBLE' undeclared (first use in this function)
  255 |         case (PA_DOUBLE | PA_FLAG_LONG_DOUBLE):
      |                           ^~~~~~~~~~~~~~~~~~~
corestripper.c: At top level:
corestripper.c:3561:30: warning: 'enum __ptrace_request' declared inside parameter list will not be visible outside of this definition or declaration
 3561 | static long ptrace_tree(enum __ptrace_request request, pid_t pid)
      |                              ^~~~~~~~~~~~~~~~
corestripper.c:3561:47: error: parameter 1 ('request') has incomplete type
 3561 | static long ptrace_tree(enum __ptrace_request request, pid_t pid)
      |                         ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
make[3]: *** [Makefile:501: minicoredumper-corestripper.o] Error 1

[jogness]

I think will be easiest if I get it compiling on my own. I have access to a musl system. I will post once I have some results.