Problem description
It's about a few functions:
- Get-FabricRecoveryPoint
- New-FabricRecoveryPoint
- Restore-FabricRecoveryPoint
- Remove-FabricRecoveryPoint
I understand they were moved into the project as-is, so now is a good time to start aligning them with the patterns we use in other functions.
It doesn’t have to be a complete refactor right away, but even partial alignment would be a good step forward.
Verbose logs
Module Version
develop branch
Suggested solution
- Recovery Points are related to the Warehouse in Fabric? If so, (sorry, I'm not sure) maybe we should consider renaming the functions by adding Datawarehouse:
Get-FabricDatawarehouseRecoveryPoint or Get-FabricWarehouseRecoveryPoint
- There are no mandatory/non-mandatory attributes for input parameters
- Delete
Get-FabricUri and use Invoke-FabricRestMethod instead
- Formatting: sometimes no spaces after
if
- Input parameters should be
*Id rather than *GUID
WorkspaceId & DataWarehouseId should be mandatory
- Switch param
Wait should be replaced by NoWait
.SYNOPSIS & .DESCRIPTION are the same. The latter could be more descriptive.
- Use
Confirm-TokenState at the beginning of each function
Problem description
It's about a few functions:
I understand they were moved into the project as-is, so now is a good time to start aligning them with the patterns we use in other functions.
It doesn’t have to be a complete refactor right away, but even partial alignment would be a good step forward.
Verbose logs
Module Version
develop branch
Suggested solution
Get-FabricDatawarehouseRecoveryPointorGet-FabricWarehouseRecoveryPointGet-FabricUriand useInvoke-FabricRestMethodinsteadif*Idrather than*GUIDWorkspaceId&DataWarehouseIdshould be mandatoryWaitshould be replaced byNoWait.SYNOPSIS&.DESCRIPTIONare the same. The latter could be more descriptive.Confirm-TokenStateat the beginning of each function