fix(test): raise pytest-rerunfailures floor to stop fixture leak across reruns - #1618
Merged
Conversation
…ss reruns Min-deps pinned 14.0, which dropped class-scoped setup finalizers on rerun and leaked the first class's dbt project into later Python-model tests. Bump to >=16.2 and drop the SchemaNameVarMixin workaround that was papering over it.
1.12.3 is already released; this test-only change belongs in the next version.
Collaborator
Author
|
/integration-test min-deps |
sd-db
enabled auto-merge (squash)
July 28, 2026 19:32
|
Min-deps integration tests dispatched for PR #1618 by @sd-db. Testing commit 3418865. Track progress in the Actions tab. |
Coverage report
This PR does not seem to contain any modification to coverable code. |
|
Min-deps integration results for PR #1618 — UC cluster ✅ success · SQL warehouse ✅ success · All-purpose cluster ✅ success · Shard coverage ✅ success |
jprakash-db
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pytest-rerunfailureslower bound to>=16.2(and regenerate the min-deps lock) so CI no longer pins 14.0projectfixture into later classes on the same xdist workerTestSpecifyingHttpPathcluster REPL failure into false failures inTestJobClusterMissingConfig,TestAllPurposeClusterMissingClusterId, andTestManagedIcebergPythonModelon Min-Deps SQL-warehouse shard 0 (run 30367154216)SchemaNameVarMixinworkaround that was papering over the same leak (test-only, no runtime impact)Test plan
pytest-rerunfailures==14.0with--reruns 1; absent on 15.0–16.2TestChangingSchema/TestChangingSchemaIncrementalpass on SQL warehousehatch run code-quality/ pre-commit hooks passTestSpecifyingHttpPathREPL failure, without the cascade)