feat: add column level tags for snapshots - #1442
Conversation
Signed-off-by: Matt Morris <matt.morris@protective.com>
3bf810b to
6bedb86
Compare
|
Hi @themattmorris , can you look to add a functional test to confirm the fix ? |
Coverage report
This PR does not seem to contain any modification to coverable code. |
|
Following up @themattmorris , thanks again for the PR. I am looking to ship this in the upcoming release and doing some testing locally. I will add the tests(also helps in my local testing) and drive this to completion ! |
Verifies that column-level databricks_tags configured under `snapshots:` in schema.yml are applied to the snapshot relation after the materialization runs, and that subsequent runs converge to an updated tag set. Exercises the new apply_column_tags call site in the snapshot materialization end-to-end against information_schema.column_tags.
|
/integration-test |
|
Integration tests dispatched for PR #1442 by @sd-db. Track progress in the Actions tab. |
|
Integration results for PR #1442 — UC cluster ✅ success · SQL warehouse ✅ success · All-purpose cluster ✅ success · Shard coverage ✅ success |
PR #1442's CHANGELOG patch anchored its diff above `## dbt-databricks 1.11.7`, which placed the bullet inside the (now-released) 1.11.8 section. The fix in #1442 is shipping under 1.12.1, so the entry belongs there instead. Also reword the entry: it's a bug fix (column tags were silently dropped), not a new feature, so phrase it as "Fix ..." and name the missing call (`apply_column_tags`) to match the level of detail of neighboring entries.
Thanks, as you can likely tell in my delayed response, this got away from me. Thank you for picking it up and bringing this to completion! |
2 participants
Resolves #1441
Description
Enables column level tags to be applied for snapshots.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.