test: fix failing TestStreamingTableLiquidClusteringChanges - #1436
Merged
Conversation
…e alone The class-level @skip_profile marker is enforced by a function-scope autouse fixture in tests/conftest.py, so any class-scope autouse setup runs before the skip can fire. On Assigned / No-isolation clusters, the dbt run in the old setup fixture errored with REQUIRES_SHARED_COMPUTE before the skip took effect, turning the marker into a flake (whether it skipped or errored depended on the active cluster type). Match the sibling TestStreamingTableLiquidClustering pattern: drop the class-scope autouse setup and inline `seed` + initial `--full-refresh` into the only test method. The function-scope skip then fires correctly.
sd-db
changed the title
TestStreamingTableLiquidClusteringChanges
Collaborator
Author
|
/integration-test |
|
Integration tests dispatched for PR #1436 by @sd-db. Track progress in the Actions tab. |
Coverage report
This PR does not seem to contain any modification to coverable code. |
sd-db
commented
May 2, 2026
|
|
||
| yield | ||
|
|
||
| project.run_sql(f"drop schema if exists {project.test_schema} cascade") |
Collaborator
Author
There was a problem hiding this comment.
note: skipped the cleanup as this is already handed by the parent class (dbt-core/core/dbt/tests/fixtures/project.py)
sd-db
changed the title
TestStreamingTableLiquidClusteringChangesTestStreamingTableLiquidClusteringChanges
|
Integration results for PR #1436 — UC cluster ✅ success · SQL warehouse ✅ success · All-purpose cluster ✅ success |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
See cluster/uc-cluster integration test runs failing with the same error
While the test is gated behind a profile check and runs only on
sqlwarehouse, the underlying setup is not gated which is what leads to the error here. The fix is simple to remove the common setup utility and move this inside the function which has the proper gating.Test plan
hatch run pytest tests/functional/adapter/streaming_tables/test_st_basic.py::TestStreamingTableLiquidClusteringChanges -v --profile databricks_uc_sql_endpoint—1 passedin 76shatch run pytest tests/functional/adapter/streaming_tables/test_st_basic.py::TestStreamingTableLiquidClusteringChanges -v --profile databricks_uc_cluster—1 skipped(no dbt-run output emitted)