Skip to content

Commit a4c2741

Browse files
rugpanovclaudehappy-otter
authored
Remove unused @types/eslint and mock-require dependencies (#1998)
## Why Three devDependencies in `packages/databricks-vscode` are declared but **never referenced** anywhere in source, scripts, or config: - **`@types/eslint`** — a legacy community type stub for older ESLint. The only custom lint rule (`mutexSynchronisedDecorator`) is typed via `@typescript-eslint/utils`, and modern ESLint (9+) ships its own types. Dependabot opened #1994 to bump it `8.56.12 → 9.6.1`, but bumping an unused package is churn. **This PR supersedes #1994**, which can be closed. - **`mock-require` + `@types/mock-require`** — an unused mocking helper (last published 2019) and its types. Test code uses `ts-mockito`, not `mock-require`. Removing them cleans up dead weight and shrinks the surface for the eventual ESLint 9/10 flat-config migration. ## What - Drop `@types/eslint`, `mock-require`, and `@types/mock-require` from `packages/databricks-vscode/package.json`. - Regenerate `yarn.lock`; this also drops now-orphaned transitive deps with no other dependents: - via `@types/eslint`: `@types/estree`, `@types/json-schema` - via `mock-require`: `get-caller-file@^1`, `normalize-path@^2`, `remove-trailing-separator` ## Verification - Confirmed **zero references** for all three: no imports, no API-type usage (`Rule`/`Linter`/`ESLint`), not in any tsconfig `types` array — only the package.json declaration lines. - `yarn.lock` confirms all were **direct deps only** (not transitive); every orphaned transitive dep confirmed to have **0 remaining refs**. - `tsc --build --force` (workspace TypeScript 6.0.3): **exit 0**, no errors. - `yarn test:lint` (eslint + prettier): **exit 0**, custom local rule intact. ## Backward compatibility Dev-tooling only — no shipped extension code or behavior changes. No user-facing compatibility impact. This pull request and its description were written by Isaac. Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Happy <yesreply@happy.engineering>
1 parent 2d78c22 commit a4c2741

2 files changed

Lines changed: 0 additions & 70 deletions

File tree

packages/databricks-vscode/package.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1564,11 +1564,9 @@
15641564
"@istanbuljs/nyc-config-typescript": "^1.0.2",
15651565
"@sinonjs/fake-timers": "^15.4.0",
15661566
"@types/chai": "^4.3.11",
1567-
"@types/eslint": "^8.44.9",
15681567
"@types/fs-extra": "^11.0.4",
15691568
"@types/ini": "^4.1.1",
15701569
"@types/mocha": "^10.0.6",
1571-
"@types/mock-require": "^3.0.0",
15721570
"@types/node": "^22.0.0",
15731571
"@types/semver": "^7.5.0",
15741572
"@types/tmp": "^0.2.6",
@@ -1592,7 +1590,6 @@
15921590
"fs-extra": "^11.2.0",
15931591
"glob": "^13.0.6",
15941592
"mocha": "^11.7.6",
1595-
"mock-require": "^3.0.3",
15961593
"nyc": "^18.0.0",
15971594
"prettier": "^3.1.1",
15981595
"quicktype-core": "^23.0.0",

yarn.lock

Lines changed: 0 additions & 67 deletions
Original file line numberDiff line numberDiff line change
@@ -1573,23 +1573,6 @@ __metadata:
15731573
languageName: node
15741574
linkType: hard
15751575

1576-
"@types/eslint@npm:^8.44.9":
1577-
version: 8.44.9
1578-
resolution: "@types/eslint@npm:8.44.9"
1579-
dependencies:
1580-
"@types/estree": "*"
1581-
"@types/json-schema": "*"
1582-
checksum: 6f8889e94e67a5e43c15f5a2530798f864ace08c270bfb3f153cb705da4e30a80e0e9a0fc05317c8642c8dda909d528968172089eb4d52aca9f212761df25d90
1583-
languageName: node
1584-
linkType: hard
1585-
1586-
"@types/estree@npm:*":
1587-
version: 1.0.3
1588-
resolution: "@types/estree@npm:1.0.3"
1589-
checksum: f21a5448995f8aa61ab2248d10590d275666b11d26c27fe75b3c23420b07b469d5ce820deefcf7399671faa09d56eb7ce012322948e484d94686fda154be5221
1590-
languageName: node
1591-
linkType: hard
1592-
15931576
"@types/fs-extra@npm:^11.0.4":
15941577
version: 11.0.4
15951578
resolution: "@types/fs-extra@npm:11.0.4"
@@ -1646,13 +1629,6 @@ __metadata:
16461629
languageName: node
16471630
linkType: hard
16481631

1649-
"@types/json-schema@npm:*":
1650-
version: 7.0.14
1651-
resolution: "@types/json-schema@npm:7.0.14"
1652-
checksum: 4b3dd99616c7c808201c56f6c7f6552eb67b5c0c753ab3fa03a6cb549aae950da537e9558e53fa65fba23d1be624a1e4e8d20c15027efbe41e03ca56f2b04fb0
1653-
languageName: node
1654-
linkType: hard
1655-
16561632
"@types/jsonfile@npm:*":
16571633
version: 6.1.1
16581634
resolution: "@types/jsonfile@npm:6.1.1"
@@ -1676,13 +1652,6 @@ __metadata:
16761652
languageName: node
16771653
linkType: hard
16781654

1679-
"@types/mock-require@npm:^3.0.0":
1680-
version: 3.0.0
1681-
resolution: "@types/mock-require@npm:3.0.0"
1682-
checksum: 81d24326f760c5e560f49c96b7ac3e6c91fd8f3d4bfa4303f83c326022758ab7accded8ab83542bea5402cd997c1114fd24e80a17e598a6c8f36e48055e8aae8
1683-
languageName: node
1684-
linkType: hard
1685-
16861655
"@types/node@npm:*":
16871656
version: 18.15.11
16881657
resolution: "@types/node@npm:18.15.11"
@@ -4019,12 +3988,10 @@ __metadata:
40193988
"@istanbuljs/nyc-config-typescript": ^1.0.2
40203989
"@sinonjs/fake-timers": ^15.4.0
40213990
"@types/chai": ^4.3.11
4022-
"@types/eslint": ^8.44.9
40233991
"@types/fs-extra": ^11.0.4
40243992
"@types/ini": ^4.1.1
40253993
"@types/lodash": ^4.14.202
40263994
"@types/mocha": ^10.0.6
4027-
"@types/mock-require": ^3.0.0
40283995
"@types/node": ^22.0.0
40293996
"@types/semver": ^7.5.0
40303997
"@types/shell-quote": ^1.7.5
@@ -4059,7 +4026,6 @@ __metadata:
40594026
markdown-it: ^14.2.0
40604027
minimatch: ^10.0.1
40614028
mocha: ^11.7.6
4062-
mock-require: ^3.0.3
40634029
nyc: ^18.0.0
40644030
prettier: ^3.1.1
40654031
quicktype-core: ^23.0.0
@@ -5623,13 +5589,6 @@ __metadata:
56235589
languageName: node
56245590
linkType: hard
56255591

5626-
"get-caller-file@npm:^1.0.2":
5627-
version: 1.0.3
5628-
resolution: "get-caller-file@npm:1.0.3"
5629-
checksum: 2b90a7f848896abcebcdc0acc627a435bcf05b9cd280599bc980ebfcdc222416c3df12c24c4845f69adc4346728e8966f70b758f9369f3534182791dfbc25c05
5630-
languageName: node
5631-
linkType: hard
5632-
56335592
"get-caller-file@npm:^2.0.1, get-caller-file@npm:^2.0.5":
56345593
version: 2.0.5
56355594
resolution: "get-caller-file@npm:2.0.5"
@@ -7804,16 +7763,6 @@ __metadata:
78047763
languageName: node
78057764
linkType: hard
78067765

7807-
"mock-require@npm:^3.0.3":
7808-
version: 3.0.3
7809-
resolution: "mock-require@npm:3.0.3"
7810-
dependencies:
7811-
get-caller-file: ^1.0.2
7812-
normalize-path: ^2.1.1
7813-
checksum: 6355c0bd9d7acb5247155142928b0154ace2913264b42d9a611a85d469ed11048f405efe432ffc627a57efb87ec359589a7419bf680b4fd248612311deb031bd
7814-
languageName: node
7815-
linkType: hard
7816-
78177766
"modern-tar@npm:^0.7.2":
78187767
version: 0.7.6
78197768
resolution: "modern-tar@npm:0.7.6"
@@ -8004,15 +7953,6 @@ __metadata:
80047953
languageName: node
80057954
linkType: hard
80067955

8007-
"normalize-path@npm:^2.1.1":
8008-
version: 2.1.1
8009-
resolution: "normalize-path@npm:2.1.1"
8010-
dependencies:
8011-
remove-trailing-separator: ^1.0.1
8012-
checksum: 7e9cbdcf7f5b8da7aa191fbfe33daf290cdcd8c038f422faf1b8a83c972bf7a6d94c5be34c4326cb00fb63bc0fd97d9fbcfaf2e5d6142332c2cd36d2e1b86cea
8013-
languageName: node
8014-
linkType: hard
8015-
80167956
"normalize-path@npm:^3.0.0, normalize-path@npm:~3.0.0":
80177957
version: 3.0.0
80187958
resolution: "normalize-path@npm:3.0.0"
@@ -8993,13 +8933,6 @@ __metadata:
89938933
languageName: node
89948934
linkType: hard
89958935

8996-
"remove-trailing-separator@npm:^1.0.1":
8997-
version: 1.1.0
8998-
resolution: "remove-trailing-separator@npm:1.1.0"
8999-
checksum: d3c20b5a2d987db13e1cca9385d56ecfa1641bae143b620835ac02a6b70ab88f68f117a0021838db826c57b31373d609d52e4f31aca75fc490c862732d595419
9000-
languageName: node
9001-
linkType: hard
9002-
90038936
"require-directory@npm:^2.1.1":
90048937
version: 2.1.1
90058938
resolution: "require-directory@npm:2.1.1"

0 commit comments

Comments
 (0)