From 0b5e3b0138b3dd231fbf8b674d29024a243a051b Mon Sep 17 00:00:00 2001 From: Goostaf Date: Tue, 19 May 2026 21:59:48 +0200 Subject: [PATCH 1/7] Don't push image when external PR --- .github/workflows/docker.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index af86de84..30d74626 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -43,7 +43,7 @@ jobs: - name: Build Docker image (and push on main) uses: docker/build-push-action@v6 with: - push: true + push: ${{ github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository }} tags: ${{ steps.meta.outputs.tags }} labels: ${{ steps.meta.outputs.labels }} cache-from: type=gha From db7a46a035c7998596fb4467ebe32c976cfd7d50 Mon Sep 17 00:00:00 2001 From: Goostaf Date: Thu, 28 May 2026 22:36:02 +0200 Subject: [PATCH 2/7] Change reporter and fail mode --- .github/workflows/code_validation.yml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/code_validation.yml b/.github/workflows/code_validation.yml index 15e195d4..1062dd21 100644 --- a/.github/workflows/code_validation.yml +++ b/.github/workflows/code_validation.yml @@ -31,7 +31,8 @@ jobs: - run: pnpm test run-linters: - name: Execute linters + run-linters: + name: Linting runs-on: ubuntu-latest steps: @@ -53,8 +54,9 @@ jobs: uses: reviewdog/action-eslint@v1 with: github_token: ${{ secrets.GITHUB_TOKEN }} - reporter: github-pr-check + reporter: github-pr-annotations filter_mode: ${{ (github.event_name == 'pull_request') && 'file' || 'nofilter' }} + fail_level: 'warning' level: ${{ (github.event_name == 'pull_request') && 'error' || 'warning' }} tool_name: ESLint @@ -62,7 +64,8 @@ jobs: uses: EPMatt/reviewdog-action-prettier@v1 with: github_token: ${{ secrets.GITHUB_TOKEN }} - reporter: github-pr-check + reporter: github-pr-annotations filter_mode: ${{ (github.event_name == 'pull_request') && 'file' || 'nofilter' }} + fail_level: 'warning' level: ${{ (github.event_name == 'pull_request') && 'error' || 'warning' }} tool_name: Prettier From 39190cb10d154ba55381118c18606db938d4e9a1 Mon Sep 17 00:00:00 2001 From: Goostaf Date: Thu, 28 May 2026 22:38:46 +0200 Subject: [PATCH 3/7] Formatting --- .github/workflows/code_validation.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/code_validation.yml b/.github/workflows/code_validation.yml index 1062dd21..beb1fcb9 100644 --- a/.github/workflows/code_validation.yml +++ b/.github/workflows/code_validation.yml @@ -30,7 +30,6 @@ jobs: - run: pnpm test - run-linters: run-linters: name: Linting runs-on: ubuntu-latest @@ -56,7 +55,7 @@ jobs: github_token: ${{ secrets.GITHUB_TOKEN }} reporter: github-pr-annotations filter_mode: ${{ (github.event_name == 'pull_request') && 'file' || 'nofilter' }} - fail_level: 'warning' + fail_level: warning level: ${{ (github.event_name == 'pull_request') && 'error' || 'warning' }} tool_name: ESLint @@ -66,6 +65,6 @@ jobs: github_token: ${{ secrets.GITHUB_TOKEN }} reporter: github-pr-annotations filter_mode: ${{ (github.event_name == 'pull_request') && 'file' || 'nofilter' }} - fail_level: 'warning' + fail_level: warning level: ${{ (github.event_name == 'pull_request') && 'error' || 'warning' }} tool_name: Prettier From 9fae51c81f2383e2fd58657742cd2043204c7329 Mon Sep 17 00:00:00 2001 From: Goostaf Date: Thu, 28 May 2026 22:44:22 +0200 Subject: [PATCH 4/7] Add deliberate issues --- src/instrumentation.ts | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/instrumentation.ts b/src/instrumentation.ts index f6393502..207b7202 100644 --- a/src/instrumentation.ts +++ b/src/instrumentation.ts @@ -3,14 +3,17 @@ import NewsService from './services/newsService'; import DivisionGroupService from './services/divisionGroupService'; export async function register() { - if (process.env.NEXT_RUNTIME === 'nodejs') { - console.log('Scheduling tasks'); + var unusedVar = 0; + + if (process.env.NEXT_RUNTIME === 'nodejs') + { + console.log( 'Scheduling tasks' ); const newsPublishRule = new schedule.RecurrenceRule(); newsPublishRule.second = 0; schedule.scheduleJob(newsPublishRule, NewsService.publishScheduled); schedule.scheduleJob( - '0 0 * * 1', + '0 0 * * 1', DivisionGroupService.updatePrettyNamesFromGamma ); } From d16cfeb2218d9a0ea1b6d9d3680f4b2ec5dd44bb Mon Sep 17 00:00:00 2001 From: Goostaf Date: Thu, 28 May 2026 22:47:14 +0200 Subject: [PATCH 5/7] Run validation regardless of previous outcomes --- .github/workflows/code_validation.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/code_validation.yml b/.github/workflows/code_validation.yml index beb1fcb9..227ee897 100644 --- a/.github/workflows/code_validation.yml +++ b/.github/workflows/code_validation.yml @@ -48,6 +48,7 @@ jobs: - run: pnpm install prettier - run: pnpm install --frozen-lockfile + id: install_dependencies - name: ESLint uses: reviewdog/action-eslint@v1 @@ -60,6 +61,7 @@ jobs: tool_name: ESLint - name: Prettier + if: ${{ !cancelled() && steps.install_dependencies.outcome == 'success' }} uses: EPMatt/reviewdog-action-prettier@v1 with: github_token: ${{ secrets.GITHUB_TOKEN }} From fcbb0efe0ee5ccf720fdb70f320ac33e4b60608e Mon Sep 17 00:00:00 2001 From: Goostaf Date: Thu, 28 May 2026 22:50:07 +0200 Subject: [PATCH 6/7] Resolve ESLint --- src/instrumentation.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/instrumentation.ts b/src/instrumentation.ts index 207b7202..5585d1f9 100644 --- a/src/instrumentation.ts +++ b/src/instrumentation.ts @@ -3,8 +3,6 @@ import NewsService from './services/newsService'; import DivisionGroupService from './services/divisionGroupService'; export async function register() { - var unusedVar = 0; - if (process.env.NEXT_RUNTIME === 'nodejs') { console.log( 'Scheduling tasks' ); From c88860902d0c2f3f0e2a780c3498956ddc059526 Mon Sep 17 00:00:00 2001 From: Goostaf Date: Thu, 28 May 2026 22:57:38 +0200 Subject: [PATCH 7/7] Resolve Prettier --- src/instrumentation.ts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/instrumentation.ts b/src/instrumentation.ts index 5585d1f9..f6393502 100644 --- a/src/instrumentation.ts +++ b/src/instrumentation.ts @@ -3,15 +3,14 @@ import NewsService from './services/newsService'; import DivisionGroupService from './services/divisionGroupService'; export async function register() { - if (process.env.NEXT_RUNTIME === 'nodejs') - { - console.log( 'Scheduling tasks' ); + if (process.env.NEXT_RUNTIME === 'nodejs') { + console.log('Scheduling tasks'); const newsPublishRule = new schedule.RecurrenceRule(); newsPublishRule.second = 0; schedule.scheduleJob(newsPublishRule, NewsService.publishScheduled); schedule.scheduleJob( - '0 0 * * 1', + '0 0 * * 1', DivisionGroupService.updatePrettyNamesFromGamma ); }