EventCRON for Laravel 4

[sebastiaanluca]

Hope you don't mind, but I made a package of your EventCRON code for Laravel 4.x. I'm kind of new to pull requests and whatnot, but I had to make a separate repository for this. If you want, I can put this on Packagist so anyone can get it via Composer.

https://github.com/Quagh/laravel-4-eventcron

[cossou]

Great! Do you want to make a new tag for this version? Or you prefer to maintain your own repo?
I had some changes I wanted to make to the code base.

[sebastiaanluca]

I thought some would still like to use your repo for Laravel 3. But it's all the same for me. So yeah, either via multiple repositories or tagging / different branches. And then we can put this on packagist so I can use it anywhere via Composer :)

What changes did you have planned?

[cossou]

The processed field should have another status for long running processes. Like 0, 1 and 2.
0 - not processed
1 - processing
2 - processed

[sebastiaanluca]

Hi again. I implemented your idea while I was at it and refactored some stuff. Feedback is appreciated!

[cossou]

Nice @quagh!

Write some docs and tests and put it on Packagist.
I would suggest you to think about recursive events. That's something I wanted to implement but never had time.

[sebastiaanluca]

Perhaps you could help me out with the testing part? Never done that before, maybe you know more of it. I could do it, but it won't be a priority as I have other urgent projects. I'll see if I can update the README this evening, but most of it is the same as yours. Mind if I add myself to the contact section? It's still your package of course, I'm just updating it for Laravel 4 and to better suit my own and anyone else's needs ;)

Do you mean events that happen every specific time? For now, I would just add the event again in the event handler, but it's indeed a nice feature to have.

[cossou]

Sure, no problem! Sorry for taking so long to reply. I will try to take a look during this week. I'm not sure how to tag the versions, etc...

[sebastiaanluca]

No sweat; I don't find 12 hours "long" ;) Unless I'm at work. Ba-dum tss.

Anyway. Would be cool if you could do that! I'm currently just implementing the package in my own project and adding features to it as I see fit or deem necessary. I've come up with a short list of functionality I think I'll eventually need. Perhaps you (or anyone else) have some comments on it. It's written a bit cryptic, but hopefully you'll get the gist.

    // TODO: clear old entries (config option to check when flushing queues + manual function call)(params? Relative date, number of processed entries, ... Always for processed/cancelled entries)
    // TODO: cancel all unprocessed events of a specific type (new status)
    // TODO: cancel all unprocessed events (also new status)
    // TODO: get a list of all events of a specific type with a specific status (either by array or something like `UNPROCESSED | PROCESSED | PROCESSING`)
    // TODO: get a list of all events with a specific status (either by array or something like `UNPROCESSED | PROCESSED | PROCESSING`)

As for tagging and such, have a look at git-flow if you haven't heard of it before (http://nvie.com/posts/a-successful-git-branching-model/). I'm using it everywhere and since it's built-in in SourceTree (Mac Git GUI), it's a breeze.

If you're making adjustments, just make sure to create a branch in the feature subfolder, as per git-flow conventions. Something like feature/testing/base-tests. I'm fairly new to public GitHub repos, so I don't know if I can easily make you an admin or something so you can commit without creating a pull request. I'll look into that later unless you know how to.

[cossou]

Sorry, again! :)

I will create a new branch for the old release "laravel-3" maybe. And then we can make a pull request to the new branch (master or feature). Not sure how to do it. I will give it a try.

As for the git-flow, I already use it. In a bit different way. I have a development branch and a master (for development and the other for production) and also a branch per feature (a bit messy).
I will probably give git-flow a try in my next big project.

Thanks

[cossou]

Hi @quagh
I'm migrating a project that uses EventCron. I tried your version but I was not able to make it work.
Do you mind writing an README.md in the repo?

Thanks

[sebastiaanluca]

I fixed some issues and added a readme. Let me know if it's clear enough or the package doesn't work like it should.

Cheers!

[cossou]

@quagh OMG! Great job! 👍