Skip to content

fix: add distinctUntilChanged before flatMapLatest on stateFlow-derived flows #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 1 commit into from
Jun 5, 2026
Merged

fix: add distinctUntilChanged before flatMapLatest on stateFlow-derived flows #868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...res/direct-send/src/main/kotlin/com/flipcash/app/directsend/internal/SendFlowViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ import kotlinx.coroutines.delay
import kotlinx.coroutines.flow.SharingStarted
import kotlinx.coroutines.flow.StateFlow
import kotlinx.coroutines.flow.combine
import kotlinx.coroutines.flow.distinctUntilChanged
import kotlinx.coroutines.flow.filter
import kotlinx.coroutines.flow.filterIsInstance
import kotlinx.coroutines.flow.filterNotNull
Expand Down Expand Up @@ -182,7 +183,7 @@ internal class SendFlowViewModel @Inject constructor(

combine(
contactCoordinator.state,
stateFlow.map { it.searchState }.flatMapLatest { snapshotFlow { it.text } }
stateFlow.map { it.searchState }.distinctUntilChanged().flatMapLatest { snapshotFlow { it.text } }
) { contactState, searchText ->
generateListItems(contactState, searchText.toString())
}.onEach { items ->
Expand Down
2 changes: 2 additions & 0 deletions ...ons/src/main/kotlin/com/flipcash/app/transactions/internal/TransactionHistoryViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import com.getcode.solana.keys.PublicKey
import com.getcode.util.resources.ResourceHelper
import com.getcode.view.BaseViewModel
import dagger.hilt.android.lifecycle.HiltViewModel
import kotlinx.coroutines.flow.distinctUntilChanged
import kotlinx.coroutines.flow.filterIsInstance
import kotlinx.coroutines.flow.flatMapLatest
import kotlinx.coroutines.flow.launchIn
Expand Down Expand Up @@ -131,6 +132,7 @@ class TransactionHistoryViewModel @Inject constructor(
}

val transactions = stateFlow.mapNotNull { it.mint }
.distinctUntilChanged()
.flatMapLatest { mint -> feedCoordinator.transactions(mint) }

companion object {
Expand Down
1 change: 1 addition & 0 deletions apps/flipcash/shared/tokens/src/main/kotlin/com/flipcash/app/tokens/ui/TokenInfoViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ class TokenInfoViewModel @Inject constructor(
eventFlow
.filterIsInstance<Event.OnBalanceUpdated>()
.mapNotNull { stateFlow.value.mint }
.distinctUntilChanged()
.flatMapLatest { mint ->
accountController.observeHasAccountFor(mint)
}
Expand Down
Loading