Skip to content

[NGT] Updates for Phase2-HLT nanoAODs#51103

Merged
cmsbuild merged 4 commits into
cms-sw:masterfrom
cms-ngt-hlt:mm_dev_taugeninfo_in_ph2nano
Jun 2, 2026
Merged

[NGT] Updates for Phase2-HLT nanoAODs#51103
cmsbuild merged 4 commits into
cms-sw:masterfrom
cms-ngt-hlt:mm_dev_taugeninfo_in_ph2nano

Conversation

@mmusich

@mmusich mmusich commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

PR description:

The goal of this PR is to add a few improvements to the phase-2 HLT nanoAOD flavours

PR validation:

runTheMatrix.py -l ph2_hlt runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, not to be backported.

@mmusich

mmusich commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

test parameters:

  • workflows = ph2_hlt

@cmsbuild cmsbuild added this to the CMSSW_17_0_X milestone Jun 1, 2026
@mmusich

mmusich commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

type ngt

@cmsbuild

cmsbuild commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@cmsbuild cmsbuild added the ngt label Jun 1, 2026
@cmsbuild

cmsbuild commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51103/49592

@cmsbuild

cmsbuild commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • HLTrigger/NGTScouting (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich

mmusich commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

@cmsbuild, please test

@cmsbuild

cmsbuild commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51103/49595

@cmsbuild

cmsbuild commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Pull request #51103 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

@mmusich

mmusich commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

@cmsbuild, please test

@cmsbuild

cmsbuild commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-229b2d/53614/summary.html
COMMIT: e301786
CMSSW: CMSSW_17_0_X_2026-05-31-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51103/53614/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 66
  • DQMHistoTests: Total histograms compared: 4598269
  • DQMHistoTests: Total failures: 23
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4598226
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 65 files compared)
  • Checked 276 log files, 232 edm output root files, 66 DQM output files
  • TriggerResults: no differences found

@mmusich

mmusich commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

+hlt

@cmsbuild

cmsbuild commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen

Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit ab59e98 into cms-sw:master Jun 2, 2026
11 checks passed
@mmusich mmusich deleted the mm_dev_taugeninfo_in_ph2nano branch June 2, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants