Hi,
First thanks for your work on this module, I've never been as aesthetically soothed when using my PC!
I think the global enable option is a bit confusing/unconventional: usually it disables all the config driven by options in the same attrset, but here it's just a default state for the other modules.
Example:
catppuccin.enable = false;
catppuccin.whatever.enable = true;
I'd expect this to not have any effect due to enable = false, as with essentially all modules out there, but currently the whatever program still has configuration installed.
I think basically the current behavior of enable should be moved to something like catppuccin.autoEnable, so that enable can be an actual kill switch. autoEnable is the name stylix uses, and it seems to me convenient to reuse it.
I'm willing to make a PR for this if you're interested, but just want to check if you're interested before spending time on it!
Hi,
First thanks for your work on this module, I've never been as aesthetically soothed when using my PC!
I think the global
enableoption is a bit confusing/unconventional: usually it disables all the config driven by options in the same attrset, but here it's just a default state for the other modules.Example:
I'd expect this to not have any effect due to
enable = false, as with essentially all modules out there, but currently thewhateverprogram still has configuration installed.I think basically the current behavior of
enableshould be moved to something likecatppuccin.autoEnable, so thatenablecan be an actual kill switch.autoEnableis the namestylixuses, and it seems to me convenient to reuse it.I'm willing to make a PR for this if you're interested, but just want to check if you're interested before spending time on it!