From 605e881526d50cea65a13eb4ddaeb416504adffa Mon Sep 17 00:00:00 2001 From: Simone Arpe Date: Wed, 29 Jul 2026 11:35:43 +0200 Subject: [PATCH 01/20] Remove orientation lock from Android manifest --- android/java/AndroidManifest.xml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/android/java/AndroidManifest.xml b/android/java/AndroidManifest.xml index 1fc2a01ecc4d7..a703d92ce4792 100644 --- a/android/java/AndroidManifest.xml +++ b/android/java/AndroidManifest.xml @@ -51,9 +51,7 @@ android:theme="@style/Theme.Chromium.Activity" /> + android:theme="@style/Theme.Chromium.Activity.FakeTranslucent" /> Date: Wed, 29 Jul 2026 11:35:59 +0200 Subject: [PATCH 02/20] Add missing copyright to XML layout --- android/java/brave-res/layout/approve_tx_bottom_sheet.xml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/android/java/brave-res/layout/approve_tx_bottom_sheet.xml b/android/java/brave-res/layout/approve_tx_bottom_sheet.xml index c4de9ecf622a9..c0f46149797d4 100644 --- a/android/java/brave-res/layout/approve_tx_bottom_sheet.xml +++ b/android/java/brave-res/layout/approve_tx_bottom_sheet.xml @@ -1,4 +1,9 @@ + Date: Wed, 29 Jul 2026 11:36:48 +0200 Subject: [PATCH 03/20] Make bottom sheet dialog full width in landscape for smartphones only --- .../WalletBottomSheetDialogFragment.java | 23 +++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/android/java/org/chromium/chrome/browser/crypto_wallet/fragments/WalletBottomSheetDialogFragment.java b/android/java/org/chromium/chrome/browser/crypto_wallet/fragments/WalletBottomSheetDialogFragment.java index 65241a60769cb..4a70aa8808611 100644 --- a/android/java/org/chromium/chrome/browser/crypto_wallet/fragments/WalletBottomSheetDialogFragment.java +++ b/android/java/org/chromium/chrome/browser/crypto_wallet/fragments/WalletBottomSheetDialogFragment.java @@ -5,9 +5,11 @@ package org.chromium.chrome.browser.crypto_wallet.fragments; +import android.app.Dialog; import android.content.Context; import android.content.DialogInterface; +import com.google.android.material.bottomsheet.BottomSheetDialog; import com.google.android.material.bottomsheet.BottomSheetDialogFragment; import org.chromium.brave_wallet.mojom.BraveWalletService; @@ -19,6 +21,7 @@ import org.chromium.chrome.browser.app.domain.KeyringModel; import org.chromium.chrome.browser.app.domain.WalletModel; import org.chromium.chrome.browser.crypto_wallet.observers.KeyringServiceObserverImpl; +import org.chromium.chrome.browser.util.ConfigurationUtils; /** * Base class for {@code BottomSheetDialogFragment} with wallet specific implementation @@ -77,6 +80,26 @@ public void onAttach(Context context) { } } + @Override + public void onStart() { + super.onStart(); + + // Tablets keep Material's default width. + if (ConfigurationUtils.isTablet(requireContext())) { + return; + } + + final Dialog dialog = getDialog(); + if (!(dialog instanceof BottomSheetDialog bottomSheetDialog)) { + return; + } + + // Material's BottomSheetDialog caps the sheet width (640dp by default) and + // centers it on wide layouts, which leaves side gaps in landscape. On phones + // we want the sheet to span the full width. + bottomSheetDialog.getBehavior().setMaxWidth(-1); + } + @Override public void onDismiss(DialogInterface dialog) { mKeyringObserver.close(); From 4757c500702cfe6096c865e1288eb328635eba07 Mon Sep 17 00:00:00 2001 From: Simone Arpe Date: Wed, 29 Jul 2026 11:37:28 +0200 Subject: [PATCH 04/20] Introduce landscape layout --- android/BUILD.gn | 1 + .../layout-land/approve_tx_bottom_sheet.xml | 291 ++++++++++++++++++ 2 files changed, 292 insertions(+) create mode 100644 android/java/brave-res/layout-land/approve_tx_bottom_sheet.xml diff --git a/android/BUILD.gn b/android/BUILD.gn index e3710d1971f65..92786b6d82ddd 100644 --- a/android/BUILD.gn +++ b/android/BUILD.gn @@ -477,6 +477,7 @@ android_resources("java_resources") { "java/brave-res/layout-land/activity_brave_origin_plans.xml", "java/brave-res/layout-land/activity_brave_vpn_profile.xml", "java/brave-res/layout-land/activity_vpn_paywall.xml", + "java/brave-res/layout-land/approve_tx_bottom_sheet.xml", "java/brave-res/layout-sw600dp/activity_welcome_onboarding.xml", "java/brave-res/layout/activity_account_selector.xml", "java/brave-res/layout/activity_add_account.xml", diff --git a/android/java/brave-res/layout-land/approve_tx_bottom_sheet.xml b/android/java/brave-res/layout-land/approve_tx_bottom_sheet.xml new file mode 100644 index 0000000000000..0d7184f43dd76 --- /dev/null +++ b/android/java/brave-res/layout-land/approve_tx_bottom_sheet.xml @@ -0,0 +1,291 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +