Add support for multi-phase module initialization#485
Merged
Conversation
Contributor
Author
|
I only unsure if |
Contributor
Author
|
Ping! |
o01eg
marked this pull request as draft
April 4, 2026 14:25
Contributor
Author
|
It's quite bad that nogil support was added only to single-phase initialization |
o01eg
force-pushed
the
multi-phase-module-init
branch
from
April 4, 2026 18:59
957157e to
40105f0
Compare
o01eg
marked this pull request as ready for review
April 4, 2026 19:00
Contributor
Author
|
Ping! I need an approval. |
Contributor
Author
|
Looks like Windows CI is broken not by my changes: What I see on https://www.7-zip.org/download.html there no such version. |
o01eg
force-pushed
the
multi-phase-module-init
branch
from
April 5, 2026 13:13
b43199f to
542974f
Compare
Contributor
Author
|
I've removed unsuccessful try to fix Windows CI. At least other OS passed. |
Member
|
hi @o01eg , please rebase this PR as we just fixed the Windows CI builds. Then we should be able to merge this quickly. Thanks ! |
o01eg
force-pushed
the
multi-phase-module-init
branch
from
June 21, 2026 19:52
542974f to
439ab0d
Compare
Contributor
Author
|
@stefanseefeld I've rebased it. |
Member
|
Thank you ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #484