fix(checkout): CHECKOUT-10299 Get gift certificates from payments for order page - #3245
Merged
Conversation
Contributor
Author
|
cursor review |
bc-maxy
marked this pull request as ready for review
August 12, 2026 07:12
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 9b5cf7d. Configure here.
bc-peng
reviewed
Aug 12, 2026
bc-peng
left a comment
bc-peng
left a comment
Contributor
There was a problem hiding this comment.
Other than the naming, the rest looks good to me.
animesh1987
reviewed
Aug 12, 2026
animesh1987
approved these changes
Aug 13, 2026
|
checkout-js deployed to Staging US |
⚡️ Lighthouse results🖥️ Desktop:
📱 Mobile:
|
|
checkout-js deployed to Production US |
|
checkout-js deployed to Integration US |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
GIft certificates are not shown on Order Confirmation page when
CHECKOUT-9674.multi_coupon_cart_checkoutflag istrue. It works fine when the flag isfalse.I changed the useMultiCoupon implementation to get giftCertificates from order.payments using an existing mapFromPayments helper.
Rollout/Rollback
Revert the PR.
Testing
New CI tests + manual testing.
Before the change
When the flag is
falseit renders correctly:When the flag is
trueit does not show gift certificates (even though they are applied):After the change
Gift certificates are visible:
Also consistent with checkout page for multi-coupon scenario:
Note
Low Risk
Localized display logic in
useMultiCouponwith an existing mapper; checkout path unchanged and new tests cover order confirmation cases.Overview
Fixes missing gift certificates on the order confirmation page when multi-coupon checkout is enabled (
CHECKOUT-9674.multi_coupon_cart_checkout).useMultiCouponnow buildsappliedGiftCertificatesfrom checkout gift-certificate data when a checkout is present, and fromorder.paymentsvia the existingmapFromPaymentshelper when only an order is available (confirmation). Checkout behavior is unchanged.Tests cover mapping from order payments, filtering non–gift-certificate payments, and empty/missing payments.
Reviewed by Cursor Bugbot for commit eda6b7f. Bugbot is set up for automated code reviews on this repo. Configure here.