Skip to content

fix: implement per-client data directory fallback and update gitignore#1059

Open
Kewe63 wants to merge 1 commit into
base:mainfrom
Kewe63:fix/docker-compose-host-data-dir-default-upstream
Open

fix: implement per-client data directory fallback and update gitignore#1059
Kewe63 wants to merge 1 commit into
base:mainfrom
Kewe63:fix/docker-compose-host-data-dir-default-upstream

Conversation

@Kewe63
Copy link
Copy Markdown

@Kewe63 Kewe63 commented May 11, 2026

Summary

Implements a default per-client fallback for HOST_DATA_DIR and updates .gitignore.

Problem

  • Unset HOST_DATA_DIR led to anonymous volumes in Docker Compose.
  • The default './data' directory (or any local data directory) was not ignored by git, risking accidental tracking of large chain datasets.

Solution

  • Updated docker-compose.yml to use a client-specific fallback: ${HOST_DATA_DIR:-./${CLIENT:-reth}-data}.
  • Added /data/ to .gitignore to cover the most common fallback path.

Verification

  • Verified volume mapping correctly defaults to ./reth-data (or equivalent).
  • Verified that local data directories are correctly ignored.

Impact

Prevents accidental repository bloat and ensures predictable data persistence.

@cb-heimdall
Copy link
Copy Markdown
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions Bot added the Stale label May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants