fix(authenticator): enforce required validation for empty phone number field - #7296
Merged
VarshithaPamisetty merged 4 commits intoAug 24, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7296 +/- ##
==========================================
+ Coverage 41.25% 41.39% +0.13%
==========================================
Files 121 121
Lines 8288 8289 +1
Branches 3604 3605 +1
==========================================
+ Hits 3419 3431 +12
+ Misses 4869 4858 -11 🚀 New features to boost your workflow:
|
VarshithaPamisetty
marked this pull request as ready for review
August 19, 2026 14:25
cadivus
approved these changes
Aug 24, 2026
VarshithaPamisetty
deleted the
fix/authenticator-phone-field-required-validation
branch
August 24, 2026 14:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A required phone number field (
SignUpFormField.phoneNumber(required: true)) still accepted an empty value.formatPhoneNumberprepended the dial code to empty input ("" -> "+1"), so the value looked non-empty, passed validation, and the form submitted a bogus dial-code-only number instead of showing the required error. This leaves empty input untouched so the required/empty check runs.Screenshots
Before: an empty required phone number passed validation and reached the
SignUpcall. After: it is blocked client-side with "Phone Number field must not be blank."Testing
Fixes #4079