From f56e6f4479a1f469405a7861158bd5fee77beb9d Mon Sep 17 00:00:00 2001 From: sksat Date: Thu, 8 Feb 2024 18:58:52 +0900 Subject: [PATCH 1/4] make reviewdog fail_on_error configurable --- .github/workflows/build.yml | 4 ++++ action-c2a-build/action.yml | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 35180c0..145ac60 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -56,6 +56,9 @@ on: reviewdog_default_filter: type: string default: added + reviewdog_fail_on_error: + type: boolean + default: true secrets: GH_FEDERATION_ENDPOINT: required: false @@ -100,6 +103,7 @@ jobs: reviewdog_tool_name: clang-tidy -${{ matrix.warning }} reviewdog_reporter: ${{ (!contains(matrix.warning, 'Wextra') && inputs.reviewdog_default_reporter ) || 'github-check' }} reviewdog_filter_mode: ${{ (!contains(matrix.warning, 'Wextra') && inputs.reviewdog_default_filter ) || 'nofilter' }} + reviewdog_fail_on_error: ${{ inputs.reviewdog_fail_on_error }} build_linux32_cxx: if: inputs.build_as_cxx diff --git a/action-c2a-build/action.yml b/action-c2a-build/action.yml index 61a1564..a4b3115 100644 --- a/action-c2a-build/action.yml +++ b/action-c2a-build/action.yml @@ -44,6 +44,9 @@ inputs: reviewdog_filter_mode: type: string default: added + reviewdog_fail_on_error: + type: boolean + default: true runs: using: "composite" @@ -125,3 +128,4 @@ runs: reporter: ${{ inputs.reviewdog_reporter }} filter_mode: ${{ inputs.reviewdog_filter_mode }} workdir: ./c2a_user/${{ inputs.c2a_dir }}/build + fail_on_error: ${{ inputs.reviewdog_fail_on_error }} From b554b785d3a3b9ca2df70526c31a2f0b38ca46a5 Mon Sep 17 00:00:00 2001 From: sksat Date: Thu, 8 Feb 2024 19:02:38 +0900 Subject: [PATCH 2/4] disable fail_on_error in test-build workflow to avoid error from old C2A code --- .github/workflows/test-build.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/test-build.yml b/.github/workflows/test-build.yml index 729fa37..5eb7f8e 100644 --- a/.github/workflows/test-build.yml +++ b/.github/workflows/test-build.yml @@ -32,3 +32,4 @@ jobs: build_as_cxx: true reviewdog_default_reporter: github-check reviewdog_default_filter: added + reviewdog_fail_on_error: false From e976839b0fa1f7b2fa19c0d8bfa2e0d5d9417436 Mon Sep 17 00:00:00 2001 From: sksat Date: Thu, 8 Feb 2024 19:07:09 +0900 Subject: [PATCH 3/4] TEMP --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 145ac60..6c6de36 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -64,7 +64,7 @@ on: required: false env: - SELF_VERSION: v5.4.0 + SELF_VERSION: make-reviewdog-fail-on-error-configurable jobs: build_linux32: From e48c54fdb26a4d76fa86ee3f5823657f4bb630f2 Mon Sep 17 00:00:00 2001 From: sksat Date: Thu, 8 Feb 2024 22:37:11 +0900 Subject: [PATCH 4/4] test with github-pr-review reporter --- .github/workflows/test-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-build.yml b/.github/workflows/test-build.yml index 5eb7f8e..35b2f29 100644 --- a/.github/workflows/test-build.yml +++ b/.github/workflows/test-build.yml @@ -30,6 +30,6 @@ jobs: cmake_flags_linux32: -DUSE_SCI_COM_WINGS=OFF -DC2A_USE_SCI_COM_WINGS=OFF sils_mockup: true build_as_cxx: true - reviewdog_default_reporter: github-check + reviewdog_default_reporter: github-pr-review reviewdog_default_filter: added reviewdog_fail_on_error: false