Skip to content

Commit 3b7ddf8

Browse files
Revert "fix(embedded-sdk): wire hideTab to actually hide the dashboard tab (#38846)"
This reverts commit 9619fa2.
1 parent 232a555 commit 3b7ddf8

1 file changed

Lines changed: 24 additions & 28 deletions

File tree

superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx

Lines changed: 24 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -523,33 +523,30 @@ const DashboardBuilder = () => {
523523
({ dropIndicatorProps }: { dropIndicatorProps: JsonObject }) => (
524524
<div>
525525
{dropIndicatorProps && <div {...dropIndicatorProps} />}
526-
{!isReport &&
527-
topLevelTabs &&
528-
!uiConfig.hideTab &&
529-
!uiConfig.hideNav && (
530-
<WithPopoverMenu
531-
shouldFocus={shouldFocusTabs}
532-
menuItems={[
533-
<IconButton
534-
key="collapse-tabs"
535-
icon={<Icons.FallOutlined iconSize="xl" />}
536-
label={t('Collapse tab content')}
537-
onClick={handleDeleteTopLevelTabs}
538-
/>,
539-
]}
540-
editMode={editMode}
541-
>
542-
<DashboardComponent
543-
id={topLevelTabs?.id}
544-
parentId={DASHBOARD_ROOT_ID}
545-
depth={DASHBOARD_ROOT_DEPTH + 1}
546-
index={0}
547-
renderTabContent={false}
548-
renderHoverMenu={false}
549-
onChangeTab={handleChangeTab}
550-
/>
551-
</WithPopoverMenu>
552-
)}
526+
{!isReport && topLevelTabs && !uiConfig.hideNav && (
527+
<WithPopoverMenu
528+
shouldFocus={shouldFocusTabs}
529+
menuItems={[
530+
<IconButton
531+
key="collapse-tabs"
532+
icon={<Icons.FallOutlined iconSize="xl" />}
533+
label={t('Collapse tab content')}
534+
onClick={handleDeleteTopLevelTabs}
535+
/>,
536+
]}
537+
editMode={editMode}
538+
>
539+
<DashboardComponent
540+
id={topLevelTabs?.id}
541+
parentId={DASHBOARD_ROOT_ID}
542+
depth={DASHBOARD_ROOT_DEPTH + 1}
543+
index={0}
544+
renderTabContent={false}
545+
renderHoverMenu={false}
546+
onChangeTab={handleChangeTab}
547+
/>
548+
</WithPopoverMenu>
549+
)}
553550
</div>
554551
),
555552
[
@@ -558,7 +555,6 @@ const DashboardBuilder = () => {
558555
handleDeleteTopLevelTabs,
559556
isReport,
560557
topLevelTabs,
561-
uiConfig.hideTab,
562558
uiConfig.hideNav,
563559
],
564560
);

0 commit comments

Comments
 (0)