refactor: use async/await, const and arrow function

Author: mariangz

tests/find/test-suite-1/test.type.js

@@ -1,11 +1,11 @@
 'use strict';
 
-describe('test.type.js', function () {
-  var sortById = testUtils.sortById;
+describe('test.type.js', () => {
+  const sortById = testUtils.sortById;
 
-  beforeEach(function () {
-    var db = context.db;
-    return db.bulkDocs([
+  beforeEach(async () => {
+    const db = context.db;
+    await db.bulkDocs([
       {_id: 'a', foo: 'bar'},
       {_id: 'b', foo: 1},
       {_id: 'c', foo: null},
@@ -15,107 +15,105 @@ describe('test.type.js', function () {
     ]);
   });
 
-  it('does null', function () {
-    var db = context.db;
-    return db.find({
+  it('does null', async () => {
+    const db = context.db;
+    const res = await db.find({
       selector: {
         'foo': {$type: 'null'}
       },
       fields: ['_id']
-    }).then(function (res) {
-      res.docs.sort(sortById);
-      res.docs.should.deep.equal([{_id: 'c'}]);
     });
+    res.docs.sort(sortById);
+    res.docs.should.deep.equal([{_id: 'c'}]);
   });
 
-  it('does boolean', function () {
-    var db = context.db;
-    return db.find({
+  it('does boolean', async () => {
+    const db = context.db;
+    const res = await db.find({
       selector: {
         'foo': {$type: 'boolean'}
       },
       fields: ['_id']
-    }).then(function (res) {
-      res.docs.sort(sortById);
-      res.docs.should.deep.equal([{_id: 'f'}]);
-
     });
+    res.docs.sort(sortById);
+    res.docs.should.deep.equal([{_id: 'f'}]);
   });
 
-  it('does number', function () {
-    var db = context.db;
-    return db.find({
+  it('does number', async () => {
+    const db = context.db;
+    const res = await db.find({
       selector: {
         'foo': {$type: 'number'}
       },
       fields: ['_id']
-    }).then(function (res) {
-      res.docs.sort(sortById);
-      res.docs.should.deep.equal([{_id: 'b'}]);
     });
+    res.docs.sort(sortById);
+    res.docs.should.deep.equal([{_id: 'b'}]);
   });
 
-  it('does string', function () {
-    var db = context.db;
-    return db.find({
+  it('does string', async () => {
+    const db = context.db;
+    const res = await db.find({
       selector: {
         'foo': {$type: 'string'}
       },
       fields: ['_id']
-    }).then(function (res) {
-      res.docs.sort(sortById);
-      res.docs.should.deep.equal([{_id: 'a'}]);
     });
+    res.docs.sort(sortById);
+    res.docs.should.deep.equal([{_id: 'a'}]);
   });
 
-  it('does array', function () {
-    var db = context.db;
-    return db.find({
+  it('does array', async () => {
+    const db = context.db;
+    const res = await db.find({
       selector: {
         'foo': {$type: 'array'}
       },
       fields: ['_id']
-    }).then(function (res) {
-      res.docs.sort(sortById);
-      res.docs.should.deep.equal([{_id: 'd'}]);
     });
+    res.docs.sort(sortById);
+    res.docs.should.deep.equal([{_id: 'd'}]);
   });
 
-  it('does object', function () {
-    var db = context.db;
-    return db.find({
+  it('does object', async () => {
+    const db = context.db;
+    const res = await db.find({
       selector: {
         'foo': {$type: 'object'}
       },
       fields: ['_id']
-    }).then(function (res) {
-      res.docs.sort(sortById);
-      res.docs.should.deep.equal([{_id: 'e'}]);
     });
+    res.docs.sort(sortById);
+    res.docs.should.deep.equal([{_id: 'e'}]);
   });
 
-  it('should error for unsupported query value', function () {
-    var db = context.db;
-    return db.find({
-      selector: {
-        'foo': {$type: 'made-up'}
-      },
-      fields: ['_id']
-    }).catch(function (err) {
+  it('should error for unsupported query value', async () => {
+    const db = context.db;
+    try {
+      await db.find({
+        selector: {
+          'foo': {$type: 'made-up'}
+        },
+        fields: ['_id']
+      });
+      throw new Error('Function should throw');
+    } catch (err) {
       err.message.should.eq('Query operator $type must be a string. Supported values: "null", "boolean", "number", "string", "array", or "object". Received string: made-up');
-    });
+    }
   });
-  it('should error for non-string query value', function () {
-    var db = context.db;
-    return db.find({
-      selector: {
-        'foo': {$type: 0}
-      },
-      fields: ['_id']
-    }).then(function () {
+
+  it('should error for non-string query value', async () => {
+    const db = context.db;
+    try {
+      await db.find({
+        selector: {
+          'foo': {$type: 0}
+        },
+        fields: ['_id']
+      });
       throw new Error('Function should throw');
-    }, function (err) {
+    } catch (err) {
       err.message.should.eq('Query operator $type must be a string. Supported values: "null", "boolean", "number", "string", "array", or "object". Received number: 0');
-    });
+    }
   });
 });