fix: Remove versionChangedWhileOpen i.e. always open IndexedDB with a version number

Author: jcoglan

packages/node_modules/pouchdb-adapter-indexeddb/src/setup.js

@@ -115,9 +115,7 @@ function upgradePouchDbSchema(dbName, db, tx, pouchdbVersion) {
 }
 
 function openDatabase(openDatabases, api, opts, resolve, reject) {
-  const openReq = opts.versionChangedWhileOpen ?
-    indexedDB.open(opts.name) :
-    indexedDB.open(opts.name, createIdbVersion());
+  const openReq = indexedDB.open(opts.name, createIdbVersion());
 
   openReq.onupgradeneeded = function (e) {
     if (e.oldVersion > 0 && e.oldVersion < versionMultiplier) {
@@ -185,23 +183,15 @@ function openDatabase(openDatabases, api, opts, resolve, reject) {
       idb.close();
     };
 
-    // In IndexedDB you can only change the version, and thus the schema, when you are opening the database.
-    // versionChangedWhileOpen means that something else outside of our control has likely updated the version.
-    // One way this could happen is if you open multiple tabs, as the version number changes each time the database is opened.
-    // If we suspect this we close the db and tag it, so that next time it's accessed it reopens the DB with the current version
-    // as opposed to upping the version again
-    // This avoids infinite loops of version updates if you have multiple tabs open
     idb.onversionchange = function () {
       console.log('Database was made stale, closing handle');
-      openDatabases[opts.name].versionChangedWhileOpen = true;
+      delete openDatabases[opts.name];
       idb.close();
     };
 
     idb.onclose = function () {
       console.log('Database was made stale, closing handle');
-      if (opts.name in openDatabases) {
-        openDatabases[opts.name].versionChangedWhileOpen = true;
-      }
+      delete openDatabases[opts.name];
     };
 
     let metadata = {id: META_LOCAL_STORE};
@@ -257,10 +247,7 @@ function openDatabase(openDatabases, api, opts, resolve, reject) {
 }
 
 export default function (openDatabases, api, opts) {
-  if (!openDatabases[opts.name] || openDatabases[opts.name].versionChangedWhileOpen) {
-    opts.versionChangedWhileOpen = openDatabases[opts.name] &&
-                          openDatabases[opts.name].versionChangedWhileOpen;
-
+  if (!openDatabases[opts.name]) {
     openDatabases[opts.name] = new Promise(function (resolve, reject) {
       openDatabase(openDatabases, api, opts, resolve, reject);
     });