DataFusion 52 migration

comphead · comphead · commit e639805949a0 · 2026-01-31T08:37:53.000-08:00
diff --git a/native/core/src/execution/expressions/subquery.rs b/native/core/src/execution/expressions/subquery.rs
@@ -67,8 +67,8 @@ impl PhysicalExpr for Subquery {
         self
     }
 
-    fn fmt_sql(&self, _: &mut Formatter<'_>) -> std::fmt::Result {
-        unimplemented!()
+    fn fmt_sql(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
+        Display::fmt(self, f)
     }
 
     fn data_type(&self, _: &Schema) -> datafusion::common::Result<DataType> {
diff --git a/native/spark-expr/src/array_funcs/array_insert.rs b/native/spark-expr/src/array_funcs/array_insert.rs
@@ -96,8 +96,8 @@ impl PhysicalExpr for ArrayInsert {
         self
     }
 
-    fn fmt_sql(&self, _: &mut Formatter<'_>) -> std::fmt::Result {
-        unimplemented!()
+    fn fmt_sql(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
+        Display::fmt(self, f)
     }
 
     fn data_type(&self, input_schema: &Schema) -> DataFusionResult<DataType> {
diff --git a/native/spark-expr/src/array_funcs/get_array_struct_fields.rs b/native/spark-expr/src/array_funcs/get_array_struct_fields.rs
@@ -132,8 +132,8 @@ impl PhysicalExpr for GetArrayStructFields {
         }
     }
 
-    fn fmt_sql(&self, _: &mut Formatter<'_>) -> std::fmt::Result {
-        unimplemented!()
+    fn fmt_sql(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
+        Display::fmt(self, f)
     }
 }
 
diff --git a/native/spark-expr/src/array_funcs/list_extract.rs b/native/spark-expr/src/array_funcs/list_extract.rs
@@ -91,8 +91,8 @@ impl PhysicalExpr for ListExtract {
         self
     }
 
-    fn fmt_sql(&self, _: &mut Formatter<'_>) -> std::fmt::Result {
-        unimplemented!()
+    fn fmt_sql(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
+        Display::fmt(self, f)
     }
 
     fn data_type(&self, input_schema: &Schema) -> DataFusionResult<DataType> {
diff --git a/native/spark-expr/src/conditional_funcs/if_expr.rs b/native/spark-expr/src/conditional_funcs/if_expr.rs
@@ -22,7 +22,7 @@ use arrow::{
 use datafusion::common::Result;
 use datafusion::logical_expr::ColumnarValue;
 use datafusion::physical_expr::{expressions::CaseExpr, PhysicalExpr};
-use std::fmt::Formatter;
+use std::fmt::{Display, Formatter};
 use std::hash::Hash;
 use std::{any::Any, sync::Arc};
 
@@ -88,8 +88,8 @@ impl PhysicalExpr for IfExpr {
         self
     }
 
-    fn fmt_sql(&self, _: &mut Formatter<'_>) -> std::fmt::Result {
-        unimplemented!()
+    fn fmt_sql(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
+        Display::fmt(self, f)
     }
 
     fn data_type(&self, input_schema: &Schema) -> Result<DataType> {
diff --git a/native/spark-expr/src/datetime_funcs/timestamp_trunc.rs b/native/spark-expr/src/datetime_funcs/timestamp_trunc.rs
@@ -89,8 +89,8 @@ impl PhysicalExpr for TimestampTruncExpr {
         self
     }
 
-    fn fmt_sql(&self, _: &mut Formatter<'_>) -> std::fmt::Result {
-        unimplemented!()
+    fn fmt_sql(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
+        Display::fmt(self, f)
     }
 
     fn data_type(&self, input_schema: &Schema) -> datafusion::common::Result<DataType> {
diff --git a/native/spark-expr/src/json_funcs/from_json.rs b/native/spark-expr/src/json_funcs/from_json.rs
@@ -90,8 +90,8 @@ impl PhysicalExpr for FromJson {
         self
     }
 
-    fn fmt_sql(&self, _: &mut Formatter<'_>) -> std::fmt::Result {
-        unimplemented!()
+    fn fmt_sql(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
+        Display::fmt(self, f)
     }
 
     fn data_type(&self, _: &Schema) -> Result<DataType> {
diff --git a/native/spark-expr/src/json_funcs/to_json.rs b/native/spark-expr/src/json_funcs/to_json.rs
@@ -83,8 +83,8 @@ impl PhysicalExpr for ToJson {
         self
     }
 
-    fn fmt_sql(&self, _: &mut Formatter<'_>) -> std::fmt::Result {
-        unimplemented!()
+    fn fmt_sql(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
+        Display::fmt(self, f)
     }
 
     fn data_type(&self, _: &Schema) -> Result<DataType> {
diff --git a/native/spark-expr/src/math_funcs/internal/checkoverflow.rs b/native/spark-expr/src/math_funcs/internal/checkoverflow.rs
@@ -83,8 +83,8 @@ impl PhysicalExpr for CheckOverflow {
         self
     }
 
-    fn fmt_sql(&self, _: &mut Formatter<'_>) -> std::fmt::Result {
-        unimplemented!()
+    fn fmt_sql(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
+        Display::fmt(self, f)
     }
 
     fn data_type(&self, _: &Schema) -> datafusion::common::Result<DataType> {
diff --git a/native/spark-expr/src/math_funcs/internal/normalize_nan.rs b/native/spark-expr/src/math_funcs/internal/normalize_nan.rs
@@ -61,8 +61,8 @@ impl PhysicalExpr for NormalizeNaNAndZero {
         self
     }
 
-    fn fmt_sql(&self, _: &mut Formatter<'_>) -> std::fmt::Result {
-        unimplemented!()
+    fn fmt_sql(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
+        Display::fmt(self, f)
     }
 
     fn data_type(&self, input_schema: &Schema) -> datafusion::common::Result<DataType> {
diff --git a/native/spark-expr/src/math_funcs/negative.rs b/native/spark-expr/src/math_funcs/negative.rs
@@ -27,7 +27,7 @@ use datafusion::{
     logical_expr::{interval_arithmetic::Interval, ColumnarValue},
     physical_expr::PhysicalExpr,
 };
-use std::fmt::Formatter;
+use std::fmt::{Display, Formatter};
 use std::hash::Hash;
 use std::{any::Any, sync::Arc};
 
@@ -260,7 +260,7 @@ impl PhysicalExpr for NegativeExpr {
         Ok(properties)
     }
 
-    fn fmt_sql(&self, _: &mut Formatter<'_>) -> std::fmt::Result {
-        unimplemented!()
+    fn fmt_sql(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
+        Display::fmt(self, f)
     }
 }
diff --git a/native/spark-expr/src/nondetermenistic_funcs/monotonically_increasing_id.rs b/native/spark-expr/src/nondetermenistic_funcs/monotonically_increasing_id.rs
@@ -90,8 +90,8 @@ impl PhysicalExpr for MonotonicallyIncreasingId {
         Ok(self)
     }
 
-    fn fmt_sql(&self, _: &mut Formatter<'_>) -> std::fmt::Result {
-        unimplemented!()
+    fn fmt_sql(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
+        Display::fmt(self, f)
     }
 
     fn data_type(&self, _input_schema: &Schema) -> Result<DataType> {
diff --git a/native/spark-expr/src/nondetermenistic_funcs/rand.rs b/native/spark-expr/src/nondetermenistic_funcs/rand.rs
@@ -144,8 +144,8 @@ impl PhysicalExpr for RandExpr {
         vec![]
     }
 
-    fn fmt_sql(&self, _: &mut Formatter<'_>) -> std::fmt::Result {
-        unimplemented!()
+    fn fmt_sql(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
+        Display::fmt(self, f)
     }
 
     fn with_new_children(
diff --git a/native/spark-expr/src/nondetermenistic_funcs/randn.rs b/native/spark-expr/src/nondetermenistic_funcs/randn.rs
@@ -155,8 +155,8 @@ impl PhysicalExpr for RandnExpr {
         vec![]
     }
 
-    fn fmt_sql(&self, _: &mut Formatter<'_>) -> std::fmt::Result {
-        unimplemented!()
+    fn fmt_sql(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
+        Display::fmt(self, f)
     }
 
     fn with_new_children(
diff --git a/native/spark-expr/src/predicate_funcs/rlike.rs b/native/spark-expr/src/predicate_funcs/rlike.rs
@@ -161,7 +161,7 @@ impl PhysicalExpr for RLike {
         )?))
     }
 
-    fn fmt_sql(&self, _: &mut Formatter<'_>) -> std::fmt::Result {
-        unimplemented!()
+    fn fmt_sql(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
+        Display::fmt(self, f)
     }
 }
diff --git a/native/spark-expr/src/string_funcs/substring.rs b/native/spark-expr/src/string_funcs/substring.rs
@@ -72,8 +72,8 @@ impl PhysicalExpr for SubstringExpr {
         self
     }
 
-    fn fmt_sql(&self, _: &mut Formatter<'_>) -> std::fmt::Result {
-        unimplemented!()
+    fn fmt_sql(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
+        Display::fmt(self, f)
     }
 
     fn data_type(&self, input_schema: &Schema) -> datafusion::common::Result<DataType> {
diff --git a/native/spark-expr/src/struct_funcs/create_named_struct.rs b/native/spark-expr/src/struct_funcs/create_named_struct.rs
@@ -57,8 +57,8 @@ impl PhysicalExpr for CreateNamedStruct {
         self
     }
 
-    fn fmt_sql(&self, _: &mut Formatter<'_>) -> std::fmt::Result {
-        unimplemented!()
+    fn fmt_sql(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
+        Display::fmt(self, f)
     }
 
     fn data_type(&self, input_schema: &Schema) -> DataFusionResult<DataType> {

Original file line number	Diff line number	Diff line change
`@@ -67,8 +67,8 @@ impl PhysicalExpr for Subquery {`
`67`	`67`	`self`
`68`	`68`	`}`
`69`	`69`
`70`		`- fn fmt_sql(&self, _: &mut Formatter<'_>) -> std::fmt::Result {`
`71`		`- unimplemented!()`
	`70`	`+ fn fmt_sql(&self, f: &mut Formatter<'_>) -> std::fmt::Result {`
	`71`	`+ Display::fmt(self, f)`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`fn data_type(&self, _: &Schema) -> datafusion::common::Result<DataType> {`
Original file line number	Diff line number	Diff line change
`@@ -96,8 +96,8 @@ impl PhysicalExpr for ArrayInsert {`
`96`	`96`	`self`
`97`	`97`	`}`
`98`	`98`
`99`		`- fn fmt_sql(&self, _: &mut Formatter<'_>) -> std::fmt::Result {`
`100`		`- unimplemented!()`
	`99`	`+ fn fmt_sql(&self, f: &mut Formatter<'_>) -> std::fmt::Result {`
	`100`	`+ Display::fmt(self, f)`
`101`	`101`	`}`
`102`	`102`
`103`	`103`	`fn data_type(&self, input_schema: &Schema) -> DataFusionResult<DataType> {`
Original file line number	Diff line number	Diff line change
`@@ -132,8 +132,8 @@ impl PhysicalExpr for GetArrayStructFields {`
`132`	`132`	`}`
`133`	`133`	`}`
`134`	`134`
`135`		`- fn fmt_sql(&self, _: &mut Formatter<'_>) -> std::fmt::Result {`
`136`		`- unimplemented!()`
	`135`	`+ fn fmt_sql(&self, f: &mut Formatter<'_>) -> std::fmt::Result {`
	`136`	`+ Display::fmt(self, f)`
`137`	`137`	`}`
`138`	`138`	`}`
`139`	`139`
Original file line number	Diff line number	Diff line change
`@@ -91,8 +91,8 @@ impl PhysicalExpr for ListExtract {`
`91`	`91`	`self`
`92`	`92`	`}`
`93`	`93`
`94`		`- fn fmt_sql(&self, _: &mut Formatter<'_>) -> std::fmt::Result {`
`95`		`- unimplemented!()`
	`94`	`+ fn fmt_sql(&self, f: &mut Formatter<'_>) -> std::fmt::Result {`
	`95`	`+ Display::fmt(self, f)`
`96`	`96`	`}`
`97`	`97`
`98`	`98`	`fn data_type(&self, input_schema: &Schema) -> DataFusionResult<DataType> {`
Original file line number	Diff line number	Diff line change
`@@ -89,8 +89,8 @@ impl PhysicalExpr for TimestampTruncExpr {`
`89`	`89`	`self`
`90`	`90`	`}`
`91`	`91`
`92`		`- fn fmt_sql(&self, _: &mut Formatter<'_>) -> std::fmt::Result {`
`93`		`- unimplemented!()`
	`92`	`+ fn fmt_sql(&self, f: &mut Formatter<'_>) -> std::fmt::Result {`
	`93`	`+ Display::fmt(self, f)`
`94`	`94`	`}`
`95`	`95`
`96`	`96`	`fn data_type(&self, input_schema: &Schema) -> datafusion::common::Result<DataType> {`
Original file line number	Diff line number	Diff line change
`@@ -90,8 +90,8 @@ impl PhysicalExpr for FromJson {`
`90`	`90`	`self`
`91`	`91`	`}`
`92`	`92`
`93`		`- fn fmt_sql(&self, _: &mut Formatter<'_>) -> std::fmt::Result {`
`94`		`- unimplemented!()`
	`93`	`+ fn fmt_sql(&self, f: &mut Formatter<'_>) -> std::fmt::Result {`
	`94`	`+ Display::fmt(self, f)`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`fn data_type(&self, _: &Schema) -> Result<DataType> {`
Original file line number	Diff line number	Diff line change
`@@ -83,8 +83,8 @@ impl PhysicalExpr for ToJson {`
`83`	`83`	`self`
`84`	`84`	`}`
`85`	`85`
`86`		`- fn fmt_sql(&self, _: &mut Formatter<'_>) -> std::fmt::Result {`
`87`		`- unimplemented!()`
	`86`	`+ fn fmt_sql(&self, f: &mut Formatter<'_>) -> std::fmt::Result {`
	`87`	`+ Display::fmt(self, f)`
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`fn data_type(&self, _: &Schema) -> Result<DataType> {`
Original file line number	Diff line number	Diff line change
`@@ -61,8 +61,8 @@ impl PhysicalExpr for NormalizeNaNAndZero {`
`61`	`61`	`self`
`62`	`62`	`}`
`63`	`63`
`64`		`- fn fmt_sql(&self, _: &mut Formatter<'_>) -> std::fmt::Result {`
`65`		`- unimplemented!()`
	`64`	`+ fn fmt_sql(&self, f: &mut Formatter<'_>) -> std::fmt::Result {`
	`65`	`+ Display::fmt(self, f)`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`fn data_type(&self, input_schema: &Schema) -> datafusion::common::Result<DataType> {`