fix_incorrect_compatiblity_msg_comet_sum

Author: coderfender

spark/src/main/scala/org/apache/comet/serde/aggregates.scala

@@ -204,7 +204,7 @@ object CometAverage extends CometAggregateExpressionSerde[Average] {
 }
 
 object CometSum extends CometAggregateExpressionSerde[Sum] {
-  
+
   override def convert(
       aggExpr: AggregateExpression,
       sum: Sum,

spark/src/main/scala/org/apache/comet/serde/strings.scala

@@ -33,7 +33,7 @@ import org.apache.comet.serde.QueryPlanSerde.{createBinaryExpr, exprToProtoInter
 
 object CometStringRepeat extends CometExpressionSerde[StringRepeat] {
 
-  override def getCompatibleNotes(): Seq[String] = Seq(
+  override def getIncompatibleReasons(): Seq[String] = Seq(
     "A negative argument for the number of times to repeat throws an exception" +
       " instead of returning an empty string as Spark does")
 
@@ -42,13 +42,27 @@ object CometStringRepeat extends CometExpressionSerde[StringRepeat] {
       inputs: Seq[Attribute],
       binding: Boolean): Option[ExprOuterClass.Expr] = {
     val children = expr.children
+
+    children(1) match {
+      case Literal(count, _) if isNegativeNumber(count) =>
+        withInfo(expr, "Negative repeat count is not supported")
+        return None
+      case _ =>
+    }
+
     val leftCast = Cast(children(0), StringType)
     val rightCast = Cast(children(1), LongType)
     val leftExpr = exprToProtoInternal(leftCast, inputs, binding)
     val rightExpr = exprToProtoInternal(rightCast, inputs, binding)
     val optExpr = scalarFunctionExprToProto("repeat", leftExpr, rightExpr)
     optExprWithInfo(optExpr, expr, leftCast, rightCast)
   }
+
+  private def isNegativeNumber(value: Any): Boolean = value match {
+    case i: Int => i < 0
+    case l: Long => l < 0
+    case _ => false
+  }
 }
 
 class CometCaseConversionBase[T <: Expression](function: String)

spark/src/main/scala/org/apache/comet/serde/unixtime.scala

@@ -29,12 +29,20 @@ import org.apache.comet.serde.QueryPlanSerde.{exprToProtoInternal, optExprWithIn
 // https://github.com/apache/datafusion/issues/16594
 object CometFromUnixTime extends CometExpressionSerde[FromUnixTime] {
 
+  override def getUnsupportedReasons(): Seq[String] = Seq(
+    "Only supports the default datetime format pattern `yyyy-MM-dd HH:mm:ss`")
+
   override def getIncompatibleReasons(): Seq[String] = Seq(
-    "Only supports the default datetime format pattern `yyyy-MM-dd HH:mm:ss`." +
-      " DataFusion's valid timestamp range differs from Spark" +
+    "DataFusion's valid timestamp range differs from Spark" +
       " (https://github.com/apache/datafusion/issues/16594)")
 
-  override def getSupportLevel(expr: FromUnixTime): SupportLevel = Incompatible(None)
+  override def getSupportLevel(expr: FromUnixTime): SupportLevel = {
+    if (expr.format == Literal(TimestampFormatter.defaultPattern)) {
+      Incompatible(None)
+    } else {
+      Unsupported(None)
+    }
+  }
 
   override def convert(
       expr: FromUnixTime,