Skip to content

server: optimize account creation by pre-loading the role permissions #11137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
weizhouapache wants to merge 4 commits into from

server: optimize account creation by pre-loading the role permissions

e5848ac
Select commit
Loading
Failed to load commit list.
Refresh
Closed

server: optimize account creation by pre-loading the role permissions #11137

server: optimize account creation by pre-loading the role permissions
e5848ac
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Jul 8, 2025 in 1s

4.65% of diff hit (target 16.15%)

View this Pull Request on Codecov

4.65% of diff hit (target 16.15%)

Annotations

Check warning on line 185 in plugins/acl/dynamic-role-based/src/main/java/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/acl/dynamic-role-based/src/main/java/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java#L185 

Added line #L185 was not covered by tests

Check warning on line 187 in plugins/acl/dynamic-role-based/src/main/java/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/acl/dynamic-role-based/src/main/java/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java#L187 

Added line #L187 was not covered by tests

Check warning on line 192 in plugins/acl/dynamic-role-based/src/main/java/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/acl/dynamic-role-based/src/main/java/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java#L192 

Added line #L192 was not covered by tests

Check warning on line 194 in plugins/acl/dynamic-role-based/src/main/java/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/acl/dynamic-role-based/src/main/java/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java#L194 

Added line #L194 was not covered by tests

Check warning on line 198 in plugins/acl/dynamic-role-based/src/main/java/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/acl/dynamic-role-based/src/main/java/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java#L198 

Added line #L198 was not covered by tests

Check warning on line 201 in plugins/acl/dynamic-role-based/src/main/java/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/acl/dynamic-role-based/src/main/java/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java#L200-L201 

Added lines #L200 - L201 were not covered by tests

Check warning on line 203 in plugins/acl/project-role-based/src/main/java/org/apache/cloudstack/acl/ProjectRoleBasedApiAccessChecker.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/acl/project-role-based/src/main/java/org/apache/cloudstack/acl/ProjectRoleBasedApiAccessChecker.java#L201-L203 

Added lines #L201 - L203 were not covered by tests

Check warning on line 208 in plugins/acl/project-role-based/src/main/java/org/apache/cloudstack/acl/ProjectRoleBasedApiAccessChecker.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/acl/project-role-based/src/main/java/org/apache/cloudstack/acl/ProjectRoleBasedApiAccessChecker.java#L206-L208 

Added lines #L206 - L208 were not covered by tests

Check warning on line 206 in plugins/acl/static-role-based/src/main/java/org/apache/cloudstack/acl/StaticRoleBasedAPIAccessChecker.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/acl/static-role-based/src/main/java/org/apache/cloudstack/acl/StaticRoleBasedAPIAccessChecker.java#L206 

Added line #L206 was not covered by tests

Check warning on line 211 in plugins/acl/static-role-based/src/main/java/org/apache/cloudstack/acl/StaticRoleBasedAPIAccessChecker.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/acl/static-role-based/src/main/java/org/apache/cloudstack/acl/StaticRoleBasedAPIAccessChecker.java#L211 

Added line #L211 was not covered by tests

Check warning on line 265 in plugins/api/rate-limit/src/main/java/org/apache/cloudstack/ratelimit/ApiRateLimitServiceImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/api/rate-limit/src/main/java/org/apache/cloudstack/ratelimit/ApiRateLimitServiceImpl.java#L263-L265 

Added lines #L263 - L265 were not covered by tests

Check warning on line 270 in plugins/api/rate-limit/src/main/java/org/apache/cloudstack/ratelimit/ApiRateLimitServiceImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/api/rate-limit/src/main/java/org/apache/cloudstack/ratelimit/ApiRateLimitServiceImpl.java#L268-L270 

Added lines #L268 - L270 were not covered by tests

Check warning on line 1436 in server/src/main/java/com/cloud/user/AccountManagerImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/user/AccountManagerImpl.java#L1436 

Added line #L1436 was not covered by tests

Check warning on line 1442 in server/src/main/java/com/cloud/user/AccountManagerImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/user/AccountManagerImpl.java#L1440-L1442 

Added lines #L1440 - L1442 were not covered by tests

Check warning on line 1446 in server/src/main/java/com/cloud/user/AccountManagerImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/user/AccountManagerImpl.java#L1444-L1446 

Added lines #L1444 - L1446 were not covered by tests

Check warning on line 1450 in server/src/main/java/com/cloud/user/AccountManagerImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/user/AccountManagerImpl.java#L1450 

Added line #L1450 was not covered by tests

Check warning on line 1452 in server/src/main/java/com/cloud/user/AccountManagerImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/user/AccountManagerImpl.java#L1452 

Added line #L1452 was not covered by tests

Check warning on line 1454 in server/src/main/java/com/cloud/user/AccountManagerImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/user/AccountManagerImpl.java#L1454 

Added line #L1454 was not covered by tests

Check warning on line 1460 in server/src/main/java/com/cloud/user/AccountManagerImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/user/AccountManagerImpl.java#L1460 

Added line #L1460 was not covered by tests

Check warning on line 1462 in server/src/main/java/com/cloud/user/AccountManagerImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/user/AccountManagerImpl.java#L1462 

Added line #L1462 was not covered by tests
View more details on Codecov