Skip to content

Commit afa879a

Browse files
committed
Revert "GH-47402: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_test_emscripten.sh"
This reverts commit 2e4daa4.
1 parent 283a122 commit afa879a

2 files changed

Lines changed: 3 additions & 5 deletions

File tree

.pre-commit-config.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,6 @@ repos:
332332
?^ci/scripts/python_build\.sh$|
333333
?^ci/scripts/python_sdist_build\.sh$|
334334
?^ci/scripts/python_sdist_test\.sh$|
335-
?^ci/scripts/python_test_emscripten\.sh$|
336335
?^ci/scripts/python_wheel_unix_test\.sh$|
337336
?^ci/scripts/python_test_type_annotations\.sh$|
338337
?^ci/scripts/python_test\.sh$|

ci/scripts/python_test_emscripten.sh

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,14 @@ set -ex
2525
build_dir=${1}/python
2626
pyodide_dist_dir=${2}
2727

28-
cd "${build_dir}"
28+
cd ${build_dir}
2929

3030
# note: this uses the newest wheel in dist
31-
# shellcheck disable=SC2012
3231
pyodide_wheel=$(ls -t dist/pyarrow*.whl | head -1)
3332

3433
echo "-------------- Running emscripten tests in Node ----------------------"
35-
python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=node
34+
python scripts/run_emscripten_tests.py ${pyodide_wheel} --dist-dir=${pyodide_dist_dir} --runtime=node
3635

3736
echo "-------------- Running emscripten tests in Chrome --------------------"
38-
python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=chrome
37+
python scripts/run_emscripten_tests.py ${pyodide_wheel} --dist-dir=${pyodide_dist_dir} --runtime=chrome
3938

0 commit comments

Comments
 (0)