refactor(@angular-devkit/core): deprecate stringToFileBuffer and fileBufferToString#33150
Conversation
angular-robot
Bot
added
detected: deprecation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request deprecates the stringToFileBuffer and fileBufferToString utility functions in favor of native TextEncoder and TextDecoder APIs. The changes involve updating numerous test files and builders across the repository to use these native interfaces directly. Feedback was provided regarding the createWorkspaceHost implementation, suggesting that TextEncoder and TextDecoder instances should be reused to avoid redundant allocations during file operations.
…BufferToString DEPRECATED: `stringToFileBuffer` and `fileBufferToString` are deprecated. Use standard Web APIs (`TextEncoder` and `TextDecoder`) instead. Internal usages within the repository have been removed and replaced with standard Web APIs. The public API golden file for `@angular-devkit/core` has been updated to reflect the deprecations.
clydin
force-pushed
the
refactor/deprecate-buffer-helpers
branch
from
747a281 to
0ae5a9c
Compare
clydin
added
the
action: review
alan-agius4
added
action: merge
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
2 participants
DEPRECATED:
stringToFileBufferandfileBufferToStringare deprecated. Use standard Web APIs (TextEncoderandTextDecoder) instead.Internal usages within the repository have been removed and replaced with standard Web APIs. The public API golden file for
@angular-devkit/corehas been updated to reflect the deprecations.