forked from apache/datafusion-comet
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy path1.9.1.diff
More file actions
3299 lines (3189 loc) · 163 KB
/
1.9.1.diff
File metadata and controls
3299 lines (3189 loc) · 163 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
index c50991c5fc..c3bd841c95 100644
--- a/gradle/libs.versions.toml
+++ b/gradle/libs.versions.toml
@@ -36,6 +36,7 @@ awssdk-s3accessgrants = "2.3.0"
bson-ver = "4.11.5"
caffeine = "2.9.3"
calcite = "1.39.0"
+comet = "0.16.0-SNAPSHOT"
datasketches = "6.2.0"
delta-standalone = "3.3.1"
delta-spark = "3.3.1"
diff --git a/spark/v3.4/build.gradle b/spark/v3.4/build.gradle
index 2cd8666892..4077116abb 100644
--- a/spark/v3.4/build.gradle
+++ b/spark/v3.4/build.gradle
@@ -75,7 +75,7 @@ project(":iceberg-spark:iceberg-spark-${sparkMajorVersion}_${scalaVersion}") {
exclude group: 'org.roaringbitmap'
}
- compileOnly "org.apache.datafusion:comet-spark-spark${sparkMajorVersion}_${scalaVersion}:0.5.0"
+ compileOnly "org.apache.datafusion:comet-spark-spark${sparkMajorVersion}_${scalaVersion}:${libs.versions.comet.get()}"
implementation libs.parquet.column
implementation libs.parquet.hadoop
@@ -186,7 +186,7 @@ project(":iceberg-spark:iceberg-spark-extensions-${sparkMajorVersion}_${scalaVer
testImplementation libs.parquet.hadoop
testImplementation libs.awaitility
testImplementation libs.junit.vintage.engine
- testImplementation "org.apache.datafusion:comet-spark-spark${sparkMajorVersion}_${scalaVersion}:0.5.0"
+ testImplementation "org.apache.datafusion:comet-spark-spark${sparkMajorVersion}_${scalaVersion}:${libs.versions.comet.get()}"
// Required because we remove antlr plugin dependencies from the compile configuration, see note above
runtimeOnly libs.antlr.runtime
@@ -267,6 +267,7 @@ project(":iceberg-spark:iceberg-spark-runtime-${sparkMajorVersion}_${scalaVersio
integrationImplementation project(path: ':iceberg-hive-metastore', configuration: 'testArtifacts')
integrationImplementation project(path: ":iceberg-spark:iceberg-spark-${sparkMajorVersion}_${scalaVersion}", configuration: 'testArtifacts')
integrationImplementation project(path: ":iceberg-spark:iceberg-spark-extensions-${sparkMajorVersion}_${scalaVersion}", configuration: 'testArtifacts')
+ integrationImplementation "org.apache.datafusion:comet-spark-spark${sparkMajorVersion}_${scalaVersion}:${libs.versions.comet.get()}"
// runtime dependencies for running Hive Catalog based integration test
integrationRuntimeOnly project(':iceberg-hive-metastore')
diff --git a/spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/ExtensionsTestBase.java b/spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/ExtensionsTestBase.java
index 578845e3da..fd93d91bc3 100644
--- a/spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/ExtensionsTestBase.java
+++ b/spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/ExtensionsTestBase.java
@@ -57,7 +57,27 @@ public abstract class ExtensionsTestBase extends CatalogTestBase {
.config("spark.sql.legacy.respectNullabilityInTextDatasetConversion", "true")
.config(
SQLConf.ADAPTIVE_EXECUTION_ENABLED().key(), String.valueOf(RANDOM.nextBoolean()))
+ .config("spark.plugins", "org.apache.spark.CometPlugin")
+ .config(
+ "spark.shuffle.manager",
+ "org.apache.spark.sql.comet.execution.shuffle.CometShuffleManager")
+ .config("spark.comet.explainFallback.enabled", "true")
+ .config("spark.comet.scan.icebergNative.enabled", "true")
+ .config("spark.memory.offHeap.enabled", "true")
+ .config("spark.memory.offHeap.size", "10g")
+ .config("spark.comet.use.lazyMaterialization", "false")
+ .config("spark.comet.schemaEvolution.enabled", "true")
.enableHiveSupport()
+ .config("spark.plugins", "org.apache.spark.CometPlugin")
+ .config(
+ "spark.shuffle.manager",
+ "org.apache.spark.sql.comet.execution.shuffle.CometShuffleManager")
+ .config("spark.comet.explainFallback.enabled", "true")
+ .config("spark.comet.scan.icebergNative.enabled", "true")
+ .config("spark.memory.offHeap.enabled", "true")
+ .config("spark.memory.offHeap.size", "10g")
+ .config("spark.comet.use.lazyMaterialization", "false")
+ .config("spark.comet.schemaEvolution.enabled", "true")
.getOrCreate();
TestBase.sparkContext = JavaSparkContext.fromSparkContext(spark.sparkContext());
diff --git a/spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestCallStatementParser.java b/spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestCallStatementParser.java
index 58d054bd05..4ead587cc1 100644
--- a/spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestCallStatementParser.java
+++ b/spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestCallStatementParser.java
@@ -56,6 +56,16 @@ public class TestCallStatementParser {
.master("local[2]")
.config("spark.sql.extensions", IcebergSparkSessionExtensions.class.getName())
.config("spark.extra.prop", "value")
+ .config("spark.plugins", "org.apache.spark.CometPlugin")
+ .config(
+ "spark.shuffle.manager",
+ "org.apache.spark.sql.comet.execution.shuffle.CometShuffleManager")
+ .config("spark.comet.explainFallback.enabled", "true")
+ .config("spark.comet.scan.icebergNative.enabled", "true")
+ .config("spark.memory.offHeap.enabled", "true")
+ .config("spark.memory.offHeap.size", "10g")
+ .config("spark.comet.use.lazyMaterialization", "false")
+ .config("spark.comet.schemaEvolution.enabled", "true")
.getOrCreate();
TestCallStatementParser.parser = spark.sessionState().sqlParser();
}
diff --git a/spark/v3.4/spark/src/jmh/java/org/apache/iceberg/spark/action/DeleteOrphanFilesBenchmark.java b/spark/v3.4/spark/src/jmh/java/org/apache/iceberg/spark/action/DeleteOrphanFilesBenchmark.java
index b6ade2bff3..c12127d618 100644
--- a/spark/v3.4/spark/src/jmh/java/org/apache/iceberg/spark/action/DeleteOrphanFilesBenchmark.java
+++ b/spark/v3.4/spark/src/jmh/java/org/apache/iceberg/spark/action/DeleteOrphanFilesBenchmark.java
@@ -170,6 +170,16 @@ public class DeleteOrphanFilesBenchmark {
.config("spark.sql.catalog.spark_catalog", SparkSessionCatalog.class.getName())
.config("spark.sql.catalog.spark_catalog.type", "hadoop")
.config("spark.sql.catalog.spark_catalog.warehouse", catalogWarehouse())
+ .config("spark.plugins", "org.apache.spark.CometPlugin")
+ .config(
+ "spark.shuffle.manager",
+ "org.apache.spark.sql.comet.execution.shuffle.CometShuffleManager")
+ .config("spark.comet.explainFallback.enabled", "true")
+ .config("spark.comet.scan.icebergNative.enabled", "true")
+ .config("spark.memory.offHeap.enabled", "true")
+ .config("spark.memory.offHeap.size", "10g")
+ .config("spark.comet.use.lazyMaterialization", "false")
+ .config("spark.comet.schemaEvolution.enabled", "true")
.master("local");
spark = builder.getOrCreate();
}
diff --git a/spark/v3.4/spark/src/jmh/java/org/apache/iceberg/spark/action/IcebergSortCompactionBenchmark.java b/spark/v3.4/spark/src/jmh/java/org/apache/iceberg/spark/action/IcebergSortCompactionBenchmark.java
index b08c352819..4ffee26156 100644
--- a/spark/v3.4/spark/src/jmh/java/org/apache/iceberg/spark/action/IcebergSortCompactionBenchmark.java
+++ b/spark/v3.4/spark/src/jmh/java/org/apache/iceberg/spark/action/IcebergSortCompactionBenchmark.java
@@ -386,6 +386,16 @@ public class IcebergSortCompactionBenchmark {
"spark.sql.catalog.spark_catalog", "org.apache.iceberg.spark.SparkSessionCatalog")
.config("spark.sql.catalog.spark_catalog.type", "hadoop")
.config("spark.sql.catalog.spark_catalog.warehouse", getCatalogWarehouse())
+ .config("spark.plugins", "org.apache.spark.CometPlugin")
+ .config(
+ "spark.shuffle.manager",
+ "org.apache.spark.sql.comet.execution.shuffle.CometShuffleManager")
+ .config("spark.comet.explainFallback.enabled", "true")
+ .config("spark.comet.scan.icebergNative.enabled", "true")
+ .config("spark.memory.offHeap.enabled", "true")
+ .config("spark.memory.offHeap.size", "10g")
+ .config("spark.comet.use.lazyMaterialization", "false")
+ .config("spark.comet.schemaEvolution.enabled", "true")
.master("local[*]");
spark = builder.getOrCreate();
Configuration sparkHadoopConf = spark.sessionState().newHadoopConf();
diff --git a/spark/v3.4/spark/src/jmh/java/org/apache/iceberg/spark/source/IcebergSourceBenchmark.java b/spark/v3.4/spark/src/jmh/java/org/apache/iceberg/spark/source/IcebergSourceBenchmark.java
index 68c537e34a..1e9e90d539 100644
--- a/spark/v3.4/spark/src/jmh/java/org/apache/iceberg/spark/source/IcebergSourceBenchmark.java
+++ b/spark/v3.4/spark/src/jmh/java/org/apache/iceberg/spark/source/IcebergSourceBenchmark.java
@@ -94,7 +94,19 @@ public abstract class IcebergSourceBenchmark {
}
protected void setupSpark(boolean enableDictionaryEncoding) {
- SparkSession.Builder builder = SparkSession.builder().config("spark.ui.enabled", false);
+ SparkSession.Builder builder =
+ SparkSession.builder()
+ .config("spark.ui.enabled", false)
+ .config("spark.plugins", "org.apache.spark.CometPlugin")
+ .config(
+ "spark.shuffle.manager",
+ "org.apache.spark.sql.comet.execution.shuffle.CometShuffleManager")
+ .config("spark.comet.explainFallback.enabled", "true")
+ .config("spark.comet.scan.icebergNative.enabled", "true")
+ .config("spark.memory.offHeap.enabled", "true")
+ .config("spark.memory.offHeap.size", "10g")
+ .config("spark.comet.use.lazyMaterialization", "false")
+ .config("spark.comet.schemaEvolution.enabled", "true");
if (!enableDictionaryEncoding) {
builder
.config("parquet.dictionary.page.size", "1")
diff --git a/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometColumnReader.java b/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometColumnReader.java
deleted file mode 100644
index 16159dcbdf..0000000000
--- a/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometColumnReader.java
+++ /dev/null
@@ -1,140 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-package org.apache.iceberg.spark.data.vectorized;
-
-import java.io.IOException;
-import org.apache.comet.parquet.AbstractColumnReader;
-import org.apache.comet.parquet.ColumnReader;
-import org.apache.comet.parquet.TypeUtil;
-import org.apache.comet.parquet.Utils;
-import org.apache.comet.shaded.arrow.c.CometSchemaImporter;
-import org.apache.comet.shaded.arrow.memory.RootAllocator;
-import org.apache.iceberg.parquet.VectorizedReader;
-import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
-import org.apache.iceberg.spark.SparkSchemaUtil;
-import org.apache.iceberg.types.Types;
-import org.apache.parquet.column.ColumnDescriptor;
-import org.apache.parquet.column.page.PageReader;
-import org.apache.spark.sql.types.DataType;
-import org.apache.spark.sql.types.Metadata;
-import org.apache.spark.sql.types.StructField;
-import org.apache.spark.sql.vectorized.ColumnVector;
-
-class CometColumnReader implements VectorizedReader<ColumnVector> {
- // use the Comet default batch size
- public static final int DEFAULT_BATCH_SIZE = 8192;
-
- private final ColumnDescriptor descriptor;
- private final DataType sparkType;
-
- // The delegated ColumnReader from Comet side
- private AbstractColumnReader delegate;
- private boolean initialized = false;
- private int batchSize = DEFAULT_BATCH_SIZE;
- private CometSchemaImporter importer;
-
- CometColumnReader(DataType sparkType, ColumnDescriptor descriptor) {
- this.sparkType = sparkType;
- this.descriptor = descriptor;
- }
-
- CometColumnReader(Types.NestedField field) {
- DataType dataType = SparkSchemaUtil.convert(field.type());
- StructField structField = new StructField(field.name(), dataType, false, Metadata.empty());
- this.sparkType = dataType;
- this.descriptor = TypeUtil.convertToParquet(structField);
- }
-
- public AbstractColumnReader delegate() {
- return delegate;
- }
-
- void setDelegate(AbstractColumnReader delegate) {
- this.delegate = delegate;
- }
-
- void setInitialized(boolean initialized) {
- this.initialized = initialized;
- }
-
- public int batchSize() {
- return batchSize;
- }
-
- /**
- * This method is to initialized/reset the CometColumnReader. This needs to be called for each row
- * group after readNextRowGroup, so a new dictionary encoding can be set for each of the new row
- * groups.
- */
- public void reset() {
- if (importer != null) {
- importer.close();
- }
-
- if (delegate != null) {
- delegate.close();
- }
-
- this.importer = new CometSchemaImporter(new RootAllocator());
- this.delegate = Utils.getColumnReader(sparkType, descriptor, importer, batchSize, false, false);
- this.initialized = true;
- }
-
- public ColumnDescriptor descriptor() {
- return descriptor;
- }
-
- /** Returns the Spark data type for this column. */
- public DataType sparkType() {
- return sparkType;
- }
-
- /**
- * Set the page reader to be 'pageReader'.
- *
- * <p>NOTE: this should be called before reading a new Parquet column chunk, and after {@link
- * CometColumnReader#reset} is called.
- */
- public void setPageReader(PageReader pageReader) throws IOException {
- Preconditions.checkState(initialized, "Invalid state: 'reset' should be called first");
- ((ColumnReader) delegate).setPageReader(pageReader);
- }
-
- @Override
- public void close() {
- // close resources on native side
- if (importer != null) {
- importer.close();
- }
-
- if (delegate != null) {
- delegate.close();
- }
- }
-
- @Override
- public void setBatchSize(int size) {
- this.batchSize = size;
- }
-
- @Override
- public ColumnVector read(ColumnVector reuse, int numRowsToRead) {
- throw new UnsupportedOperationException("Not supported");
- }
-}
diff --git a/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometColumnarBatchReader.java b/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometColumnarBatchReader.java
deleted file mode 100644
index 04ac69476a..0000000000
--- a/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometColumnarBatchReader.java
+++ /dev/null
@@ -1,197 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-package org.apache.iceberg.spark.data.vectorized;
-
-import java.io.IOException;
-import java.io.UncheckedIOException;
-import java.util.List;
-import java.util.Map;
-import org.apache.comet.parquet.AbstractColumnReader;
-import org.apache.comet.parquet.BatchReader;
-import org.apache.iceberg.Schema;
-import org.apache.iceberg.data.DeleteFilter;
-import org.apache.iceberg.parquet.VectorizedReader;
-import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
-import org.apache.iceberg.spark.SparkSchemaUtil;
-import org.apache.iceberg.util.Pair;
-import org.apache.parquet.column.page.PageReadStore;
-import org.apache.parquet.hadoop.metadata.ColumnChunkMetaData;
-import org.apache.parquet.hadoop.metadata.ColumnPath;
-import org.apache.spark.sql.catalyst.InternalRow;
-import org.apache.spark.sql.vectorized.ColumnVector;
-import org.apache.spark.sql.vectorized.ColumnarBatch;
-
-/**
- * {@link VectorizedReader} that returns Spark's {@link ColumnarBatch} to support Spark's vectorized
- * read path. The {@link ColumnarBatch} returned is created by passing in the Arrow vectors
- * populated via delegated read calls to {@link CometColumnReader VectorReader(s)}.
- */
-@SuppressWarnings("checkstyle:VisibilityModifier")
-class CometColumnarBatchReader implements VectorizedReader<ColumnarBatch> {
-
- private final CometColumnReader[] readers;
- private final boolean hasIsDeletedColumn;
-
- // The delegated BatchReader on the Comet side does the real work of loading a batch of rows.
- // The Comet BatchReader contains an array of ColumnReader. There is no need to explicitly call
- // ColumnReader.readBatch; instead, BatchReader.nextBatch will be called, which underneath calls
- // ColumnReader.readBatch. The only exception is DeleteColumnReader, because at the time of
- // calling BatchReader.nextBatch, the isDeleted value is not yet available, so
- // DeleteColumnReader.readBatch must be called explicitly later, after the isDeleted value is
- // available.
- private final BatchReader delegate;
- private DeleteFilter<InternalRow> deletes = null;
- private long rowStartPosInBatch = 0;
-
- CometColumnarBatchReader(List<VectorizedReader<?>> readers, Schema schema) {
- this.readers =
- readers.stream().map(CometColumnReader.class::cast).toArray(CometColumnReader[]::new);
- this.hasIsDeletedColumn =
- readers.stream().anyMatch(reader -> reader instanceof CometDeleteColumnReader);
-
- AbstractColumnReader[] abstractColumnReaders = new AbstractColumnReader[readers.size()];
- this.delegate = new BatchReader(abstractColumnReaders);
- delegate.setSparkSchema(SparkSchemaUtil.convert(schema));
- }
-
- @Override
- public void setRowGroupInfo(
- PageReadStore pageStore, Map<ColumnPath, ColumnChunkMetaData> metaData) {
- for (int i = 0; i < readers.length; i++) {
- try {
- if (!(readers[i] instanceof CometConstantColumnReader)
- && !(readers[i] instanceof CometPositionColumnReader)
- && !(readers[i] instanceof CometDeleteColumnReader)) {
- readers[i].reset();
- readers[i].setPageReader(pageStore.getPageReader(readers[i].descriptor()));
- }
- } catch (IOException e) {
- throw new UncheckedIOException("Failed to setRowGroupInfo for Comet vectorization", e);
- }
- }
-
- for (int i = 0; i < readers.length; i++) {
- delegate.getColumnReaders()[i] = this.readers[i].delegate();
- }
-
- this.rowStartPosInBatch =
- pageStore
- .getRowIndexOffset()
- .orElseThrow(
- () ->
- new IllegalArgumentException(
- "PageReadStore does not contain row index offset"));
- }
-
- public void setDeleteFilter(DeleteFilter<InternalRow> deleteFilter) {
- this.deletes = deleteFilter;
- }
-
- @Override
- public final ColumnarBatch read(ColumnarBatch reuse, int numRowsToRead) {
- ColumnarBatch columnarBatch = new ColumnBatchLoader(numRowsToRead).loadDataToColumnBatch();
- rowStartPosInBatch += numRowsToRead;
- return columnarBatch;
- }
-
- @Override
- public void setBatchSize(int batchSize) {
- for (CometColumnReader reader : readers) {
- if (reader != null) {
- reader.setBatchSize(batchSize);
- }
- }
- }
-
- @Override
- public void close() {
- for (CometColumnReader reader : readers) {
- if (reader != null) {
- reader.close();
- }
- }
- }
-
- private class ColumnBatchLoader {
- private final int batchSize;
-
- ColumnBatchLoader(int numRowsToRead) {
- Preconditions.checkArgument(
- numRowsToRead > 0, "Invalid number of rows to read: %s", numRowsToRead);
- this.batchSize = numRowsToRead;
- }
-
- ColumnarBatch loadDataToColumnBatch() {
- ColumnVector[] vectors = readDataToColumnVectors();
- int numLiveRows = batchSize;
-
- if (hasIsDeletedColumn) {
- boolean[] isDeleted = buildIsDeleted(vectors);
- readDeletedColumn(vectors, isDeleted);
- } else {
- Pair<int[], Integer> pair = buildRowIdMapping(vectors);
- if (pair != null) {
- int[] rowIdMapping = pair.first();
- numLiveRows = pair.second();
- for (int i = 0; i < vectors.length; i++) {
- vectors[i] = new ColumnVectorWithFilter(vectors[i], rowIdMapping);
- }
- }
- }
-
- if (deletes != null && deletes.hasEqDeletes()) {
- vectors = ColumnarBatchUtil.removeExtraColumns(deletes, vectors);
- }
-
- ColumnarBatch batch = new ColumnarBatch(vectors);
- batch.setNumRows(numLiveRows);
- return batch;
- }
-
- private boolean[] buildIsDeleted(ColumnVector[] vectors) {
- return ColumnarBatchUtil.buildIsDeleted(vectors, deletes, rowStartPosInBatch, batchSize);
- }
-
- private Pair<int[], Integer> buildRowIdMapping(ColumnVector[] vectors) {
- return ColumnarBatchUtil.buildRowIdMapping(vectors, deletes, rowStartPosInBatch, batchSize);
- }
-
- ColumnVector[] readDataToColumnVectors() {
- ColumnVector[] columnVectors = new ColumnVector[readers.length];
- // Fetch rows for all readers in the delegate
- delegate.nextBatch(batchSize);
- for (int i = 0; i < readers.length; i++) {
- columnVectors[i] = readers[i].delegate().currentBatch();
- }
-
- return columnVectors;
- }
-
- void readDeletedColumn(ColumnVector[] columnVectors, boolean[] isDeleted) {
- for (int i = 0; i < readers.length; i++) {
- if (readers[i] instanceof CometDeleteColumnReader) {
- CometDeleteColumnReader deleteColumnReader = new CometDeleteColumnReader<>(isDeleted);
- deleteColumnReader.setBatchSize(batchSize);
- deleteColumnReader.delegate().readBatch(batchSize);
- columnVectors[i] = deleteColumnReader.delegate().currentBatch();
- }
- }
- }
- }
-}
diff --git a/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometConstantColumnReader.java b/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometConstantColumnReader.java
deleted file mode 100644
index c665002e8f..0000000000
--- a/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometConstantColumnReader.java
+++ /dev/null
@@ -1,65 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-package org.apache.iceberg.spark.data.vectorized;
-
-import java.math.BigDecimal;
-import java.nio.ByteBuffer;
-import org.apache.comet.parquet.ConstantColumnReader;
-import org.apache.iceberg.types.Types;
-import org.apache.spark.sql.types.DataType;
-import org.apache.spark.sql.types.DataTypes;
-import org.apache.spark.sql.types.Decimal;
-import org.apache.spark.sql.types.DecimalType;
-import org.apache.spark.unsafe.types.UTF8String;
-
-class CometConstantColumnReader<T> extends CometColumnReader {
-
- CometConstantColumnReader(T value, Types.NestedField field) {
- super(field);
- // use delegate to set constant value on the native side to be consumed by native execution.
- setDelegate(
- new ConstantColumnReader(sparkType(), descriptor(), convertToSparkValue(value), false));
- }
-
- @Override
- public void setBatchSize(int batchSize) {
- super.setBatchSize(batchSize);
- delegate().setBatchSize(batchSize);
- setInitialized(true);
- }
-
- private Object convertToSparkValue(T value) {
- DataType dataType = sparkType();
- // Match the value to Spark internal type if necessary
- if (dataType == DataTypes.StringType && value instanceof String) {
- // the internal type for StringType is UTF8String
- return UTF8String.fromString((String) value);
- } else if (dataType instanceof DecimalType && value instanceof BigDecimal) {
- // the internal type for DecimalType is Decimal
- return Decimal.apply((BigDecimal) value);
- } else if (dataType == DataTypes.BinaryType && value instanceof ByteBuffer) {
- // the internal type for DecimalType is byte[]
- // Iceberg default value should always use HeapBufferBuffer, so calling ByteBuffer.array()
- // should be safe.
- return ((java.nio.ByteBuffer) value).array();
- } else {
- return value;
- }
- }
-}
diff --git a/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometDeleteColumnReader.java b/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometDeleteColumnReader.java
deleted file mode 100644
index 4a28fc51da..0000000000
--- a/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometDeleteColumnReader.java
+++ /dev/null
@@ -1,75 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-package org.apache.iceberg.spark.data.vectorized;
-
-import org.apache.comet.parquet.MetadataColumnReader;
-import org.apache.comet.parquet.Native;
-import org.apache.comet.parquet.TypeUtil;
-import org.apache.iceberg.MetadataColumns;
-import org.apache.iceberg.types.Types;
-import org.apache.spark.sql.types.DataTypes;
-import org.apache.spark.sql.types.Metadata;
-import org.apache.spark.sql.types.StructField;
-
-class CometDeleteColumnReader<T> extends CometColumnReader {
- CometDeleteColumnReader(Types.NestedField field) {
- super(field);
- setDelegate(new DeleteColumnReader());
- }
-
- CometDeleteColumnReader(boolean[] isDeleted) {
- super(MetadataColumns.IS_DELETED);
- setDelegate(new DeleteColumnReader(isDeleted));
- }
-
- @Override
- public void setBatchSize(int batchSize) {
- super.setBatchSize(batchSize);
- delegate().setBatchSize(batchSize);
- setInitialized(true);
- }
-
- private static class DeleteColumnReader extends MetadataColumnReader {
- private boolean[] isDeleted;
-
- DeleteColumnReader() {
- super(
- DataTypes.BooleanType,
- TypeUtil.convertToParquet(
- new StructField("_deleted", DataTypes.BooleanType, false, Metadata.empty())),
- false /* useDecimal128 = false */,
- false /* isConstant */);
- this.isDeleted = new boolean[0];
- }
-
- DeleteColumnReader(boolean[] isDeleted) {
- this();
- this.isDeleted = isDeleted;
- }
-
- @Override
- public void readBatch(int total) {
- Native.resetBatch(nativeHandle);
- // set isDeleted on the native side to be consumed by native execution
- Native.setIsDeleted(nativeHandle, isDeleted);
-
- super.readBatch(total);
- }
- }
-}
diff --git a/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometPositionColumnReader.java b/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometPositionColumnReader.java
deleted file mode 100644
index 1949a71798..0000000000
--- a/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometPositionColumnReader.java
+++ /dev/null
@@ -1,62 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-package org.apache.iceberg.spark.data.vectorized;
-
-import org.apache.comet.parquet.MetadataColumnReader;
-import org.apache.comet.parquet.Native;
-import org.apache.iceberg.types.Types;
-import org.apache.parquet.column.ColumnDescriptor;
-import org.apache.spark.sql.types.DataTypes;
-
-class CometPositionColumnReader extends CometColumnReader {
- CometPositionColumnReader(Types.NestedField field) {
- super(field);
- setDelegate(new PositionColumnReader(descriptor()));
- }
-
- @Override
- public void setBatchSize(int batchSize) {
- super.setBatchSize(batchSize);
- delegate().setBatchSize(batchSize);
- setInitialized(true);
- }
-
- private static class PositionColumnReader extends MetadataColumnReader {
- /** The current position value of the column that are used to initialize this column reader. */
- private long position;
-
- PositionColumnReader(ColumnDescriptor descriptor) {
- super(
- DataTypes.LongType,
- descriptor,
- false /* useDecimal128 = false */,
- false /* isConstant */);
- }
-
- @Override
- public void readBatch(int total) {
- Native.resetBatch(nativeHandle);
- // set position on the native side to be consumed by native execution
- Native.setPosition(nativeHandle, position, total);
- position += total;
-
- super.readBatch(total);
- }
- }
-}
diff --git a/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometVectorizedReaderBuilder.java b/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometVectorizedReaderBuilder.java
deleted file mode 100644
index d36f1a7274..0000000000
--- a/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometVectorizedReaderBuilder.java
+++ /dev/null
@@ -1,147 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-package org.apache.iceberg.spark.data.vectorized;
-
-import java.util.List;
-import java.util.Map;
-import java.util.function.Function;
-import java.util.stream.IntStream;
-import org.apache.iceberg.MetadataColumns;
-import org.apache.iceberg.Schema;
-import org.apache.iceberg.data.DeleteFilter;
-import org.apache.iceberg.parquet.TypeWithSchemaVisitor;
-import org.apache.iceberg.parquet.VectorizedReader;
-import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList;
-import org.apache.iceberg.relocated.com.google.common.collect.Lists;
-import org.apache.iceberg.relocated.com.google.common.collect.Maps;
-import org.apache.iceberg.spark.SparkSchemaUtil;
-import org.apache.iceberg.types.Types;
-import org.apache.parquet.column.ColumnDescriptor;
-import org.apache.parquet.schema.GroupType;
-import org.apache.parquet.schema.MessageType;
-import org.apache.parquet.schema.PrimitiveType;
-import org.apache.parquet.schema.Type;
-import org.apache.spark.sql.catalyst.InternalRow;
-
-class CometVectorizedReaderBuilder extends TypeWithSchemaVisitor<VectorizedReader<?>> {
-
- private final MessageType parquetSchema;
- private final Schema icebergSchema;
- private final Map<Integer, ?> idToConstant;
- private final Function<List<VectorizedReader<?>>, VectorizedReader<?>> readerFactory;
- private final DeleteFilter<InternalRow> deleteFilter;
-
- CometVectorizedReaderBuilder(
- Schema expectedSchema,
- MessageType parquetSchema,
- Map<Integer, ?> idToConstant,
- Function<List<VectorizedReader<?>>, VectorizedReader<?>> readerFactory,
- DeleteFilter<InternalRow> deleteFilter) {
- this.parquetSchema = parquetSchema;
- this.icebergSchema = expectedSchema;
- this.idToConstant = idToConstant;
- this.readerFactory = readerFactory;
- this.deleteFilter = deleteFilter;
- }
-
- @Override
- public VectorizedReader<?> message(
- Types.StructType expected, MessageType message, List<VectorizedReader<?>> fieldReaders) {
- GroupType groupType = message.asGroupType();
- Map<Integer, VectorizedReader<?>> readersById = Maps.newHashMap();
- List<Type> fields = groupType.getFields();
-
- IntStream.range(0, fields.size())
- .filter(pos -> fields.get(pos).getId() != null)
- .forEach(pos -> readersById.put(fields.get(pos).getId().intValue(), fieldReaders.get(pos)));
-
- List<Types.NestedField> icebergFields =
- expected != null ? expected.fields() : ImmutableList.of();
-
- List<VectorizedReader<?>> reorderedFields =
- Lists.newArrayListWithExpectedSize(icebergFields.size());
-
- for (Types.NestedField field : icebergFields) {
- int id = field.fieldId();
- VectorizedReader<?> reader = readersById.get(id);
- if (idToConstant.containsKey(id)) {
- CometConstantColumnReader constantReader =
- new CometConstantColumnReader<>(idToConstant.get(id), field);
- reorderedFields.add(constantReader);
- } else if (id == MetadataColumns.ROW_POSITION.fieldId()) {
- reorderedFields.add(new CometPositionColumnReader(field));
- } else if (id == MetadataColumns.IS_DELETED.fieldId()) {
- CometColumnReader deleteReader = new CometDeleteColumnReader<>(field);
- reorderedFields.add(deleteReader);
- } else if (reader != null) {
- reorderedFields.add(reader);
- } else if (field.initialDefault() != null) {
- CometColumnReader constantReader =
- new CometConstantColumnReader<>(field.initialDefault(), field);
- reorderedFields.add(constantReader);
- } else if (field.isOptional()) {
- CometColumnReader constantReader = new CometConstantColumnReader<>(null, field);
- reorderedFields.add(constantReader);
- } else {
- throw new IllegalArgumentException(
- String.format("Missing required field: %s", field.name()));
- }
- }
- return vectorizedReader(reorderedFields);
- }
-
- protected VectorizedReader<?> vectorizedReader(List<VectorizedReader<?>> reorderedFields) {
- VectorizedReader<?> reader = readerFactory.apply(reorderedFields);
- if (deleteFilter != null) {
- ((CometColumnarBatchReader) reader).setDeleteFilter(deleteFilter);
- }
- return reader;
- }
-
- @Override
- public VectorizedReader<?> struct(
- Types.StructType expected, GroupType groupType, List<VectorizedReader<?>> fieldReaders) {
- if (expected != null) {
- throw new UnsupportedOperationException(
- "Vectorized reads are not supported yet for struct fields");
- }
- return null;
- }
-
- @Override
- public VectorizedReader<?> primitive(
- org.apache.iceberg.types.Type.PrimitiveType expected, PrimitiveType primitive) {
-
- if (primitive.getId() == null) {
- return null;
- }
- int parquetFieldId = primitive.getId().intValue();
- ColumnDescriptor desc = parquetSchema.getColumnDescription(currentPath());
- // Nested types not yet supported for vectorized reads
- if (desc.getMaxRepetitionLevel() > 0) {
- return null;
- }
- Types.NestedField icebergField = icebergSchema.findField(parquetFieldId);
- if (icebergField == null) {
- return null;
- }
-
- return new CometColumnReader(SparkSchemaUtil.convert(icebergField.type()), desc);
- }
-}
diff --git a/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/VectorizedSparkParquetReaders.java b/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/VectorizedSparkParquetReaders.java
index b523bc5bff..636ad3be7d 100644
--- a/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/VectorizedSparkParquetReaders.java
+++ b/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/VectorizedSparkParquetReaders.java
@@ -70,23 +70,6 @@ public class VectorizedSparkParquetReaders {
deleteFilter));
}
- public static CometColumnarBatchReader buildCometReader(
- Schema expectedSchema,
- MessageType fileSchema,
- Map<Integer, ?> idToConstant,
- DeleteFilter<InternalRow> deleteFilter) {
- return (CometColumnarBatchReader)
- TypeWithSchemaVisitor.visit(
- expectedSchema.asStruct(),
- fileSchema,
- new CometVectorizedReaderBuilder(
- expectedSchema,
- fileSchema,
- idToConstant,
- readers -> new CometColumnarBatchReader(readers, expectedSchema),
- deleteFilter));
- }
-
// enables unsafe memory access to avoid costly checks to see if index is within bounds
// as long as it is not configured explicitly (see BoundsChecking in Arrow)
private static void enableUnsafeMemoryAccess() {
diff --git a/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/BaseBatchReader.java b/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/BaseBatchReader.java
index 780e1750a5..25f253eede 100644
--- a/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/BaseBatchReader.java
+++ b/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/BaseBatchReader.java
@@ -34,7 +34,6 @@ import org.apache.iceberg.parquet.Parquet;
import org.apache.iceberg.relocated.com.google.common.collect.Sets;
import org.apache.iceberg.spark.OrcBatchReadConf;
import org.apache.iceberg.spark.ParquetBatchReadConf;
-import org.apache.iceberg.spark.ParquetReaderType;
import org.apache.iceberg.spark.data.vectorized.VectorizedSparkOrcReaders;
import org.apache.iceberg.spark.data.vectorized.VectorizedSparkParquetReaders;
import org.apache.iceberg.types.TypeUtil;
@@ -92,15 +91,9 @@ abstract class BaseBatchReader<T extends ScanTask> extends BaseReader<ColumnarBa
.project(requiredSchema)
.split(start, length)
.createBatchedReaderFunc(
- fileSchema -> {
- if (parquetConf.readerType() == ParquetReaderType.COMET) {
- return VectorizedSparkParquetReaders.buildCometReader(
- requiredSchema, fileSchema, idToConstant, deleteFilter);
- } else {
- return VectorizedSparkParquetReaders.buildReader(
- requiredSchema, fileSchema, idToConstant, deleteFilter);
- }
- })
+ fileSchema ->
+ VectorizedSparkParquetReaders.buildReader(
+ requiredSchema, fileSchema, idToConstant, deleteFilter))
.recordsPerBatch(parquetConf.batchSize())
.filter(residual)
.caseSensitive(caseSensitive())
diff --git a/spark/v3.4/spark/src/test/java/org/apache/iceberg/SparkDistributedDataScanTestBase.java b/spark/v3.4/spark/src/test/java/org/apache/iceberg/SparkDistributedDataScanTestBase.java
index 404ba72846..00e97e96f9 100644
--- a/spark/v3.4/spark/src/test/java/org/apache/iceberg/SparkDistributedDataScanTestBase.java
+++ b/spark/v3.4/spark/src/test/java/org/apache/iceberg/SparkDistributedDataScanTestBase.java
@@ -90,6 +90,16 @@ public abstract class SparkDistributedDataScanTestBase
.master("local[2]")
.config("spark.serializer", serializer)
.config(SQLConf.SHUFFLE_PARTITIONS().key(), "4")
+ .config("spark.plugins", "org.apache.spark.CometPlugin")
+ .config(
+ "spark.shuffle.manager",
+ "org.apache.spark.sql.comet.execution.shuffle.CometShuffleManager")
+ .config("spark.comet.explainFallback.enabled", "true")
+ .config("spark.comet.scan.icebergNative.enabled", "true")
+ .config("spark.memory.offHeap.enabled", "true")
+ .config("spark.memory.offHeap.size", "10g")
+ .config("spark.comet.use.lazyMaterialization", "false")
+ .config("spark.comet.schemaEvolution.enabled", "true")
.getOrCreate();
}
}
diff --git a/spark/v3.4/spark/src/test/java/org/apache/iceberg/TestSparkDistributedDataScanDeletes.java b/spark/v3.4/spark/src/test/java/org/apache/iceberg/TestSparkDistributedDataScanDeletes.java
index 9361c63176..9a78bbf3b6 100644
--- a/spark/v3.4/spark/src/test/java/org/apache/iceberg/TestSparkDistributedDataScanDeletes.java
+++ b/spark/v3.4/spark/src/test/java/org/apache/iceberg/TestSparkDistributedDataScanDeletes.java
@@ -69,6 +69,16 @@ public class TestSparkDistributedDataScanDeletes
.master("local[2]")
.config("spark.serializer", "org.apache.spark.serializer.KryoSerializer")
.config(SQLConf.SHUFFLE_PARTITIONS().key(), "4")
+ .config("spark.plugins", "org.apache.spark.CometPlugin")
+ .config(
+ "spark.shuffle.manager",
+ "org.apache.spark.sql.comet.execution.shuffle.CometShuffleManager")
+ .config("spark.comet.explainFallback.enabled", "true")
+ .config("spark.comet.scan.icebergNative.enabled", "true")
+ .config("spark.memory.offHeap.enabled", "true")
+ .config("spark.memory.offHeap.size", "10g")
+ .config("spark.comet.use.lazyMaterialization", "false")
+ .config("spark.comet.schemaEvolution.enabled", "true")
.getOrCreate();
}
diff --git a/spark/v3.4/spark/src/test/java/org/apache/iceberg/TestSparkDistributedDataScanFilterFiles.java b/spark/v3.4/spark/src/test/java/org/apache/iceberg/TestSparkDistributedDataScanFilterFiles.java
index a218f965ea..eca0125ace 100644
--- a/spark/v3.4/spark/src/test/java/org/apache/iceberg/TestSparkDistributedDataScanFilterFiles.java
+++ b/spark/v3.4/spark/src/test/java/org/apache/iceberg/TestSparkDistributedDataScanFilterFiles.java
@@ -62,6 +62,16 @@ public class TestSparkDistributedDataScanFilterFiles
.master("local[2]")
.config("spark.serializer", "org.apache.spark.serializer.KryoSerializer")
.config(SQLConf.SHUFFLE_PARTITIONS().key(), "4")
+ .config("spark.plugins", "org.apache.spark.CometPlugin")
+ .config(
+ "spark.shuffle.manager",
+ "org.apache.spark.sql.comet.execution.shuffle.CometShuffleManager")
+ .config("spark.comet.explainFallback.enabled", "true")
+ .config("spark.comet.scan.icebergNative.enabled", "true")
+ .config("spark.memory.offHeap.enabled", "true")