uraniborg/s/p/automate_observation.py Updated copyright year and bug …#3
Merged
billy-lau merged 1 commit intoandroid:mainfrom May 11, 2026
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces an ensure_android_sdk function to automate Android SDK detection and configuration, updates the copyright year, and ensures symlink directories are created. Feedback focuses on increasing the robustness of the SDK detection logic by validating paths, improving the parsing and writing of local.properties to handle whitespace and missing newlines, and advising against interactive input to ensure compatibility with CI/CD environments.
…fix. Fix a bug that was introduced when prebuilt binaries were removed, and the directory that the script relied on to create symlinks is now gone. Also made sure that the Android SDK's location is known and exists before proceeding to call gradle to build Hubble APK. Change-Id: Ia385e790e26ff352635215fd211447f8f6acaca4
billy-lau
force-pushed
the
bug-fix/account-for-missing-prebuilt-dir
branch
from
1337133 to
1337133
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…fix.
Fix a bug that was introduced when prebuilt binaries were removed, and the directory that the script relied on to create symlinks is now gone.
Also made sure that the Android SDK's location is known and exists before proceeding to call gradle to build Hubble APK.
Change-Id: Ia37be790e26ff352635215fd211447f8ebc0bdd3