Model inconsistencies

[tillprochaska]

Rather than creating a separate issue every time I encounter an inconsistency in the FtM data model, I’ll simply use this discussion to keep a list for future reference.

• Passport has two different passport number properties #924
• Contract has a title and a name (inherited from Thing).
• Event has a location property and address/addressEntity (inherited from Thing). See Proposal for some schema changes #952
• Names/labels of Document (label: "File") and Pages (label: "Document") are confusing

[yharahuts]

LegalEntity have it's phone number as phone property, and UserAccount have it's as a number.

I guess both properties should be same - phoneNumber maybe?

[pudo]

I'd vote making UserAccount.phone, since UserAccount is barely used anywhere.

[yharahuts]

Post have organization as string, while Employment have employer as entity link.

[pudo]

That's pretty consistent around all the link types (director, owner, asset) etc.

[yharahuts]

@pudo
Directorship - director and organization is both entities (but a secretary isnt 🙄)
Ownership - owner and asset both entities
Employment - employer and employee both entities

So everything above can be used a link between Company and a Person.

Post - holder is entity, but organization is a string - so it can't be used as a link. Probably organization should be entity too?

[pudo]

No, that's the entire rationale for doing Post rather than Employment: to allow to depict people's CVs without ending up with dumb pseudo-entities: #761

[yharahuts]

Oh I see now.

Thank you for clarifying.