inactive rows gray text - #220
Conversation
agent-era
commented
Apr 22, 2026
- tracker: seed item files for inactive-rows-gray-text
- fix(tracker): show inactive item secondary rows as gray regardless of agent state
… agent state Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Code Review — PR #220: inactive rows gray textOverviewReorders the color-chain priority in Code Quality ✅The fix is clean and focused. Reordering the ternary chain is the right approach — checking Potential Issue — Double-dim on inactive itemsconst color = item.inactive ? 'gray' : readyToAdvance ? 'green' : ...
const dim = item.inactive || (!readyToAdvance && !isWaiting && !isWorking);An inactive item gets both Test Coverage
|
|
Code Review: PR 220 - inactive rows gray text Overview: Small, focused UI fix correcting color priority ordering for inactive tracker items in TrackerBoardScreen.tsx. Secondary rows were inheriting bright colors (green/yellow/cyan) from agent state flags that should not override the inactive indicator. Code Quality Color priority reordering: moving item.inactive ? 'gray' to the top of the ternary chain ensures it always wins over readyToAdvance, isWaiting, and isWorking. The previous order let active-state colors override the inactive signal. Dim flag: item.inactive || (!readyToAdvance && !isWaiting && !isWorking) correctly dims inactive items regardless of agent state. Bold suppression: !item.inactive && (isWaiting || readyToAdvance) correctly prevents bold text on inactive items. All three properties are handled consistently - an earlier fix that caught only color but not dim/bold would still render subtly wrong. Suggestions: None - this is tight and correct. No tests are expected for a pure visual priority reorder of this scope. Verdict: Approve |