Skip to content

inactive rows gray text - #220

Merged
agent-era merged 2 commits into
mainfrom
inactive-rows-gray-text
Apr 22, 2026
Merged

inactive rows gray text#220
agent-era merged 2 commits into
mainfrom
inactive-rows-gray-text

Conversation

@agent-era

Copy link
Copy Markdown
Owner
  • tracker: seed item files for inactive-rows-gray-text
  • fix(tracker): show inactive item secondary rows as gray regardless of agent state

@claude

claude Bot commented Apr 22, 2026

Copy link
Copy Markdown

Code Review — PR #220: inactive rows gray text

Overview

Reorders the color-chain priority in TrackerBoardScreen.tsx so that item.inactive is checked first, ensuring secondary rows always render as gray regardless of agent state (waiting/working/ready). Also suppresses bold and ensures dimColor for inactive items.

Code Quality ✅

The fix is clean and focused. Reordering the ternary chain is the right approach — checking inactive first prevents any of the state flags from overriding it.

Potential Issue — Double-dim on inactive items

const color = item.inactive ? 'gray' : readyToAdvance ? 'green' : ...
const dim = item.inactive || (!readyToAdvance && !isWaiting && !isWorking);

An inactive item gets both color="gray" and dimColor={true}. In Ink, dimColor dims the terminal foreground color. Gray + dimColor may render noticeably darker than intended (potentially invisible on dark terminals). Worth checking visually whether color="gray" alone (without dimColor) achieves the desired look for inactive rows.

Test Coverage ⚠️

No tests were added. UI color/style changes are hard to test in Jest, but the E2E terminal tests (tests/e2e/terminal/) could assert that inactive item rows don't include ANSI bold/bright codes. Consider adding a quick terminal test if the double-dim concern above is validated.

Minor

The requirements file is clear and the commit messages follow project conventions.

Verdict: Looks good with one visual concern to verify — the gray + dimColor combination on inactive rows.

@claude

claude Bot commented Apr 22, 2026

Copy link
Copy Markdown

Code Review: PR 220 - inactive rows gray text

Overview: Small, focused UI fix correcting color priority ordering for inactive tracker items in TrackerBoardScreen.tsx. Secondary rows were inheriting bright colors (green/yellow/cyan) from agent state flags that should not override the inactive indicator.

Code Quality

Color priority reordering: moving item.inactive ? 'gray' to the top of the ternary chain ensures it always wins over readyToAdvance, isWaiting, and isWorking. The previous order let active-state colors override the inactive signal.

Dim flag: item.inactive || (!readyToAdvance && !isWaiting && !isWorking) correctly dims inactive items regardless of agent state.

Bold suppression: !item.inactive && (isWaiting || readyToAdvance) correctly prevents bold text on inactive items.

All three properties are handled consistently - an earlier fix that caught only color but not dim/bold would still render subtly wrong.

Suggestions: None - this is tight and correct. No tests are expected for a pure visual priority reorder of this scope.

Verdict: Approve

@agent-era
agent-era merged commit 1dee6d7 into main Apr 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants