feat: Offer --cache option to control cache mode (Incremental Build)#1368
Open
maxreichmann wants to merge 7 commits into
Open
feat: Offer --cache option to control cache mode (Incremental Build)#1368maxreichmann wants to merge 7 commits into
maxreichmann wants to merge 7 commits into
Conversation
13173d5 to
68a130f
Compare
68a130f to
0c087f8
Compare
e1d781f to
ab65f27
Compare
RandomByte
requested changes
May 4, 2026
7aa4cd3 to
95fd5de
Compare
e451d07 to
07a5941
Compare
bbf7099 to
39431de
Compare
0670d94 to
d029efb
Compare
7994eae to
2546932
Compare
2546932 to
4db0fca
Compare
Member
Author
|
Rebased onto base branch |
Fix all unit tests which are NOT failing in base branch ("feat-incremental-build-4")
cafca18 to
f2ff30d
Compare
4be8ab8 to
7164b79
Compare
RandomByte
requested changes
May 13, 2026
Member
|
Adding @KlattG since this PR changes a lot of user-facing texts |
6e065f0 to
db051ab
Compare
flovogt
reviewed
May 19, 2026
Co-authored-by: Florian Vogt <florian.vogt@sap.com>
7dec71b to
876b2f3
Compare
c9c4972 to
2862e0f
Compare
KlattG
requested changes
May 22, 2026
Contributor
KlattG
left a comment
There was a problem hiding this comment.
Nothing major, just a few things I noticed
|
|
||
| With UI5 CLI v5, the option `--cache-mode` (for commands `ui5 build` and `ui5 serve`) has been renamed to `--snapshot-cache`. | ||
|
|
||
| When legacy `--cache-mode` is used, the behavior remains the same but a deprecation warning is logged. When both `--snapshot-cache` and `--cache-mode` are used, successor `--snapshot-cache` always gets priority. |
Contributor
There was a problem hiding this comment.
Suggested change
| When legacy `--cache-mode` is used, the behavior remains the same but a deprecation warning is logged. When both `--snapshot-cache` and `--cache-mode` are used, successor `--snapshot-cache` always gets priority. | |
| When legacy `--cache-mode` is used, the behavior remains the same but a deprecation warning is logged. When both `--snapshot-cache` and `--cache-mode` are used, the `--snapshot-cache` flag always gets priority. |
Comment on lines
+92
to
+93
| "The 'Default' behavior is to always use the cache if available. 'Force' uses the cache only " + | ||
| "(if it's unavailable or invalid, the build fails). 'ReadOnly' does not create or update any " + |
Contributor
There was a problem hiding this comment.
Suggested change
| "The 'Default' behavior is to always use the cache if available. 'Force' uses the cache only " + | |
| "(if it's unavailable or invalid, the build fails). 'ReadOnly' does not create or update any " + | |
| "The 'Default' behavior is to always use the cache if available. 'Force' uses the cache only. " + | |
| "If the cache is unavailable or invalid, the build fails. 'ReadOnly' does not create or update any " + |
| .coerce("cache-mode", (opt) => { | ||
| // Log a warning if this option is used | ||
| if (opt !== undefined) { | ||
| log.warn("As of UI5 CLI version 5, '--cache-mode' was renamed to '--snapshot-cache'. " + |
Contributor
There was a problem hiding this comment.
Suggested change
| log.warn("As of UI5 CLI version 5, '--cache-mode' was renamed to '--snapshot-cache'. " + | |
| log.warn("As of UI5 CLI version 5, '--cache-mode' is renamed to '--snapshot-cache'. " + |
Comment on lines
+69
to
+70
| "The 'Default' behavior is to always use the cache if available. 'Force' uses the cache only " + | ||
| "(if it's unavailable or invalid, the build fails). 'Read-only' does not create or update any " + |
Contributor
There was a problem hiding this comment.
see above
Suggested change
| "The 'Default' behavior is to always use the cache if available. 'Force' uses the cache only " + | |
| "(if it's unavailable or invalid, the build fails). 'Read-only' does not create or update any " + | |
| "The 'Default' behavior is to always use the cache if available. 'Force' uses the cache only. " + | |
| "If the cache is unavailable or invalid, the build fails. 'Read-only' does not create or update any " + |
| .coerce("cache-mode", (opt) => { | ||
| // Log a warning if this option is used | ||
| if (opt !== undefined) { | ||
| log.warn("As of UI5 CLI version 5, '--cache-mode' was renamed to '--snapshot-cache'. " + |
Contributor
There was a problem hiding this comment.
Suggested change
| log.warn("As of UI5 CLI version 5, '--cache-mode' was renamed to '--snapshot-cache'. " + | |
| log.warn("As of UI5 CLI version 5, '--cache-mode' is renamed to '--snapshot-cache'. " + |
| * @readonly | ||
| * @enum {string} | ||
| * @property {string} Default Use cache if available | ||
| * @property {string} Force Use cache only (if it's unavailable or invalid, the build fails) |
Contributor
There was a problem hiding this comment.
Suggested change
| * @property {string} Force Use cache only (if it's unavailable or invalid, the build fails) | |
| * @property {string} Force Use cache only. If the cache is unavailable or invalid, the build fails |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of Incremental Build: #1267
JIRA: CPOUI5FOUNDATION-1208
--cachewith values "Default", "ReadOnly", "Force" and "Off" for commands "ui5 build" and "ui5 serve"--cache-modeto--snapshot-cache