Add Rails engine support to UrlHelpers compiler#2632
Open
bdewater-thatch wants to merge 1 commit into
Open
Conversation
bdewater-thatch
force-pushed
the
url-helpers-engine-support
branch
from
5dab70a to
33f1327
Compare
KaanOzkan
reviewed
Jun 4, 2026
Contributor
KaanOzkan
left a comment
KaanOzkan
left a comment
There was a problem hiding this comment.
Implementation looks fine to me but as someone without much context on the compiler it was difficult to wrap my head around it. I have some suggestions on how to improve maintainability. Curious to hear if you have more ideas.
bdewater-thatch
force-pushed
the
url-helpers-engine-support
branch
from
33f1327 to
006de5e
Compare
Discover Rails engines during URL helper generation and register their engine-scoped path and URL helper modules. Generate mounted helper RBIs for engine mount points, including typed routes proxy classes that include the engine helper modules. Add mounted helper mixins only for classes/modules that actually receive Rails' mounted helpers, and cover the new behavior with regression tests.
bdewater-thatch
force-pushed
the
url-helpers-engine-support
branch
from
006de5e to
e96f1f5
Compare
Contributor
Author
|
@KaanOzkan addressed your feedback, PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Discover Rails engines during URL helper generation and register their engine-scoped path and URL helper modules. Fixes #474
Generate mounted helper RBIs for engine mount points, including typed routes proxy classes that include the engine helper modules. Add mounted helper mixins only for classes/modules that actually receive Rails' mounted helpers, and cover the new behavior with regression tests.
Implementation
AI assisted with manual refactoring + testing on our own app.