From e314edabadd5ca994f83ca3be50d2c2281d3dd43 Mon Sep 17 00:00:00 2001 From: Stefan Werner Date: Wed, 11 Jun 2025 21:54:06 +0200 Subject: [PATCH 1/5] Warn user when CMAKE_CXX_FLAGS are being ignored. --- common/cmake/clang.cmake | 5 ++++- common/cmake/dpcpp.cmake | 5 ++++- common/cmake/gnu.cmake | 5 ++++- common/cmake/intel.cmake | 5 ++++- 4 files changed, 16 insertions(+), 4 deletions(-) diff --git a/common/cmake/clang.cmake b/common/cmake/clang.cmake index 2666d1be8b..261ba52664 100644 --- a/common/cmake/clang.cmake +++ b/common/cmake/clang.cmake @@ -82,7 +82,10 @@ ELSE() OPTION(EMBREE_IGNORE_CMAKE_CXX_FLAGS "When enabled Embree ignores default CMAKE_CXX_FLAGS." ON) OPTION(EMBREE_ADDRESS_SANITIZER "Enabled CLANG address sanitizer." OFF) - IF (EMBREE_IGNORE_CMAKE_CXX_FLAGS) + IF(EMBREE_IGNORE_CMAKE_CXX_FLAGS) + IF(CMAKE_CXX_FLAGS) + MESSAGE(WARNING "Ignoring CMAKE_CXX_FLAGS because EMBREE_IGNORE_CMAKE_CXX_FLAGS is enabled.") + ENDIF() SET(CMAKE_CXX_FLAGS "") ENDIF() diff --git a/common/cmake/dpcpp.cmake b/common/cmake/dpcpp.cmake index a15c179ab9..e9486d35a5 100644 --- a/common/cmake/dpcpp.cmake +++ b/common/cmake/dpcpp.cmake @@ -15,7 +15,10 @@ _SET_IF_EMPTY(FLAGS_AVX512 "-march=skx") IF (NOT WIN32) OPTION(EMBREE_IGNORE_CMAKE_CXX_FLAGS "When enabled Embree ignores default CMAKE_CXX_FLAGS." ON) - IF (EMBREE_IGNORE_CMAKE_CXX_FLAGS) + IF(EMBREE_IGNORE_CMAKE_CXX_FLAGS) + IF(CMAKE_CXX_FLAGS) + MESSAGE(WARNING "Ignoring CMAKE_CXX_FLAGS because EMBREE_IGNORE_CMAKE_CXX_FLAGS is enabled.") + ENDIF() SET(CMAKE_CXX_FLAGS "") ENDIF() ENDIF() diff --git a/common/cmake/gnu.cmake b/common/cmake/gnu.cmake index 365212bdda..13cf28a61d 100644 --- a/common/cmake/gnu.cmake +++ b/common/cmake/gnu.cmake @@ -21,7 +21,10 @@ ELSE () ENDIF () OPTION(EMBREE_IGNORE_CMAKE_CXX_FLAGS "When enabled Embree ignores default CMAKE_CXX_FLAGS." ON) -IF (EMBREE_IGNORE_CMAKE_CXX_FLAGS) +IF(EMBREE_IGNORE_CMAKE_CXX_FLAGS) + IF(CMAKE_CXX_FLAGS) + MESSAGE(WARNING "Ignoring CMAKE_CXX_FLAGS because EMBREE_IGNORE_CMAKE_CXX_FLAGS is enabled.") + ENDIF() SET(CMAKE_CXX_FLAGS "") ENDIF() diff --git a/common/cmake/intel.cmake b/common/cmake/intel.cmake index 2c8e86e6c5..609b83eb73 100644 --- a/common/cmake/intel.cmake +++ b/common/cmake/intel.cmake @@ -101,7 +101,10 @@ ELSE() _SET_IF_EMPTY(FLAGS_AVX512 "-xCORE-AVX512") OPTION(EMBREE_IGNORE_CMAKE_CXX_FLAGS "When enabled Embree ignores default CMAKE_CXX_FLAGS." ON) - IF (EMBREE_IGNORE_CMAKE_CXX_FLAGS) + IF(EMBREE_IGNORE_CMAKE_CXX_FLAGS) + IF(CMAKE_CXX_FLAGS) + MESSAGE(WARNING "Ignoring CMAKE_CXX_FLAGS because EMBREE_IGNORE_CMAKE_CXX_FLAGS is enabled.") + ENDIF() SET(CMAKE_CXX_FLAGS "") ENDIF() From 9fbce4f70a1b5798c144cf3424d106c73ce75766 Mon Sep 17 00:00:00 2001 From: Stefan Werner Date: Tue, 14 Apr 2026 08:17:38 +0200 Subject: [PATCH 2/5] Update common/cmake/intel.cmake Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- common/cmake/intel.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/cmake/intel.cmake b/common/cmake/intel.cmake index 609b83eb73..f57f44dcd1 100644 --- a/common/cmake/intel.cmake +++ b/common/cmake/intel.cmake @@ -103,7 +103,7 @@ ELSE() OPTION(EMBREE_IGNORE_CMAKE_CXX_FLAGS "When enabled Embree ignores default CMAKE_CXX_FLAGS." ON) IF(EMBREE_IGNORE_CMAKE_CXX_FLAGS) IF(CMAKE_CXX_FLAGS) - MESSAGE(WARNING "Ignoring CMAKE_CXX_FLAGS because EMBREE_IGNORE_CMAKE_CXX_FLAGS is enabled.") + MESSAGE(WARNING "Ignoring CMAKE_CXX_FLAGS because EMBREE_IGNORE_CMAKE_CXX_FLAGS is enabled. Configure with -DEMBREE_IGNORE_CMAKE_CXX_FLAGS=OFF to honor CMAKE_CXX_FLAGS. Ignored value: '${CMAKE_CXX_FLAGS}'.") ENDIF() SET(CMAKE_CXX_FLAGS "") ENDIF() From 3b7e22ea1f4367944f56b4d1bed30aa477a0061f Mon Sep 17 00:00:00 2001 From: Stefan Werner Date: Tue, 14 Apr 2026 08:17:49 +0200 Subject: [PATCH 3/5] Update common/cmake/clang.cmake Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- common/cmake/clang.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/cmake/clang.cmake b/common/cmake/clang.cmake index 261ba52664..bc1195f5cb 100644 --- a/common/cmake/clang.cmake +++ b/common/cmake/clang.cmake @@ -84,7 +84,7 @@ ELSE() OPTION(EMBREE_ADDRESS_SANITIZER "Enabled CLANG address sanitizer." OFF) IF(EMBREE_IGNORE_CMAKE_CXX_FLAGS) IF(CMAKE_CXX_FLAGS) - MESSAGE(WARNING "Ignoring CMAKE_CXX_FLAGS because EMBREE_IGNORE_CMAKE_CXX_FLAGS is enabled.") + MESSAGE(WARNING "Ignoring CMAKE_CXX_FLAGS because EMBREE_IGNORE_CMAKE_CXX_FLAGS is enabled. Configure with EMBREE_IGNORE_CMAKE_CXX_FLAGS=OFF to honor CMAKE_CXX_FLAGS. Ignored value: '${CMAKE_CXX_FLAGS}'") ENDIF() SET(CMAKE_CXX_FLAGS "") ENDIF() From a2d68077a8321e37e10f91ff0a03acc6cb6d9133 Mon Sep 17 00:00:00 2001 From: Stefan Werner Date: Tue, 14 Apr 2026 08:18:07 +0200 Subject: [PATCH 4/5] Update common/cmake/gnu.cmake Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- common/cmake/gnu.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/cmake/gnu.cmake b/common/cmake/gnu.cmake index 63bb9815c2..5c611d1f7a 100644 --- a/common/cmake/gnu.cmake +++ b/common/cmake/gnu.cmake @@ -23,7 +23,7 @@ ENDIF () OPTION(EMBREE_IGNORE_CMAKE_CXX_FLAGS "When enabled Embree ignores default CMAKE_CXX_FLAGS." ON) IF(EMBREE_IGNORE_CMAKE_CXX_FLAGS) IF(CMAKE_CXX_FLAGS) - MESSAGE(WARNING "Ignoring CMAKE_CXX_FLAGS because EMBREE_IGNORE_CMAKE_CXX_FLAGS is enabled.") + MESSAGE(WARNING "Ignoring CMAKE_CXX_FLAGS because EMBREE_IGNORE_CMAKE_CXX_FLAGS is enabled. Configure with -DEMBREE_IGNORE_CMAKE_CXX_FLAGS=OFF to honor CMAKE_CXX_FLAGS. Ignored value: '${CMAKE_CXX_FLAGS}'.") ENDIF() SET(CMAKE_CXX_FLAGS "") ENDIF() From efb705430eaac21aa5fa1e382099af38a9dd5d65 Mon Sep 17 00:00:00 2001 From: Stefan Werner Date: Tue, 14 Apr 2026 08:18:14 +0200 Subject: [PATCH 5/5] Update common/cmake/dpcpp.cmake Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- common/cmake/dpcpp.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/cmake/dpcpp.cmake b/common/cmake/dpcpp.cmake index e9486d35a5..dc26b5c463 100644 --- a/common/cmake/dpcpp.cmake +++ b/common/cmake/dpcpp.cmake @@ -17,7 +17,7 @@ IF (NOT WIN32) OPTION(EMBREE_IGNORE_CMAKE_CXX_FLAGS "When enabled Embree ignores default CMAKE_CXX_FLAGS." ON) IF(EMBREE_IGNORE_CMAKE_CXX_FLAGS) IF(CMAKE_CXX_FLAGS) - MESSAGE(WARNING "Ignoring CMAKE_CXX_FLAGS because EMBREE_IGNORE_CMAKE_CXX_FLAGS is enabled.") + MESSAGE(WARNING "Ignoring CMAKE_CXX_FLAGS because EMBREE_IGNORE_CMAKE_CXX_FLAGS is enabled. Configure with -DEMBREE_IGNORE_CMAKE_CXX_FLAGS=OFF to honor CMAKE_CXX_FLAGS. Ignored value: ${CMAKE_CXX_FLAGS}") ENDIF() SET(CMAKE_CXX_FLAGS "") ENDIF()