From ea0292b0f8699cb6ac75538c88c68188e47bd6f9 Mon Sep 17 00:00:00 2001 From: Dmitry Mitrofanov <19838200+PixeyeHQ@users.noreply.github.com> Date: Sun, 28 Jun 2020 14:16:22 +0200 Subject: [PATCH 01/10] Update Changelog.md --- Changelog.md | 35 ++++++++++++++++++++++++++--------- 1 file changed, 26 insertions(+), 9 deletions(-) diff --git a/Changelog.md b/Changelog.md index 79da6258..f2664b70 100644 --- a/Changelog.md +++ b/Changelog.md @@ -1,17 +1,34 @@ ## Changelog +### Actors-2020-06-03 +⭐ **Changed** +* [πŸ“˜ Improving Actors + Unity Job](https://github.com/PixeyeHQ/actors.unity/issues/45) +* [πŸ“˜ Add Layer.Get``](https://github.com/PixeyeHQ/actors.unity/issues/47) +* [πŸ“˜ Make scenes work from asset bundles in new version of Actors](https://github.com/PixeyeHQ/actors.unity/issues/51) + +πŸ› οΈ **Fixed** +* [🐞 ApplicationIsQuitting is not working](https://github.com/PixeyeHQ/actors.unity/issues/46) +* [🐞 Setup of Monocached is triggered twice](https://github.com/PixeyeHQ/actors.unity/issues/49) +* [🐞 PostHandleFrameworkPatch.cs(128,1): error CS1022](https://github.com/PixeyeHQ/actors.unity/issues/50) +* [🐞 Object Pooling for Actors on the scene doesn't work properly](https://github.com/PixeyeHQ/actors.unity/issues/54) + +⚠️ **IMPORTANT** ⚠️ +If you have Actors on the scene that must be added to the pool system use field below to add **prefab name** of that object. If you don't want to use pooling system with +the object just leave a blank field. +[![Actor](https://i.gyazo.com/3ec4e26a0b9638016834f5fcd36a36b4.png)](https://gyazo.com/3ec4e26a0b9638016834f5fcd36a36b4) + ### Actors-2020-06-02 πŸ› οΈ **Fixed** -* [🐞Pooled gameobject of entity gets null reference exception.](https://github.com/PixeyeHQ/actors.unity/issues/36) -* [🐞Pooled Actors won't initialize after re-activating.](https://github.com/PixeyeHQ/actors.unity/issues/37) -* [🐞Childs of entities are not initialized.](https://github.com/PixeyeHQ/actors.unity/issues/38) -* [🐞Groups are not cleaned when a scene is reloaded.](https://github.com/PixeyeHQ/actors.unity/issues/39) -* [🐞Actors continue to think that they are on the old layer when using `entity.MoveTo`](https://github.com/PixeyeHQ/actors.unity/issues/40) -* [🐞Unloading scene in the inspector and hitting play breaks the editor.](https://github.com/PixeyeHQ/actors.unity/issues/41) -* [🐞Tools->Actors->Update Actors doesn't work in the Unity 2019.4](https://github.com/PixeyeHQ/actors.unity/issues/43) -* [🐞Updating entities from the Added/Removed Ecs events do not work correctly.](https://github.com/PixeyeHQ/actors.unity/issues/44) +* [🐞 Pooled gameobject of entity gets null reference exception.](https://github.com/PixeyeHQ/actors.unity/issues/36) +* [🐞 Pooled Actors won't initialize after re-activating.](https://github.com/PixeyeHQ/actors.unity/issues/37) +* [🐞 Childs of entities are not initialized.](https://github.com/PixeyeHQ/actors.unity/issues/38) +* [🐞 Groups are not cleaned when a scene is reloaded.](https://github.com/PixeyeHQ/actors.unity/issues/39) +* [🐞 Actors continue to think that they are on the old layer when using `entity.MoveTo`](https://github.com/PixeyeHQ/actors.unity/issues/40) +* [🐞 Unloading scene in the inspector and hitting play breaks the editor.](https://github.com/PixeyeHQ/actors.unity/issues/41) +* [🐞 Tools->Actors->Update Actors doesn't work in the Unity 2019.4](https://github.com/PixeyeHQ/actors.unity/issues/43) +* [🐞 Updating entities from the Added/Removed Ecs events do not work correctly.](https://github.com/PixeyeHQ/actors.unity/issues/44) ### Actors-2020-06 | Codename: Bluefin Tuna -🚧 **IMPORTANT** 🚧 +⚠️ **IMPORTANT** ⚠️ The new version of Actors **is not compatible** with previous versions. If you are using ***Actors-2020-04-30*** or earlier version in the production cycle, please change your manifest link to: ```"com.pixeye.ecs": "https://github.com/PixeyeHQ/actors.unity.git#actors-2020-04-30",``` The framework was rewritten so there is no reason to write down all changes. Look [README](https://github.com/PixeyeHQ/actors.unity/blob/develop/README.md). From f6eddb453791bd590591fa21982fd3618287474f Mon Sep 17 00:00:00 2001 From: Dmitry Mitrofanov <19838200+PixeyeHQ@users.noreply.github.com> Date: Sun, 28 Jun 2020 14:16:48 +0200 Subject: [PATCH 02/10] Update package.json --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index cce849f5..996fe59a 100644 --- a/package.json +++ b/package.json @@ -4,7 +4,7 @@ "displayName": "Actors", "description": "πŸš€ Actors is a framework empowering developers to make better games faster on Unity.", "unity": "2019.4", - "version": "2020.6.2", + "version": "2020.6.3", "keywords": [ "ecs", "pixeye", From 280e105cfcf567a379b23fb4ee5bd292966d3011 Mon Sep 17 00:00:00 2001 From: Dmitry Mitrofanov <19838200+PixeyeHQ@users.noreply.github.com> Date: Sun, 28 Jun 2020 14:19:05 +0200 Subject: [PATCH 03/10] Update Changelog.md --- Changelog.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Changelog.md b/Changelog.md index f2664b70..b3468792 100644 --- a/Changelog.md +++ b/Changelog.md @@ -13,8 +13,8 @@ ⚠️ **IMPORTANT** ⚠️ If you have Actors on the scene that must be added to the pool system use field below to add **prefab name** of that object. If you don't want to use pooling system with -the object just leave a blank field. -[![Actor](https://i.gyazo.com/3ec4e26a0b9638016834f5fcd36a36b4.png)](https://gyazo.com/3ec4e26a0b9638016834f5fcd36a36b4) +the object just leave a blank field. This action is required to register corresponding prefab in the pool. +[![Pooling actor](https://i.gyazo.com/a89593aa71f1dd85b31ba318ec5a4015.png)](https://gyazo.com/a89593aa71f1dd85b31ba318ec5a4015) ### Actors-2020-06-02 πŸ› οΈ **Fixed** From ecd230df1aa2875136e9e8ab172a761a759c9763 Mon Sep 17 00:00:00 2001 From: Dmitry Mitrofanov <19838200+PixeyeHQ@users.noreply.github.com> Date: Sun, 28 Jun 2020 14:21:15 +0200 Subject: [PATCH 04/10] Update Changelog.md --- Changelog.md | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Changelog.md b/Changelog.md index b3468792..8b691b36 100644 --- a/Changelog.md +++ b/Changelog.md @@ -14,7 +14,13 @@ ⚠️ **IMPORTANT** ⚠️ If you have Actors on the scene that must be added to the pool system use field below to add **prefab name** of that object. If you don't want to use pooling system with the object just leave a blank field. This action is required to register corresponding prefab in the pool. -[![Pooling actor](https://i.gyazo.com/a89593aa71f1dd85b31ba318ec5a4015.png)](https://gyazo.com/a89593aa71f1dd85b31ba318ec5a4015) +
+ +Adding Actor to the pool. + +Actor +
+ ### Actors-2020-06-02 πŸ› οΈ **Fixed** From c1df5efffec045768f97d1e03bd46972d4f2dde7 Mon Sep 17 00:00:00 2001 From: mofrison Date: Tue, 30 Jun 2020 16:21:08 +0300 Subject: [PATCH 05/10] Fix adding buildIndex scenes to freeIndexes --- Runtime/Core/SceneSub.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Runtime/Core/SceneSub.cs b/Runtime/Core/SceneSub.cs index e43d3a0e..af468ff1 100644 --- a/Runtime/Core/SceneSub.cs +++ b/Runtime/Core/SceneSub.cs @@ -71,7 +71,7 @@ static void RemoveOp(string sceneName) LayerKernel.LoadJobs.Add(SceneManager.UnloadSceneAsync(sceneName)); LayerKernel.LoadJobs.Add(Resources.UnloadUnusedAssets()); loadedScenes.Remove(sceneName); - freeIndexes.Push(layerIndex); + if (layerIndex >= SceneManager.sceneCountInBuildSettings) { freeIndexes.Push(layerIndex); } } internal static int GetLayerIndex(string sceneName) From 3cadf7ecf495d0d83a7071b898db297ef5be5606 Mon Sep 17 00:00:00 2001 From: Dmitry Mitrofanov <19838200+PixeyeHQ@users.noreply.github.com> Date: Fri, 3 Jul 2020 13:10:06 +0200 Subject: [PATCH 06/10] Update Changelog.md --- Changelog.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Changelog.md b/Changelog.md index 8b691b36..23057491 100644 --- a/Changelog.md +++ b/Changelog.md @@ -1,4 +1,11 @@ ## Changelog +### Actors-2020-06-04 +⭐ **Changed** +πŸ› οΈ **Fixed** +* [🐞 Not adding buildIndex scenes to freeIndexes](https://github.com/PixeyeHQ/actors.unity/issues/58) +* [🐞 Entities don't manage groups and components correctly](https://github.com/PixeyeHQ/actors.unity/issues/59) + + ### Actors-2020-06-03 ⭐ **Changed** * [πŸ“˜ Improving Actors + Unity Job](https://github.com/PixeyeHQ/actors.unity/issues/45) From 163eed4fd3e516c43ac18f313b51f9ac5994b114 Mon Sep 17 00:00:00 2001 From: Dmitry Mitrofanov <19838200+PixeyeHQ@users.noreply.github.com> Date: Fri, 3 Jul 2020 13:16:10 +0200 Subject: [PATCH 07/10] Update Changelog.md --- Changelog.md | 1 - 1 file changed, 1 deletion(-) diff --git a/Changelog.md b/Changelog.md index 23057491..09ef1239 100644 --- a/Changelog.md +++ b/Changelog.md @@ -1,6 +1,5 @@ ## Changelog ### Actors-2020-06-04 -⭐ **Changed** πŸ› οΈ **Fixed** * [🐞 Not adding buildIndex scenes to freeIndexes](https://github.com/PixeyeHQ/actors.unity/issues/58) * [🐞 Entities don't manage groups and components correctly](https://github.com/PixeyeHQ/actors.unity/issues/59) From bcc7cdb5b11d9fcf66c9cbcdd63cb0d5861a42da Mon Sep 17 00:00:00 2001 From: Dmitry Mitrofanov <19838200+PixeyeHQ@users.noreply.github.com> Date: Mon, 6 Jul 2020 12:23:22 +0200 Subject: [PATCH 08/10] Update Changelog.md --- Changelog.md | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/Changelog.md b/Changelog.md index 09ef1239..7eb2a15a 100644 --- a/Changelog.md +++ b/Changelog.md @@ -1,4 +1,13 @@ ## Changelog +### Actors-2020-06-05 +⭐ **Changed** +* [πŸ“˜ Add Layer.Add``](https://github.com/PixeyeHQ/actors.unity/issues/61) + +πŸ› οΈ **Fixed** +* [🐞 Entities don't manage groups correctly](https://github.com/PixeyeHQ/actors.unity/issues/60) +* [🐞 ACTORS_EVENTS_MANUAL doesn't work correctly](https://github.com/PixeyeHQ/actors.unity/issues/62) + + ### Actors-2020-06-04 πŸ› οΈ **Fixed** * [🐞 Not adding buildIndex scenes to freeIndexes](https://github.com/PixeyeHQ/actors.unity/issues/58) From e224f8ed90115ff2519af17a20ec34d46b54e87b Mon Sep 17 00:00:00 2001 From: Dmitry Mitrofanov <19838200+PixeyeHQ@users.noreply.github.com> Date: Mon, 6 Jul 2020 12:23:55 +0200 Subject: [PATCH 09/10] Update package.json --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 03c1aede..4be0e73c 100644 --- a/package.json +++ b/package.json @@ -4,7 +4,7 @@ "displayName": "Actors", "description": "πŸš€ Actors is a framework empowering developers to make better games faster on Unity.", "unity": "2019.4", - "version": "2020.6.4", + "version": "2020.6.5", "keywords": [ "ecs", "pixeye", From dc02d8986a83d366d0f5f70369bd9c30f49bbd19 Mon Sep 17 00:00:00 2001 From: JimboA <47698839+JimboA@users.noreply.github.com> Date: Wed, 12 May 2021 01:21:35 +0700 Subject: [PATCH 10/10] removing a group with an excluding attribute from the cacheGroup --- Runtime/LibEcs/GroupCore.cs | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Runtime/LibEcs/GroupCore.cs b/Runtime/LibEcs/GroupCore.cs index 2e102e67..75829a78 100644 --- a/Runtime/LibEcs/GroupCore.cs +++ b/Runtime/LibEcs/GroupCore.cs @@ -286,6 +286,12 @@ public virtual void Dispose() removed = new ents(LayerKernel.Settings.SizeEntities); #endif length = 0; + + for (var i = 0; i < composition.excluded.Length; i++) + { + ref var m = ref composition.excluded[i]; + Storage.All[m.id].groups[layer.id].Remove(this); + } //parallel if (segmentGroups != null) @@ -900,4 +906,4 @@ public void Reset() } } } -} \ No newline at end of file +}