OXT-792: OCaml platform -> meta-openxt-ocaml-platform#445
Merged
Conversation
This PR will require a corresponding PR for meta-openxt-ocaml-platform.git and a new layer definition file for openxt.git. It will affect build sites due to the need to clone the new OCaml repository into place for future builds. Signed-off-by: Christopher Clark christopher.clark6@baesystems.com
Contributor
Author
|
Please could one of the repository maintainers let me know the next steps to proceed with this and the other related initial stratification PRs for Ocaml and Haskell layers -- thanks. |
Member
Contributor
|
It's not good for the image of the community to have PR's unmaintained by the originators and sitting in queue for this long. I would suggest the meta-openxt-ocaml PR's be rejected until such time as they can be properly maintained. |
Contributor
Author
|
These PRs are in my queue to refresh next week. |
Contributor
Author
|
From inspection, this PR remains clean to merge along with corresponding openxt PR 203: OpenXT/openxt#203. |
Member
|
lgtm merging soon |
Member
|
Hmm, did you test this? |
Member
|
Yes, but you are welcome to do your own build to test as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will require a corresponding PR for
meta-openxt-ocaml-platform.git and a new layer definition file for
openxt.git. It will affect build sites due to the need to clone the new
OCaml repository into place for future builds.
Signed-off-by: Christopher Clark christopher.clark6@baesystems.com