fix: replace colons in command filenames for Windows compatibility#317
fix: replace colons in command filenames for Windows compatibility#317jamiechicago312 wants to merge 2 commits into
Conversation
Replace colons with dashes in generated command filenames to avoid Windows filesystem restrictions (colon is reserved character). Also rename existing colon-named files: - automation:create.md -> automation-create.md - slack-monitor:poll.md -> slack-monitor-poll.md - github-monitor:poll.md -> github-monitor-poll.md - And 5 more similar renames Closes OpenHands#230
Co-authored-by: openhands <openhands@all-hands.dev>
jamiechicago312
left a comment
There was a problem hiding this comment.
Nice fix. Replacing : with - in generated command filenames keeps the change small and easy to maintain, while the command trigger itself still stays unchanged. I pushed one follow-up commit (84a2f6c) that adds a focused regression test so this Windows-compatibility behavior stays covered going forward.
Validation I ran:
.venv/bin/python -m pytest -q tests/test_sync_extensions.py.venv/bin/python scripts/sync_extensions.py --check
This review was created by an AI agent (OpenHands) on behalf of the user.
|
@malhotra5 I think there are other examples where colons are used in SKILLS related to pre-built automations, such as |
|
Also just to note, in the latest versions of agent canvas we no longer git clone the extensions repo. Rather we bundle the npm package for the extensions repo directly into the agent canvas. Nevertheless this seems like a good fix to get in |
Fixes #230
Problem
Colons in filenames (e.g.,
automation:create.md) break git sync on Windows.Solution
:with-inscripts/sync_extensions.pyCreated by AI agent on behalf of @jamiechicago312